[PATCH do not merge 0/4] wifi: mwifiex: add iw61x support

Sascha Hauer posted 4 patches 10 months, 2 weeks ago
drivers/net/wireless/marvell/mwifiex/cmdevt.c    | 86 ++++++++++++++++++++++++
drivers/net/wireless/marvell/mwifiex/fw.h        | 16 +++++
drivers/net/wireless/marvell/mwifiex/main.c      |  9 +--
drivers/net/wireless/marvell/mwifiex/main.h      |  4 ++
drivers/net/wireless/marvell/mwifiex/sdio.c      | 81 +++++++++++++++++++++-
drivers/net/wireless/marvell/mwifiex/sdio.h      |  3 +
drivers/net/wireless/marvell/mwifiex/sta_event.c |  4 ++
drivers/net/wireless/marvell/mwifiex/uap_event.c |  4 ++
include/linux/mmc/sdio_ids.h                     |  3 +
9 files changed, 205 insertions(+), 5 deletions(-)
[PATCH do not merge 0/4] wifi: mwifiex: add iw61x support
Posted by Sascha Hauer 10 months, 2 weeks ago
This series adds iw61x support to the mwifiex driver. It works for me,
but is not yet ready to be merged. Some people showed interest in it, so
I am sending it here.

All testing and review feedback appreciated.

During startup I get these messages:

[   12.078010] mwifiex_sdio mmc1:0001:1: Unknown GET_HW_SPEC TLV type: 0xff
[   12.078018] mwifiex_sdio mmc1:0001:1: Unknown GET_HW_SPEC TLV type: 0xff
[   12.078024] mwifiex_sdio mmc1:0001:1: Unknown GET_HW_SPEC TLV type: 0x23e
[   12.078029] mwifiex_sdio mmc1:0001:1: Unknown GET_HW_SPEC TLV type: 0x25c

Not sure what these are about, I can't see these handled in the
downstream mwifiex driver as well. Could also be there is some parsing
error. Nevertheless the driver seems to work.

The series applies to v6.14, but should apply to my mwifiex cleanup
series as well.

Sascha

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
Sascha Hauer (4):
      wifi: mwifiex: release firmware at remove time
      wifi: mwifiex: handle VDLL
      wifi: mwifiex: wait longer for SDIO card status
      wifi: mwifiex: add iw61x support

 drivers/net/wireless/marvell/mwifiex/cmdevt.c    | 86 ++++++++++++++++++++++++
 drivers/net/wireless/marvell/mwifiex/fw.h        | 16 +++++
 drivers/net/wireless/marvell/mwifiex/main.c      |  9 +--
 drivers/net/wireless/marvell/mwifiex/main.h      |  4 ++
 drivers/net/wireless/marvell/mwifiex/sdio.c      | 81 +++++++++++++++++++++-
 drivers/net/wireless/marvell/mwifiex/sdio.h      |  3 +
 drivers/net/wireless/marvell/mwifiex/sta_event.c |  4 ++
 drivers/net/wireless/marvell/mwifiex/uap_event.c |  4 ++
 include/linux/mmc/sdio_ids.h                     |  3 +
 9 files changed, 205 insertions(+), 5 deletions(-)
---
base-commit: 1e26c5e28ca5821a824e90dd359556f5e9e7b89f
change-id: 20250326-mwifiex-iw61x-b9570bf30735

Best regards,
-- 
Sascha Hauer <s.hauer@pengutronix.de>
Re: [PATCH do not merge 0/4] wifi: mwifiex: add iw61x support
Posted by Francesco Dolcini 10 months, 2 weeks ago
+Pete/Jesse @NXP

On Wed, Mar 26, 2025 at 01:18:30PM +0100, Sascha Hauer wrote:
> This series adds iw61x support to the mwifiex driver. It works for me,
> but is not yet ready to be merged. Some people showed interest in it, so
> I am sending it here.
> 
> All testing and review feedback appreciated.
> 
> During startup I get these messages:
> 
> [   12.078010] mwifiex_sdio mmc1:0001:1: Unknown GET_HW_SPEC TLV type: 0xff
> [   12.078018] mwifiex_sdio mmc1:0001:1: Unknown GET_HW_SPEC TLV type: 0xff
> [   12.078024] mwifiex_sdio mmc1:0001:1: Unknown GET_HW_SPEC TLV type: 0x23e
> [   12.078029] mwifiex_sdio mmc1:0001:1: Unknown GET_HW_SPEC TLV type: 0x25c
> 
> Not sure what these are about, I can't see these handled in the
> downstream mwifiex driver as well. Could also be there is some parsing
> error. Nevertheless the driver seems to work.
> 
> The series applies to v6.14, but should apply to my mwifiex cleanup
> series as well.
> 
> Sascha
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Sharing this, so maybe you can help on having a way forward for iw61x
chip supported with mainline Linux.

Francesco
Re: [PATCH do not merge 0/4] wifi: mwifiex: add iw61x support
Posted by Ivan T. Ivanov 9 months, 2 weeks ago
Hi,

On 03-31 08:50, Francesco Dolcini wrote:
> Message-ID: <20250331065026.GA12444@francesco-nb>
> 
> +Pete/Jesse @NXP
> 
> On Wed, Mar 26, 2025 at 01:18:30PM +0100, Sascha Hauer wrote:
> > This series adds iw61x support to the mwifiex driver. It works for me,
> > but is not yet ready to be merged. Some people showed interest in it, so
> > I am sending it here.
> > 
> > All testing and review feedback appreciated.
> > 
> > During startup I get these messages:
> > 
> > [   12.078010] mwifiex_sdio mmc1:0001:1: Unknown GET_HW_SPEC TLV type: 0xff
> > [   12.078018] mwifiex_sdio mmc1:0001:1: Unknown GET_HW_SPEC TLV type: 0xff
> > [   12.078024] mwifiex_sdio mmc1:0001:1: Unknown GET_HW_SPEC TLV type: 0x23e

In the downstream driver, branch lf-6.12.3_1.0.0, t his seems to be
MrvlIEtypes_fw_cap_info_t for things like:

FW_CAPINFO_EXT_802_11AX, FW_CAPINFO_EXT_6G ....

> > [   12.078029] mwifiex_sdio mmc1:0001:1: Unknown GET_HW_SPEC TLV type: 0x25c
> > 

This looks like MrvlIEtypes_Secure_Boot_Uuid_t. Doesn't seems too
important.

> > Not sure what these are about, I can't see these handled in the
> > downstream mwifiex driver as well. Could also be there is some parsing
> > error. Nevertheless the driver seems to work.

Yep, it is working. Thank you! I am testing this on FRDM-iMX93, which has
IW612 revision 1.0.

I have to use nxp/sd_w61x_v1.bin.se on this board and NULL firmware_sdiouart
because it seems that firmware return 1 as "strap" value, even if WiFi
is definitely connected over SDIO.

Regards,
Ivan
Re: [PATCH do not merge 0/4] wifi: mwifiex: add iw61x support
Posted by Francesco Dolcini 9 months, 1 week ago
On Tue, Apr 29, 2025 at 03:59:28PM +0300, Ivan T. Ivanov wrote:
> On 03-31 08:50, Francesco Dolcini wrote:
> > Message-ID: <20250331065026.GA12444@francesco-nb>
> > On Wed, Mar 26, 2025 at 01:18:30PM +0100, Sascha Hauer wrote:
> > > This series adds iw61x support to the mwifiex driver. It works for me,
> > > but is not yet ready to be merged. Some people showed interest in it, so
> > > I am sending it here.

...

> > > Not sure what these are about, I can't see these handled in the
> > > downstream mwifiex driver as well. Could also be there is some parsing
> > > error. Nevertheless the driver seems to work.
> 
> Yep, it is working. Thank you! I am testing this on FRDM-iMX93, which has
> IW612 revision 1.0.
> 
> I have to use nxp/sd_w61x_v1.bin.se on this board and NULL firmware_sdiouart
> because it seems that firmware return 1 as "strap" value, even if WiFi
> is definitely connected over SDIO.

Wi-Fi is always connected over SDIO (for IW61x), the strapping is
related to the interface used for BT. In the past it was common to have
options for having BT over SDIO or UART or USB, but for IW61x it seems
that UART is the only available option.

Francesco