i2c: davinci: add I2C_FUNC_PROTOCOL_MANGLING to feature list

[PATCH] i2c: davinci: add I2C_FUNC_PROTOCOL_MANGLING to feature list

Posted by Marcus Folkesson 8 months, 3 weeks ago

The driver do support I2C_M_IGNORE_NAK, so add
I2C_FUNC_PROTOCOL_MANGLING to the feature list.

Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
The driver do support I2C_M_IGNORE_NAK, so the
I2C_FUNC_PROTOCOL_MANGLING bit should be set.

I2C_M_IGNORE_NAK is the only supported "mangling-feature" though, but
other i2c bus drivers also seems to support only a subset of available
mangling-features, so I guess this is ok.
---
 drivers/i2c/busses/i2c-davinci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
index 6a909d339681214ed4f382b62f8cd924f4295e69..6a3d4e9e07f45ecc228943e877cde1fd9d72e8cb 100644
--- a/drivers/i2c/busses/i2c-davinci.c
+++ b/drivers/i2c/busses/i2c-davinci.c
@@ -551,7 +551,8 @@ i2c_davinci_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
 
 static u32 i2c_davinci_func(struct i2c_adapter *adap)
 {
-	return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
+	return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL |
+		I2C_FUNC_PROTOCOL_MANGLING;
 }
 
 static void terminate_read(struct davinci_i2c_dev *dev)

---
base-commit: 1e26c5e28ca5821a824e90dd359556f5e9e7b89f
change-id: 20250326-i2c-5561bf853f8d

Best regards,
-- 
Marcus Folkesson <marcus.folkesson@gmail.com>

Re: [PATCH] i2c: davinci: add I2C_FUNC_PROTOCOL_MANGLING to feature list

Posted by Andi Shyti 7 months, 2 weeks ago

Hi Marcus,

On Wed, Mar 26, 2025 at 03:39:47PM +0100, Marcus Folkesson wrote:
> The driver do support I2C_M_IGNORE_NAK, so add
> I2C_FUNC_PROTOCOL_MANGLING to the feature list.
> 
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>

merged to i2c/i2c-host.

Thanks,
Andi

Re: [PATCH] i2c: davinci: add I2C_FUNC_PROTOCOL_MANGLING to feature list

Posted by Marcus Folkesson 7 months, 2 weeks ago

Hello,

On Wed, Mar 26, 2025 at 03:39:47PM +0100, Marcus Folkesson wrote:
> The driver do support I2C_M_IGNORE_NAK, so add
> I2C_FUNC_PROTOCOL_MANGLING to the feature list.
> 
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---

Is this patch picked up by any tree?
No confirmation nor showing up in -next makes me wonder.

Thanks,
Marcus Folkesson

Re: [PATCH] i2c: davinci: add I2C_FUNC_PROTOCOL_MANGLING to feature list

Posted by Mukesh Kumar Savaliya 8 months, 3 weeks ago

Looks good to me.

On 3/26/2025 8:09 PM, Marcus Folkesson wrote:
> The driver do support I2C_M_IGNORE_NAK, so add
> I2C_FUNC_PROTOCOL_MANGLING to the feature list.
> 
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Acked-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
> ---
> The driver do support I2C_M_IGNORE_NAK, so the
> I2C_FUNC_PROTOCOL_MANGLING bit should be set.
> 
> I2C_M_IGNORE_NAK is the only supported "mangling-feature" though, but
> other i2c bus drivers also seems to support only a subset of available
> mangling-features, so I guess this is ok.
> ---
>   drivers/i2c/busses/i2c-davinci.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-davinci.c b/drivers/i2c/busses/i2c-davinci.c
> index 6a909d339681214ed4f382b62f8cd924f4295e69..6a3d4e9e07f45ecc228943e877cde1fd9d72e8cb 100644
> --- a/drivers/i2c/busses/i2c-davinci.c
> +++ b/drivers/i2c/busses/i2c-davinci.c
> @@ -551,7 +551,8 @@ i2c_davinci_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[], int num)
>   
>   static u32 i2c_davinci_func(struct i2c_adapter *adap)
>   {
> -	return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
> +	return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL |
> +		I2C_FUNC_PROTOCOL_MANGLING;
>   }
>   
>   static void terminate_read(struct davinci_i2c_dev *dev)
> 
> ---
> base-commit: 1e26c5e28ca5821a824e90dd359556f5e9e7b89f
> change-id: 20250326-i2c-5561bf853f8d
> 
> Best regards,