[PATCH] tee: shm: fix slab page refcounting

Marco Felsch posted 1 patch 10 months, 2 weeks ago
There is a newer version of this series
drivers/tee/tee_shm.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
[PATCH] tee: shm: fix slab page refcounting
Posted by Marco Felsch 10 months, 2 weeks ago
Skip manipulating the refcount in case of slab pages according commit
b9c0e49abfca ("mm: decline to manipulate the refcount on a slab page").

Fixes: b9c0e49abfca ("mm: decline to manipulate the refcount on a slab page")
Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
---
 drivers/tee/tee_shm.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/drivers/tee/tee_shm.c b/drivers/tee/tee_shm.c
index daf6e5cfd59a..3d6a3077b6f2 100644
--- a/drivers/tee/tee_shm.c
+++ b/drivers/tee/tee_shm.c
@@ -19,16 +19,24 @@ static void shm_put_kernel_pages(struct page **pages, size_t page_count)
 {
 	size_t n;
 
-	for (n = 0; n < page_count; n++)
-		put_page(pages[n]);
+	for (n = 0; n < page_count; n++) {
+		struct page *page = pages[n];
+
+		if (!PageSlab(page))
+			put_page(pages[n]);
+	}
 }
 
 static void shm_get_kernel_pages(struct page **pages, size_t page_count)
 {
 	size_t n;
 
-	for (n = 0; n < page_count; n++)
-		get_page(pages[n]);
+	for (n = 0; n < page_count; n++) {
+		struct page *page = pages[n];
+
+		if (!PageSlab(page))
+			get_page(pages[n]);
+	}
 }
 
 static void release_registered_pages(struct tee_shm *shm)
-- 
2.39.5
Re: [PATCH] tee: shm: fix slab page refcounting
Posted by Marco Felsch 10 months, 2 weeks ago
On 25-03-25, Marco Felsch wrote:
> Skip manipulating the refcount in case of slab pages according commit
> b9c0e49abfca ("mm: decline to manipulate the refcount on a slab page").
> 
> Fixes: b9c0e49abfca ("mm: decline to manipulate the refcount on a slab page")
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
>  drivers/tee/tee_shm.c | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/tee/tee_shm.c b/drivers/tee/tee_shm.c
> index daf6e5cfd59a..3d6a3077b6f2 100644
> --- a/drivers/tee/tee_shm.c
> +++ b/drivers/tee/tee_shm.c
> @@ -19,16 +19,24 @@ static void shm_put_kernel_pages(struct page **pages, size_t page_count)
>  {
>  	size_t n;
>  
> -	for (n = 0; n < page_count; n++)
> -		put_page(pages[n]);
> +	for (n = 0; n < page_count; n++) {
> +		struct page *page = pages[n];
> +
> +		if (!PageSlab(page))
> +			put_page(pages[n]);
				  ^
I forgot to change this to page, therefore please ignore this patch.

Regards,
  Marco


> +	}
>  }
>  
>  static void shm_get_kernel_pages(struct page **pages, size_t page_count)
>  {
>  	size_t n;
>  
> -	for (n = 0; n < page_count; n++)
> -		get_page(pages[n]);
> +	for (n = 0; n < page_count; n++) {
> +		struct page *page = pages[n];
> +
> +		if (!PageSlab(page))
> +			get_page(pages[n]);
> +	}
>  }
>  
>  static void release_registered_pages(struct tee_shm *shm)
> -- 
> 2.39.5
> 
> 
>