[PATCH 3/5] arm: dts: Adjust the 'reg' range for imx287 L2 switch description

Lukasz Majewski posted 5 patches 8 months, 4 weeks ago
There is a newer version of this series
[PATCH 3/5] arm: dts: Adjust the 'reg' range for imx287 L2 switch description
Posted by Lukasz Majewski 8 months, 4 weeks ago
The current range of 'reg' property is too small to allow full control
of the L2 switch on imx287.

As this IP block also uses ENET-MAC blocks for its operation, the address
range for it must be included as well.

Signed-off-by: Lukasz Majewski <lukma@denx.de>
---
 arch/arm/boot/dts/nxp/mxs/imx28.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/mxs/imx28.dtsi b/arch/arm/boot/dts/nxp/mxs/imx28.dtsi
index bbea8b77386f..8f2aa32208cf 100644
--- a/arch/arm/boot/dts/nxp/mxs/imx28.dtsi
+++ b/arch/arm/boot/dts/nxp/mxs/imx28.dtsi
@@ -1321,8 +1321,8 @@ mac1: ethernet@800f4000 {
 			status = "disabled";
 		};
 
-		eth_switch: switch@800f8000 {
-			reg = <0x800f8000 0x8000>;
+		eth_switch: switch@800f0000 {
+			reg = <0x800f0000 0x20000>;
 			status = "disabled";
 		};
 	};
-- 
2.39.5
Re: [PATCH 3/5] arm: dts: Adjust the 'reg' range for imx287 L2 switch description
Posted by Krzysztof Kozlowski 8 months, 4 weeks ago
On 25/03/2025 12:57, Lukasz Majewski wrote:
> The current range of 'reg' property is too small to allow full control
> of the L2 switch on imx287.
> 
> As this IP block also uses ENET-MAC blocks for its operation, the address
> range for it must be included as well.
> 

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

Missing nxp or mxs.

Best regards,
Krzysztof
Re: [PATCH 3/5] arm: dts: Adjust the 'reg' range for imx287 L2 switch description
Posted by Lukasz Majewski 8 months, 4 weeks ago
Hi Krzysztof,

> On 25/03/2025 12:57, Lukasz Majewski wrote:
> > The current range of 'reg' property is too small to allow full
> > control of the L2 switch on imx287.
> > 
> > As this IP block also uses ENET-MAC blocks for its operation, the
> > address range for it must be included as well.
> >   
> 
> Please use subject prefixes matching the subsystem. You can get them
> for example with `git log --oneline -- DIRECTORY_OR_FILE` on the
> directory your patch is touching. For bindings, the preferred
> subjects are explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
> 
> Missing nxp or mxs.

Ok. I will add it.

> 
> Best regards,
> Krzysztof




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de