ALSA: hda: tas2781-i2c: Remove unnecessary NULL check before release_firmware()

[PATCH] ALSA: hda: tas2781-i2c: Remove unnecessary NULL check before release_firmware()

Chen Ni posted 1 patch 8 months, 4 weeks ago

Download mbox

sound/pci/hda/tas2781_hda_i2c.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Expand all Fold all

[PATCH] ALSA: hda: tas2781-i2c: Remove unnecessary NULL check before release_firmware()

Posted by Chen Ni 8 months, 4 weeks ago

release_firmware() checks for NULL pointers internally.
Remove unneeded NULL check for fmw here.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 sound/pci/hda/tas2781_hda_i2c.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sound/pci/hda/tas2781_hda_i2c.c b/sound/pci/hda/tas2781_hda_i2c.c
index 50c5e5f26589..9ed49b0dbe6b 100644
--- a/sound/pci/hda/tas2781_hda_i2c.c
+++ b/sound/pci/hda/tas2781_hda_i2c.c
@@ -753,8 +753,7 @@ static void tasdev_fw_ready(const struct firmware *fmw, void *context)
 
 out:
 	mutex_unlock(&tas_hda->priv->codec_lock);
-	if (fmw)
-		release_firmware(fmw);
+	release_firmware(fmw);
 	pm_runtime_mark_last_busy(tas_hda->dev);
 	pm_runtime_put_autosuspend(tas_hda->dev);
 }
-- 
2.25.1

Re: [PATCH] ALSA: hda: tas2781-i2c: Remove unnecessary NULL check before release_firmware()

Posted by Takashi Iwai 8 months, 4 weeks ago

On Tue, 25 Mar 2025 09:49:39 +0100,
Chen Ni wrote:
> 
> release_firmware() checks for NULL pointers internally.
> Remove unneeded NULL check for fmw here.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Thanks, applied now.


Takashi