net/mlx5: DR, remove redundant object_range assignment

[PATCH] net/mlx5: DR, remove redundant object_range assignment

Posted by Qasim Ijaz 8 months, 3 weeks ago

The initial assignment of object_range from
pool->dmn->info.caps.log_header_modify_argument_granularity is
redundant because it is immediately overwritten by the max_t() call. 

Remove the unnecessary assignment.

Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
index 01ed6442095d..c2218dc556c7 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
@@ -39,9 +39,6 @@ static int dr_arg_pool_alloc_objs(struct dr_arg_pool *pool)
 
 	INIT_LIST_HEAD(&cur_list);
 
-	object_range =
-		pool->dmn->info.caps.log_header_modify_argument_granularity;
-
 	object_range =
 		max_t(u32, pool->dmn->info.caps.log_header_modify_argument_granularity,
 		      DR_ICM_MODIFY_HDR_GRANULARITY_4K);
-- 
2.39.5

Re: [PATCH] net/mlx5: DR, remove redundant object_range assignment

Posted by Tariq Toukan 8 months, 3 weeks ago


On 24/03/2025 21:41, Qasim Ijaz wrote:
> The initial assignment of object_range from
> pool->dmn->info.caps.log_header_modify_argument_granularity is
> redundant because it is immediately overwritten by the max_t() call.
> 
> Remove the unnecessary assignment.
> 
> Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
> index 01ed6442095d..c2218dc556c7 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
> @@ -39,9 +39,6 @@ static int dr_arg_pool_alloc_objs(struct dr_arg_pool *pool)
>   
>   	INIT_LIST_HEAD(&cur_list);
>   
> -	object_range =
> -		pool->dmn->info.caps.log_header_modify_argument_granularity;
> -
>   	object_range =
>   		max_t(u32, pool->dmn->info.caps.log_header_modify_argument_granularity,
>   		      DR_ICM_MODIFY_HDR_GRANULARITY_4K);

Acked-by: Tariq Toukan <tariqt@nvidia.com>

Thanks for your patch.
This is net-next material. Please specify target branch in future 
submissions.

Regards,
Tariq

Re: [PATCH] net/mlx5: DR, remove redundant object_range assignment

Posted by Yevgeny Kliteynik 8 months, 3 weeks ago

On 24-Mar-25 21:41, Qasim Ijaz wrote:
> The initial assignment of object_range from
> pool->dmn->info.caps.log_header_modify_argument_granularity is
> redundant because it is immediately overwritten by the max_t() call.
> 
> Remove the unnecessary assignment.
> 
> Signed-off-by: Qasim Ijaz <qasdev00@gmail.com>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c | 3 ---
>   1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
> index 01ed6442095d..c2218dc556c7 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/sws/dr_arg.c
> @@ -39,9 +39,6 @@ static int dr_arg_pool_alloc_objs(struct dr_arg_pool *pool)
>   
>   	INIT_LIST_HEAD(&cur_list);
>   
> -	object_range =
> -		pool->dmn->info.caps.log_header_modify_argument_granularity;
> -
>   	object_range =
>   		max_t(u32, pool->dmn->info.caps.log_header_modify_argument_granularity,
>   		      DR_ICM_MODIFY_HDR_GRANULARITY_4K);

Reviewed-by: Yevgeny Kliteynik <kliteyn@nvidia.com>