KVM: x86: Sort CPUID_8000_0021_EAX leaf bits properly

[PATCH] KVM: x86: Sort CPUID_8000_0021_EAX leaf bits properly

Posted by Borislav Petkov 8 months, 4 weeks ago

From: "Borislav Petkov (AMD)" <bp@alien8.de>

WRMSR_XX_BASE_NS is bit 1 so put it there, add some new bits as
comments only.

Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
---
 arch/x86/kvm/cpuid.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
index 121edf1f2a79..e98ab18f784b 100644
--- a/arch/x86/kvm/cpuid.c
+++ b/arch/x86/kvm/cpuid.c
@@ -1160,6 +1160,7 @@ void kvm_set_cpu_caps(void)
 
 	kvm_cpu_cap_init(CPUID_8000_0021_EAX,
 		F(NO_NESTED_DATA_BP),
+		F(WRMSR_XX_BASE_NS),
 		/*
 		 * Synthesize "LFENCE is serializing" into the AMD-defined entry
 		 * in KVM's supported CPUID, i.e. if the feature is reported as
@@ -1173,10 +1174,14 @@ void kvm_set_cpu_caps(void)
 		SYNTHESIZED_F(LFENCE_RDTSC),
 		/* SmmPgCfgLock */
 		F(NULL_SEL_CLR_BASE),
+		/* UpperAddressIgnore */
 		F(AUTOIBRS),
 		EMULATED_F(NO_SMM_CTL_MSR),
+		/* FSRS */
+		/* FSRC */
 		/* PrefetchCtlMsr */
-		F(WRMSR_XX_BASE_NS),
+		/* GpOnUserCpuid */
+		/* EPSF */
 		SYNTHESIZED_F(SBPB),
 		SYNTHESIZED_F(IBPB_BRTYPE),
 		SYNTHESIZED_F(SRSO_NO),
-- 
2.43.0

Re: [PATCH] KVM: x86: Sort CPUID_8000_0021_EAX leaf bits properly

Posted by Sean Christopherson 7 months, 3 weeks ago

On Mon, 24 Mar 2025 17:06:17 +0100, Borislav Petkov wrote:
> WRMSR_XX_BASE_NS is bit 1 so put it there, add some new bits as
> comments only.

Applied to kvm-x86 misc, thanks!

[1/1] KVM: x86: Sort CPUID_8000_0021_EAX leaf bits properly
      commit: 49c140d5af127ef4faf19f06a89a0714edf0316f

--
https://github.com/kvm-x86/linux/tree/next

Re: [PATCH] KVM: x86: Sort CPUID_8000_0021_EAX leaf bits properly

Posted by Sean Christopherson 8 months, 1 week ago

On Mon, Mar 24, 2025, Borislav Petkov wrote:
> From: "Borislav Petkov (AMD)" <bp@alien8.de>
> 
> WRMSR_XX_BASE_NS is bit 1 so put it there, add some new bits as
> comments only.
> 
> Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
> ---
>  arch/x86/kvm/cpuid.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
> index 121edf1f2a79..e98ab18f784b 100644
> --- a/arch/x86/kvm/cpuid.c
> +++ b/arch/x86/kvm/cpuid.c
> @@ -1160,6 +1160,7 @@ void kvm_set_cpu_caps(void)
>  
>  	kvm_cpu_cap_init(CPUID_8000_0021_EAX,
>  		F(NO_NESTED_DATA_BP),
> +		F(WRMSR_XX_BASE_NS),
>  		/*
>  		 * Synthesize "LFENCE is serializing" into the AMD-defined entry
>  		 * in KVM's supported CPUID, i.e. if the feature is reported as
> @@ -1173,10 +1174,14 @@ void kvm_set_cpu_caps(void)
>  		SYNTHESIZED_F(LFENCE_RDTSC),
>  		/* SmmPgCfgLock */
>  		F(NULL_SEL_CLR_BASE),
> +		/* UpperAddressIgnore */
>  		F(AUTOIBRS),
>  		EMULATED_F(NO_SMM_CTL_MSR),
> +		/* FSRS */
> +		/* FSRC */

I'm going to skip these, as they aren't yet publicly documented, and there are
patches proposed to add actual support.  I wouldn't care all that much if these
didn't collide with Intel's version (the proposed patches name them AMD_FSxx).

https://lore.kernel.org/all/20241204134345.189041-2-davydov-max@yandex-team.ru

>  		/* PrefetchCtlMsr */
> -		F(WRMSR_XX_BASE_NS),
> +		/* GpOnUserCpuid */
> +		/* EPSF */

FWIW, this one's also not in the APM (though the only APM I can find is a year old),
though it's in tools/x86/kcpuid.

>  		SYNTHESIZED_F(SBPB),
>  		SYNTHESIZED_F(IBPB_BRTYPE),
>  		SYNTHESIZED_F(SRSO_NO),
> -- 
> 2.43.0
>

Re: [PATCH] KVM: x86: Sort CPUID_8000_0021_EAX leaf bits properly

Posted by Borislav Petkov 8 months, 1 week ago

On Thu, Apr 10, 2025 at 02:46:39PM -0700, Sean Christopherson wrote:
> I'm going to skip these, as they aren't yet publicly documented,

https://www.amd.com/content/dam/amd/en/documents/epyc-technical-docs/programmer-references/57238.zip

> and there are patches proposed to add actual support.  I wouldn't care all
> that much if these didn't collide with Intel's version (the proposed patches
> name them AMD_FSxx).
>
> https://lore.kernel.org/all/20241204134345.189041-2-davydov-max@yandex-team.ru

Pff, I think the right thing to do is to detect those and when set, set the
Intel flags because they're basically the same.

Lemme go reply there.

... goes and replies...

> 
> >  		/* PrefetchCtlMsr */
> > -		F(WRMSR_XX_BASE_NS),
> > +		/* GpOnUserCpuid */
> > +		/* EPSF */
> 
> FWIW, this one's also not in the APM (though the only APM I can find is a year old),
> though it's in tools/x86/kcpuid.

See above. Yeah, the PPRs have them earlier than the APM.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette