dt-bindings: pps: gpio: Correct indentation and style in DTS example

[PATCH] dt-bindings: pps: gpio: Correct indentation and style in DTS example

Posted by Krzysztof Kozlowski 8 months, 3 weeks ago

DTS example in the bindings should be indented with 2- or 4-spaces and
aligned with opening '- |', so correct any differences like 3-spaces or
mixtures 2- and 4-spaces in one binding.

No functional changes here, but saves some comments during reviews of
new patches built on existing code.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/pps/pps-gpio.yaml     | 20 +++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/pps/pps-gpio.yaml b/Documentation/devicetree/bindings/pps/pps-gpio.yaml
index fd4adfa8d2d4..383a838744eb 100644
--- a/Documentation/devicetree/bindings/pps/pps-gpio.yaml
+++ b/Documentation/devicetree/bindings/pps/pps-gpio.yaml
@@ -36,14 +36,14 @@ additionalProperties: false
 
 examples:
   - |
-      #include <dt-bindings/gpio/gpio.h>
+    #include <dt-bindings/gpio/gpio.h>
 
-      pps {
-          compatible = "pps-gpio";
-          pinctrl-names = "default";
-          pinctrl-0 = <&pinctrl_pps>;
-          gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
-          assert-falling-edge;
-          echo-gpios = <&gpio1 27 GPIO_ACTIVE_HIGH>;
-          echo-active-ms = <100>;
-      };
+    pps {
+        compatible = "pps-gpio";
+        pinctrl-names = "default";
+        pinctrl-0 = <&pinctrl_pps>;
+        gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
+        assert-falling-edge;
+        echo-gpios = <&gpio1 27 GPIO_ACTIVE_HIGH>;
+        echo-active-ms = <100>;
+    };
-- 
2.43.0

Re: [PATCH] dt-bindings: pps: gpio: Correct indentation and style in DTS example

Posted by Rob Herring (Arm) 8 months, 3 weeks ago

On Mon, 24 Mar 2025 13:51:22 +0100, Krzysztof Kozlowski wrote:
> DTS example in the bindings should be indented with 2- or 4-spaces and
> aligned with opening '- |', so correct any differences like 3-spaces or
> mixtures 2- and 4-spaces in one binding.
> 
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/pps/pps-gpio.yaml     | 20 +++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 

Applied, thanks!

Re: [PATCH] dt-bindings: pps: gpio: Correct indentation and style in DTS example

Posted by Rodolfo Giometti 8 months, 3 weeks ago

On 24/03/25 13:51, Krzysztof Kozlowski wrote:
> DTS example in the bindings should be indented with 2- or 4-spaces and
> aligned with opening '- |', so correct any differences like 3-spaces or
> mixtures 2- and 4-spaces in one binding.
> 
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Rodolfo Giometti <giometti@enneenne.com>

> ---
>   .../devicetree/bindings/pps/pps-gpio.yaml     | 20 +++++++++----------
>   1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pps/pps-gpio.yaml b/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> index fd4adfa8d2d4..383a838744eb 100644
> --- a/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> +++ b/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> @@ -36,14 +36,14 @@ additionalProperties: false
>   
>   examples:
>     - |
> -      #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/gpio/gpio.h>
>   
> -      pps {
> -          compatible = "pps-gpio";
> -          pinctrl-names = "default";
> -          pinctrl-0 = <&pinctrl_pps>;
> -          gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
> -          assert-falling-edge;
> -          echo-gpios = <&gpio1 27 GPIO_ACTIVE_HIGH>;
> -          echo-active-ms = <100>;
> -      };
> +    pps {
> +        compatible = "pps-gpio";
> +        pinctrl-names = "default";
> +        pinctrl-0 = <&pinctrl_pps>;
> +        gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
> +        assert-falling-edge;
> +        echo-gpios = <&gpio1 27 GPIO_ACTIVE_HIGH>;
> +        echo-active-ms = <100>;
> +    };

-- 
GNU/Linux Solutions                  e-mail: giometti@enneenne.com
Linux Device Driver                          giometti@linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming