perf: annotate asm_pure_loop.S

[PATCH] perf: annotate asm_pure_loop.S

Posted by Marcus Meissner 10 months, 3 weeks ago

Annotate so it is built with non-executable stack.

Fixes: 8b97519711c3a0f9eb8274a227dff3fe4f0f72a2
Signed-off-by: Marcus Meissner <meissner@suse.de>
---
 tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S b/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S
index 75cf084a927d..577760046772 100644
--- a/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S
+++ b/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S
@@ -26,3 +26,5 @@ skip:
 	mov	x0, #0
 	mov	x8, #93 // __NR_exit syscall
 	svc	#0
+
+.section .note.GNU-stack, "", @progbits
-- 
2.43.0

Re: [PATCH] perf: annotate asm_pure_loop.S

Posted by Namhyung Kim 10 months, 2 weeks ago

On Sun, 23 Mar 2025 09:53:45 +0100, Marcus Meissner wrote:
> Annotate so it is built with non-executable stack.
> 
> 
Applied to perf-tools-next, thanks!

Best regards,
Namhyung

Re: [PATCH] perf: annotate asm_pure_loop.S

Posted by Leo Yan 10 months, 3 weeks ago

On Sun, Mar 23, 2025 at 09:53:45AM +0100, Marcus Meissner wrote:
> Annotate so it is built with non-executable stack.
> 
> Fixes: 8b97519711c3a0f9eb8274a227dff3fe4f0f72a2

Fixes: 8b97519711c3 ("perf test: Add asm pureloop test tool")

> Signed-off-by: Marcus Meissner <meissner@suse.de>
> ---
>  tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S b/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S
> index 75cf084a927d..577760046772 100644
> --- a/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S
> +++ b/tools/perf/tests/shell/coresight/asm_pure_loop/asm_pure_loop.S
> @@ -26,3 +26,5 @@ skip:
>  	mov	x0, #0
>  	mov	x8, #93 // __NR_exit syscall
>  	svc	#0
> +
> +.section .note.GNU-stack, "", @progbits

With the fix tag change:

Reviewed-by: Leo Yan <leo.yan@arm.com>

I found actually Jan Stancek has submitted a similiar patch [1]
~2 years ago but we missed, sorry for that.

[1] https://lore.kernel.org/linux-perf-users/e79288922fbd0bad6facf06488735ec74f811d1b.1689588798.git.jstancek@redhat.com/