serial: 8250_ni: Clean up the driver

[PATCH v1 0/7] serial: 8250_ni: Clean up the driver

Posted by Andy Shevchenko 7 months ago

The newly introduced driver inherited almost all same issues
that 8250_platform had and others. Clean up the driver accordingly.

Andy Shevchenko (7):
  serial: 8250_ni: Switch to use uart_read_port_properties()
  serial: 8250_ni: Remove duplicate mapping
  serial: 8250_ni: Switch to use platform_get_mem_or_io()
  serial: 8250_ni: Remove unneeded conditionals
  serial: 8250_ni: use serial_port_in()/serial_port_out() helpers
  serial: 8250_ni: Switch to use dev_err_probe()
  serial: 8250_ni: Tidy up ACPI ID table

 drivers/tty/serial/8250/8250_ni.c | 89 +++++++++++++------------------
 drivers/tty/serial/8250/Kconfig   |  2 +-
 2 files changed, 38 insertions(+), 53 deletions(-)

-- 
2.47.2

Re: [PATCH v1 0/7] serial: 8250_ni: Clean up the driver

Posted by Chaitanya Vadrevu 6 months, 3 weeks ago

> The newly introduced driver inherited almost all same issues
> that 8250_platform had and others. Clean up the driver accordingly.
> 
> Andy Shevchenko (7):
>   serial: 8250_ni: Switch to use uart_read_port_properties()
>   serial: 8250_ni: Remove duplicate mapping
>   serial: 8250_ni: Switch to use platform_get_mem_or_io()
>   serial: 8250_ni: Remove unneeded conditionals
>   serial: 8250_ni: use serial_port_in()/serial_port_out() helpers
>   serial: 8250_ni: Switch to use dev_err_probe()
>   serial: 8250_ni: Tidy up ACPI ID table
> 
>  drivers/tty/serial/8250/8250_ni.c | 89 +++++++++++++------------------
>  drivers/tty/serial/8250/Kconfig   |  2 +-
>  2 files changed, 38 insertions(+), 53 deletions(-)

Thanks for the patches! They look good and tested fine.

For the series,

Tested-by: Chaitanya Vadrevu <chaitanya.vadrevu@emerson.com>
Reviewed-by: Chaitanya Vadrevu <chaitanya.vadrevu@emerson.com>

Thanks,
Chaitanya