From: Arnd Bergmann <arnd@arndb.de>

A invalid prototype made it into a previous patch, causing an clang warning:

drivers/platform/cznic/turris-signing-key.c:25:55: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]

and a slightly different warning with gcc-11 and earlier but not gcc-12 and up:

drivers/platform/cznic/turris-signing-key.c: In function 'turris_signing_key_instantiate':
drivers/platform/cznic/turris-signing-key.c:25:43: error: parameter name omitted

Add the parameters to get a clean build with all compilers.

Fixes: 0b28b7080ef5 ("platform: cznic: Add keyctl helpers for Turris platform")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202503210450.AoOpbJXC-lkp@intel.com/
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/platform/cznic/turris-signing-key.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/platform/cznic/turris-signing-key.c b/drivers/platform/cznic/turris-signing-key.c
index 3b12e5245fb7..3827178565e2 100644
--- a/drivers/platform/cznic/turris-signing-key.c
+++ b/drivers/platform/cznic/turris-signing-key.c
@@ -22,7 +22,8 @@
 
 #include <linux/turris-signing-key.h>
 
-static int turris_signing_key_instantiate(struct key *, struct key_preparsed_payload *)
+static int turris_signing_key_instantiate(struct key *key,
+					  struct key_preparsed_payload *payload)
 {
 	return 0;
 }
-- 
2.39.5

On Fri, Mar 21, 2025 at 09:53:07AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> A invalid prototype made it into a previous patch, causing an clang warning:
> 
> drivers/platform/cznic/turris-signing-key.c:25:55: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]
> 
> and a slightly different warning with gcc-11 and earlier but not gcc-12 and up:
> 
> drivers/platform/cznic/turris-signing-key.c: In function 'turris_signing_key_instantiate':
> drivers/platform/cznic/turris-signing-key.c:25:43: error: parameter name omitted
> 
> Add the parameters to get a clean build with all compilers.
> 
> Fixes: 0b28b7080ef5 ("platform: cznic: Add keyctl helpers for Turris platform")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202503210450.AoOpbJXC-lkp@intel.com/
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

You will be taking this I assume?

> ---
>  drivers/platform/cznic/turris-signing-key.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/cznic/turris-signing-key.c b/drivers/platform/cznic/turris-signing-key.c
> index 3b12e5245fb7..3827178565e2 100644
> --- a/drivers/platform/cznic/turris-signing-key.c
> +++ b/drivers/platform/cznic/turris-signing-key.c
> @@ -22,7 +22,8 @@
>  
>  #include <linux/turris-signing-key.h>
>  
> -static int turris_signing_key_instantiate(struct key *, struct key_preparsed_payload *)
> +static int turris_signing_key_instantiate(struct key *key,
> +					  struct key_preparsed_payload *payload)
>  {
>  	return 0;
>  }
> -- 
> 2.39.5
>

> 
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> 
> You will be taking this I assume?

Arnd already took it into for-next:
  https://web.git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=for-next

On Wed, Mar 26, 2025 at 10:38:47AM +0100, Marek Behún wrote:
> > 
> > Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> > 
> > You will be taking this I assume?
> 
> Arnd already took it into for-next:
>   https://web.git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=for-next

Ah odd, it just showed up in -next even though it was applied a few days
ago:

$ git log --oneline next-20250325 -- drivers/platform/cznic/turris-signing-key.c
0b28b7080ef5 platform: cznic: Add keyctl helpers for Turris platform

$ git log --oneline next-20250326 -- drivers/platform/cznic/turris-signing-key.c
eece12237a13 platform: cznic: fix function parameter names
0b28b7080ef5 platform: cznic: Add keyctl helpers for Turris platform

Glad that it is resolved now though.

Cheers,
Nathan

On Wed, Mar 26, 2025, at 17:23, Nathan Chancellor wrote:
> On Wed, Mar 26, 2025 at 10:38:47AM +0100, Marek Behún wrote:
>> > 
>> > Reviewed-by: Nathan Chancellor <nathan@kernel.org>
>> > 
>> > You will be taking this I assume?
>> 
>> Arnd already took it into for-next:
>>   https://web.git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=for-next
>
> Ah odd, it just showed up in -next even though it was applied a few days
> ago:

Sorry about that, my previous git push had failed because of some other
problem. I also still see two more build issues in the cznic driver,
so I'm sending the pull 6.16 pull request without that one but still
plan to send a follow-up that includes this one and two more changes
once it builds cleanly.

       Arnd