HID: quirks: Add quirk for another Chicony Electronics HP 5MP Camera

[PATCH] HID: quirks: Add quirk for another Chicony Electronics HP 5MP Camera

Posted by Chia-Lin Kao (AceLan) 9 months ago

The Chicony Electronics HP 5MP Camera (USB ID 04F2:B824) reports a HID
sensor interface that is not actually implemented. Attempting to access
this non-functional sensor via iio_info causes system hangs as runtime PM
tries to wake up an unresponsive sensor.

Add this device to the HID ignore list since the sensor interface is
non-functional by design and should not be exposed to userspace.

Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com>
---
 drivers/hid/hid-ids.h    | 1 +
 drivers/hid/hid-quirks.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 5fdea9116a3e..554dbed3f3ed 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -298,6 +298,7 @@
 #define USB_DEVICE_ID_CHICONY_TOSHIBA_WT10A	0x1408
 #define USB_DEVICE_ID_CHICONY_ACER_SWITCH12	0x1421
 #define USB_DEVICE_ID_CHICONY_HP_5MB_CAMERA	0xb82c
+#define USB_DEVICE_ID_CHICONY_HP_5MB_CAMERA2	0xb824
 
 #define USB_VENDOR_ID_CHUNGHWAT		0x2247
 #define USB_DEVICE_ID_CHUNGHWAT_MULTITOUCH	0x0001
diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c
index 452fac15550b..91b3d121bb1f 100644
--- a/drivers/hid/hid-quirks.c
+++ b/drivers/hid/hid-quirks.c
@@ -371,6 +371,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_ASUS_AK1D) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_ACER_SWITCH12) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_HP_5MB_CAMERA) },
+	{ HID_USB_DEVICE(USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_HP_5MB_CAMERA2) },
 #endif
 #if IS_ENABLED(CONFIG_HID_CMEDIA)
 	{ HID_USB_DEVICE(USB_VENDOR_ID_CMEDIA, USB_DEVICE_ID_CM6533) },
-- 
2.43.0

Re: [PATCH] HID: quirks: Add quirk for another Chicony Electronics HP 5MP Camera

Posted by Chia-Lin Kao (AceLan) 9 months ago

On Fri, Mar 21, 2025 at 10:25:40AM +0800, Chia-Lin Kao (AceLan) wrote:
> The Chicony Electronics HP 5MP Camera (USB ID 04F2:B824) reports a HID
> sensor interface that is not actually implemented. Attempting to access
> this non-functional sensor via iio_info causes system hangs as runtime PM
> tries to wake up an unresponsive sensor.
> 
> Add this device to the HID ignore list since the sensor interface is
> non-functional by design and should not be exposed to userspace.
We found another Chicony device with the same issue.
Please apply this patch after the previous submitted one.
Thanks.

https://lore.kernel.org/lkml/20250312063532.551938-1-acelan.kao@canonical.com/T/
> 
> Signed-off-by: Chia-Lin Kao (AceLan) <acelan.kao@canonical.com>
> ---
>  drivers/hid/hid-ids.h    | 1 +
>  drivers/hid/hid-quirks.c | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 5fdea9116a3e..554dbed3f3ed 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -298,6 +298,7 @@
>  #define USB_DEVICE_ID_CHICONY_TOSHIBA_WT10A	0x1408
>  #define USB_DEVICE_ID_CHICONY_ACER_SWITCH12	0x1421
>  #define USB_DEVICE_ID_CHICONY_HP_5MB_CAMERA	0xb82c
> +#define USB_DEVICE_ID_CHICONY_HP_5MB_CAMERA2	0xb824
>  
>  #define USB_VENDOR_ID_CHUNGHWAT		0x2247
>  #define USB_DEVICE_ID_CHUNGHWAT_MULTITOUCH	0x0001
> diff --git a/drivers/hid/hid-quirks.c b/drivers/hid/hid-quirks.c
> index 452fac15550b..91b3d121bb1f 100644
> --- a/drivers/hid/hid-quirks.c
> +++ b/drivers/hid/hid-quirks.c
> @@ -371,6 +371,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_ASUS_AK1D) },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_ACER_SWITCH12) },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_HP_5MB_CAMERA) },
> +	{ HID_USB_DEVICE(USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_HP_5MB_CAMERA2) },
>  #endif
>  #if IS_ENABLED(CONFIG_HID_CMEDIA)
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_CMEDIA, USB_DEVICE_ID_CM6533) },
> -- 
> 2.43.0

Re: [PATCH] HID: quirks: Add quirk for another Chicony Electronics HP 5MP Camera

Posted by Jiri Kosina 7 months, 3 weeks ago

On Fri, 21 Mar 2025, Chia-Lin Kao (AceLan) wrote:

> On Fri, Mar 21, 2025 at 10:25:40AM +0800, Chia-Lin Kao (AceLan) wrote:
> > The Chicony Electronics HP 5MP Camera (USB ID 04F2:B824) reports a HID
> > sensor interface that is not actually implemented. Attempting to access
> > this non-functional sensor via iio_info causes system hangs as runtime PM
> > tries to wake up an unresponsive sensor.
> > 
> > Add this device to the HID ignore list since the sensor interface is
> > non-functional by design and should not be exposed to userspace.
> We found another Chicony device with the same issue.
> Please apply this patch after the previous submitted one.
> Thanks.
> 
> https://lore.kernel.org/lkml/20250312063532.551938-1-acelan.kao@canonical.com/T/

Similarly to previous one, why are you adding to hid_have_special_driver[] 
instead of hid_ignore_list[]?

Thanks,

-- 
Jiri Kosina
SUSE Labs