drivers/staging/gpib/eastwood/fluke_gpib.c | 2 -- 1 file changed, 2 deletions(-)
From: sunliming <sunliming@kylinos.cn>
Fix below kernel warning:
drivers/staging/gpib/eastwood/fluke_gpib.c:196:23: warning: variable 'nec_priv' set but not
used [-Wunused-but-set-variable]
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: sunliming <sunliming@kylinos.cn>
---
drivers/staging/gpib/eastwood/fluke_gpib.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/gpib/eastwood/fluke_gpib.c b/drivers/staging/gpib/eastwood/fluke_gpib.c
index 0304c5de4ccd..6854a745ccff 100644
--- a/drivers/staging/gpib/eastwood/fluke_gpib.c
+++ b/drivers/staging/gpib/eastwood/fluke_gpib.c
@@ -194,10 +194,8 @@ static int fluke_line_status(const gpib_board_t *board)
int status = ValidALL;
int bsr_bits;
struct fluke_priv *e_priv;
- struct nec7210_priv *nec_priv;
e_priv = board->private_data;
- nec_priv = &e_priv->nec7210_priv;
bsr_bits = fluke_paged_read_byte(e_priv, BUS_STATUS, BUS_STATUS_PAGE);
--
2.25.1
On Fri, Mar 21, 2025 at 09:06:49AM +0800, sunliming@linux.dev wrote: > From: sunliming <sunliming@kylinos.cn> > > Fix below kernel warning: > drivers/staging/gpib/eastwood/fluke_gpib.c:196:23: warning: variable 'nec_priv' set but not > used [-Wunused-but-set-variable] > > Reported-by: kernel test robot <lkp@intel.com> Please link to where this was reported. The report from the robot will have the needed information in it on how to do this. > Signed-off-by: sunliming <sunliming@kylinos.cn> As per our documentation, please use your name, not your email alias, on the signed-off-by line. thanks, gregk -h
On 2025/4/3 22:08, Greg KH wrote: > On Fri, Mar 21, 2025 at 09:06:49AM +0800, sunliming@linux.dev wrote: >> From: sunliming <sunliming@kylinos.cn> >> >> Fix below kernel warning: >> drivers/staging/gpib/eastwood/fluke_gpib.c:196:23: warning: variable 'nec_priv' set but not >> used [-Wunused-but-set-variable] >> >> Reported-by: kernel test robot <lkp@intel.com> > Please link to where this was reported. The report from the robot will > have the needed information in it on how to do this. Get it, I will resend the patch to fix this. Thanks. >> Signed-off-by: sunliming <sunliming@kylinos.cn> > As per our documentation, please use your name, not your email alias, on > the signed-off-by line. It's not my email alias,my name is sunliming too. Thanks. > thanks, > > gregk -h
On Fri, Apr 04, 2025 at 02:08:38PM +0800, Sunliming wrote: > > On 2025/4/3 22:08, Greg KH wrote: > > On Fri, Mar 21, 2025 at 09:06:49AM +0800, sunliming@linux.dev wrote: > > > From: sunliming <sunliming@kylinos.cn> > > > > > > Fix below kernel warning: > > > drivers/staging/gpib/eastwood/fluke_gpib.c:196:23: warning: variable 'nec_priv' set but not > > > used [-Wunused-but-set-variable] > > > > > > Reported-by: kernel test robot <lkp@intel.com> > > Please link to where this was reported. The report from the robot will > > have the needed information in it on how to do this. > > Get it, I will resend the patch to fix this. > > Thanks. > > > > Signed-off-by: sunliming <sunliming@kylinos.cn> > > As per our documentation, please use your name, not your email alias, on > > the signed-off-by line. > > It's not my email alias,my name is sunliming too. Why is it capitalized on your From header on your email but not in your Signed-off-by? regards, dan carpenter
On 2025/4/4 15:53, Dan Carpenter wrote: > On Fri, Apr 04, 2025 at 02:08:38PM +0800, Sunliming wrote: >> On 2025/4/3 22:08, Greg KH wrote: >>> On Fri, Mar 21, 2025 at 09:06:49AM +0800, sunliming@linux.dev wrote: >>>> From: sunliming <sunliming@kylinos.cn> >>>> >>>> Fix below kernel warning: >>>> drivers/staging/gpib/eastwood/fluke_gpib.c:196:23: warning: variable 'nec_priv' set but not >>>> used [-Wunused-but-set-variable] >>>> >>>> Reported-by: kernel test robot <lkp@intel.com> >>> Please link to where this was reported. The report from the robot will >>> have the needed information in it on how to do this. >> Get it, I will resend the patch to fix this. >> >> Thanks. >> >>>> Signed-off-by: sunliming <sunliming@kylinos.cn> >>> As per our documentation, please use your name, not your email alias, on >>> the signed-off-by line. >> It's not my email alias,my name is sunliming too. > Why is it capitalized on your From header on your email but not in your > Signed-off-by? I didn't notice that my email and Gitconfig have different names set. Thank you for letting me know, I will fix it. > > regards, > dan carpenter >
© 2016 - 2025 Red Hat, Inc.