[PATCH 1/2] spi: dt-bindings: st,stm32mp25-ospi: Make "resets" a required property

Patrice Chotard posted 2 patches 9 months ago
There is a newer version of this series
[PATCH 1/2] spi: dt-bindings: st,stm32mp25-ospi: Make "resets" a required property
Posted by Patrice Chotard 9 months ago
Make "resets" a required property.

Fixes: bed97e35786a ("dt-bindings: spi: Add STM32 OSPI controller")
Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
 Documentation/devicetree/bindings/spi/st,stm32mp25-ospi.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/spi/st,stm32mp25-ospi.yaml b/Documentation/devicetree/bindings/spi/st,stm32mp25-ospi.yaml
index 5f276f27dc4c1fd2056f129cafc1005eaee8008f..272bc308726b2dfdf3ec80740d70e0fd1bfc4fea 100644
--- a/Documentation/devicetree/bindings/spi/st,stm32mp25-ospi.yaml
+++ b/Documentation/devicetree/bindings/spi/st,stm32mp25-ospi.yaml
@@ -68,6 +68,7 @@ required:
   - compatible
   - reg
   - clocks
+  - resets
   - interrupts
   - st,syscfg-dlyb
 

-- 
2.25.1
Re: [PATCH 1/2] spi: dt-bindings: st,stm32mp25-ospi: Make "resets" a required property
Posted by Krzysztof Kozlowski 9 months ago
On 21/03/2025 10:44, Patrice Chotard wrote:
> Make "resets" a required property.

Please explain why. This is technically an ABI break, so you please
provide explanation what sort of issue is being fixed.

> 
> Fixes: bed97e35786a ("dt-bindings: spi: Add STM32 OSPI controller")
> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
> ---
>  Documentation/devicetree/bindings/spi/st,stm32mp25-ospi.yaml | 1 +
>  1 file changed, 1 insertion(+)


Best regards,
Krzysztof
Re: [PATCH 1/2] spi: dt-bindings: st,stm32mp25-ospi: Make "resets" a required property
Posted by Patrice CHOTARD 8 months, 4 weeks ago

On 3/21/25 11:13, Krzysztof Kozlowski wrote:
> On 21/03/2025 10:44, Patrice Chotard wrote:
>> Make "resets" a required property.
> 
> Please explain why. This is technically an ABI break, so you please
> provide explanation what sort of issue is being fixed.

Hi

Right, i will add more details

Thanks
Patrice

> 
>>
>> Fixes: bed97e35786a ("dt-bindings: spi: Add STM32 OSPI controller")
>> Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
>> ---
>>  Documentation/devicetree/bindings/spi/st,stm32mp25-ospi.yaml | 1 +
>>  1 file changed, 1 insertion(+)
> 
> 
> Best regards,
> Krzysztof