radix-tree: add missing cleanup.h

[PATCH] radix-tree: add missing cleanup.h

Posted by Daniel Gomez 10 months, 3 weeks ago

From: Daniel Gomez <da.gomez@samsung.com>

Add shared cleanup.h header for radix-tree testing tools.

Fixes build error found with kdevops [1]:

cc -I../shared -I. -I../../include -I../../../lib -g -Og -Wall
-D_LGPL_SOURCE -fsanitize=address -fsanitize=undefined   -c -o
radix-tree.o radix-tree.c
In file included from ../shared/linux/idr.h:1,
                 from radix-tree.c:18:
../shared/linux/../../../../include/linux/idr.h:18:10: fatal error:
linux/cleanup.h: No such file or directory
   18 | #include <linux/cleanup.h>
      |          ^~~~~~~~~~~~~~~~~
compilation terminated.
make: *** [<builtin>: radix-tree.o] Error 1

[1] https://github.com/linux-kdevops/kdevops
https://github.com/linux-kdevops/linux-mm-kpd/
actions/runs/13971648496/job/39114756401

Fixes: 6c8b0b835f00 ("perf/core: Simplify perf_pmu_register()")

Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
---
 tools/testing/shared/linux/cleanup.h | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/tools/testing/shared/linux/cleanup.h b/tools/testing/shared/linux/cleanup.h
new file mode 100644
index 0000000000000000000000000000000000000000..6e1691f56e300b498c16647bb4b91d8c8be9c3eb
--- /dev/null
+++ b/tools/testing/shared/linux/cleanup.h
@@ -0,0 +1,7 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef _TEST_CLEANUP_H
+#define _TEST_CLEANUP_H
+
+#include "../../../../include/linux/cleanup.h"
+
+#endif /* _TEST_CLEANUP_H */

---
base-commit: 9388ec571cb1adba59d1cded2300eeb11827679c
change-id: 20250321-fix-radix-tree-build-28e21dd4a64b

Best regards,
-- 
Daniel Gomez <da.gomez@samsung.com>

Re: [PATCH] radix-tree: add missing cleanup.h

Posted by Matthew Wilcox 10 months, 2 weeks ago

On Fri, Mar 21, 2025 at 08:24:33PM +0000, Daniel Gomez wrote:
> Fixes: 6c8b0b835f00 ("perf/core: Simplify perf_pmu_register()")

Ugh.  I'm not happy that new functionality is being added to IDR.
Peter, why aren't you using an allocating XArray?

Re: [PATCH] radix-tree: add missing cleanup.h

Posted by Sidhartha Kumar 10 months, 2 weeks ago

On 3/21/25 4:24 PM, Daniel Gomez wrote:
> From: Daniel Gomez <da.gomez@samsung.com>
> 
> Add shared cleanup.h header for radix-tree testing tools.
> 
> Fixes build error found with kdevops [1]:
> 
> cc -I../shared -I. -I../../include -I../../../lib -g -Og -Wall
> -D_LGPL_SOURCE -fsanitize=address -fsanitize=undefined   -c -o
> radix-tree.o radix-tree.c
> In file included from ../shared/linux/idr.h:1,
>                   from radix-tree.c:18:
> ../shared/linux/../../../../include/linux/idr.h:18:10: fatal error:
> linux/cleanup.h: No such file or directory
>     18 | #include <linux/cleanup.h>
>        |          ^~~~~~~~~~~~~~~~~
> compilation terminated.
> make: *** [<builtin>: radix-tree.o] Error 1
> 
> [1] https://github.com/linux-kdevops/kdevops
> https://github.com/linux-kdevops/linux-mm-kpd/
> actions/runs/13971648496/job/39114756401
> 

This link seems to be broken.

> Fixes: 6c8b0b835f00 ("perf/core: Simplify perf_pmu_register()")
> 
> Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
> ---
>   tools/testing/shared/linux/cleanup.h | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/tools/testing/shared/linux/cleanup.h b/tools/testing/shared/linux/cleanup.h
> new file mode 100644
> index 0000000000000000000000000000000000000000..6e1691f56e300b498c16647bb4b91d8c8be9c3eb
> --- /dev/null
> +++ b/tools/testing/shared/linux/cleanup.h
> @@ -0,0 +1,7 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef _TEST_CLEANUP_H
> +#define _TEST_CLEANUP_H

are these header guards needed?

> +
> +#include "../../../../include/linux/cleanup.h"
> +
> +#endif /* _TEST_CLEANUP_H */
> 
> ---
> base-commit: 9388ec571cb1adba59d1cded2300eeb11827679c
> change-id: 20250321-fix-radix-tree-build-28e21dd4a64b
> 
> Best regards,

Tested-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Reviewed-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>

Re: [PATCH] radix-tree: add missing cleanup.h

Posted by Daniel Gomez 10 months, 2 weeks ago

On Mon, Mar 31, 2025 at 02:21:50PM +0100, Sidhartha Kumar wrote:
> On 3/21/25 4:24 PM, Daniel Gomez wrote:
> > diff --git a/tools/testing/shared/linux/cleanup.h b/tools/testing/shared/linux/cleanup.h
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..6e1691f56e300b498c16647bb4b91d8c8be9c3eb
> > --- /dev/null
> > +++ b/tools/testing/shared/linux/cleanup.h
> > @@ -0,0 +1,7 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +#ifndef _TEST_CLEANUP_H
> > +#define _TEST_CLEANUP_H
> 
> are these header guards needed?

I think that is correct, it's redundant as of now. Perhaps it could be removed
when/if merged?

Re: [PATCH] radix-tree: add missing cleanup.h

Posted by Liam R. Howlett 10 months, 2 weeks ago

+Cc Luis, as he added this task to the kdevops build.

Is this going through fsdevel or linux-mm?  It's not entirely clear to
me.  I assume fsdevel as akpm isn't in the email header?

* Daniel Gomez <da.gomez@kernel.org> [250321 16:25]:
> From: Daniel Gomez <da.gomez@samsung.com>
> 
> Add shared cleanup.h header for radix-tree testing tools.
> 
> Fixes build error found with kdevops [1]:
> 
> cc -I../shared -I. -I../../include -I../../../lib -g -Og -Wall
> -D_LGPL_SOURCE -fsanitize=address -fsanitize=undefined   -c -o
> radix-tree.o radix-tree.c
> In file included from ../shared/linux/idr.h:1,
>                  from radix-tree.c:18:
> ../shared/linux/../../../../include/linux/idr.h:18:10: fatal error:
> linux/cleanup.h: No such file or directory
>    18 | #include <linux/cleanup.h>
>       |          ^~~~~~~~~~~~~~~~~
> compilation terminated.
> make: *** [<builtin>: radix-tree.o] Error 1
> 
> [1] https://github.com/linux-kdevops/kdevops
> https://github.com/linux-kdevops/linux-mm-kpd/
> actions/runs/13971648496/job/39114756401

I am quite pleased that you saw and fixed the issue with the kdevops
running the testing!  Thanks!

The URL seems to have expired, so thanks for including the failure.

Can you please not break the link across lines so they work with a
mouse click?  I believe this is an acceptable time to run over 80
characters.

> 
> Fixes: 6c8b0b835f00 ("perf/core: Simplify perf_pmu_register()")
> 
> Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
> ---
>  tools/testing/shared/linux/cleanup.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/tools/testing/shared/linux/cleanup.h b/tools/testing/shared/linux/cleanup.h
> new file mode 100644
> index 0000000000000000000000000000000000000000..6e1691f56e300b498c16647bb4b91d8c8be9c3eb
> --- /dev/null
> +++ b/tools/testing/shared/linux/cleanup.h
> @@ -0,0 +1,7 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +#ifndef _TEST_CLEANUP_H
> +#define _TEST_CLEANUP_H

The "../../../../include/linux/cleanup.h" itself has these guards, so
probably not needed?

> +
> +#include "../../../../include/linux/cleanup.h"
> +
> +#endif /* _TEST_CLEANUP_H */
> 
> ---
> base-commit: 9388ec571cb1adba59d1cded2300eeb11827679c
> change-id: 20250321-fix-radix-tree-build-28e21dd4a64b
> 
> Best regards,
> -- 
> Daniel Gomez <da.gomez@samsung.com>
> 
>