arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi | 102 +++++++++++++++------------- 1 file changed, 55 insertions(+), 47 deletions(-)
From: Xianwei Zhao <xianwei.zhao@amlogic.com>
When use command 'make ARCH=arm64 dtbs_check W=1' to compile dtb,
a warning message appears.
"Warning (simple_bus_reg): /soc/bus@fe000000/pinctrl:
missing or empty reg/ranges property"
Add the unit address to the pinctrl node to fix it.
Fixes: ce78f679e08c ("arm64: dts: amlogic: a4: add pinctrl node")
Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
---
arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi | 102 +++++++++++++++-------------
1 file changed, 55 insertions(+), 47 deletions(-)
diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
index fa80fa365f13..582e0043024b 100644
--- a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
+++ b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
@@ -51,87 +51,52 @@ pwrc: power-controller {
};
&apb {
- gpio_intc: interrupt-controller@4080 {
- compatible = "amlogic,a4-gpio-intc",
- "amlogic,meson-gpio-intc";
- reg = <0x0 0x4080 0x0 0x20>;
- interrupt-controller;
- #interrupt-cells = <2>;
- amlogic,channel-interrupts =
- <10 11 12 13 14 15 16 17 18 19 20 21>;
- };
-
- gpio_ao_intc: interrupt-controller@8e72c {
- compatible = "amlogic,a4-gpio-ao-intc",
- "amlogic,meson-gpio-intc";
- reg = <0x0 0x8e72c 0x0 0x0c>;
- interrupt-controller;
- #interrupt-cells = <2>;
- amlogic,channel-interrupts = <140 141>;
- };
-
- periphs_pinctrl: pinctrl {
+ periphs_pinctrl: pinctrl@4000 {
compatible = "amlogic,pinctrl-a4";
#address-cells = <2>;
#size-cells = <2>;
- ranges;
+ ranges = <0x0 0x0 0x0 0x4000 0x0 0x280>;
- gpiox: gpio@4100 {
- reg = <0 0x4100 0 0x40>, <0 0x400c 0 0xc>;
+ gpiox: gpio@100 {
+ reg = <0 0x100 0 0x40>, <0 0xc 0 0xc>;
reg-names = "gpio", "mux";
gpio-controller;
#gpio-cells = <2>;
gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_X<<8) 18>;
};
- gpiot: gpio@4140 {
- reg = <0 0x4140 0 0x40>, <0 0x402c 0 0xc>;
+ gpiot: gpio@140 {
+ reg = <0 0x140 0 0x40>, <0 0x2c 0 0xc>;
reg-names = "gpio", "mux";
gpio-controller;
#gpio-cells = <2>;
gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_T<<8) 23>;
};
- gpiod: gpio@4180 {
- reg = <0 0x4180 0 0x40>, <0 0x4040 0 0x8>;
+ gpiod: gpio@180 {
+ reg = <0 0x180 0 0x40>, <0 0x40 0 0x8>;
reg-names = "gpio", "mux";
gpio-controller;
#gpio-cells = <2>;
gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_D<<8) 16>;
};
- gpioe: gpio@41c0 {
- reg = <0 0x41c0 0 0x40>, <0 0x4048 0 0x4>;
+ gpioe: gpio@1c0 {
+ reg = <0 0x1c0 0 0x40>, <0 0x48 0 0x4>;
reg-names = "gpio", "mux";
gpio-controller;
#gpio-cells = <2>;
gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_E<<8) 2>;
};
- gpiob: gpio@4240 {
- reg = <0 0x4240 0 0x40>, <0 0x4000 0 0x8>;
+ gpiob: gpio@240 {
+ reg = <0 0x240 0 0x40>, <0 0 0 0x8>;
reg-names = "gpio", "mux";
gpio-controller;
#gpio-cells = <2>;
gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_B<<8) 14>;
};
- gpioao: gpio@8e704 {
- reg = <0 0x8e704 0 0x16>, <0 0x8e700 0 0x4>;
- reg-names = "gpio", "mux";
- gpio-controller;
- #gpio-cells = <2>;
- gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_AO<<8) 7>;
- };
-
- test_n: gpio@8e744 {
- reg = <0 0x8e744 0 0x20>;
- reg-names = "gpio";
- gpio-controller;
- #gpio-cells = <2>;
- gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_TEST_N<<8) 1>;
- };
-
func-uart-a {
uart_a_default: group-uart-a-pins1 {
pinmux = <AML_PINMUX(AMLOGIC_GPIO_X, 11, 1)>,
@@ -186,4 +151,47 @@ uart_e_default: group-uart-e-pins {
};
};
};
+
+ gpio_intc: interrupt-controller@4080 {
+ compatible = "amlogic,a4-gpio-intc",
+ "amlogic,meson-gpio-intc";
+ reg = <0x0 0x4080 0x0 0x20>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ amlogic,channel-interrupts =
+ <10 11 12 13 14 15 16 17 18 19 20 21>;
+ };
+
+ ao_pinctrl: pinctrl@8e700 {
+ compatible = "amlogic,pinctrl-a4";
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges = <0x0 0x0 0x0 0x8e700 0x0 0x80>;
+
+ gpioao: gpio@4 {
+ reg = <0 0x4 0 0x16>, <0 0 0 0x4>;
+ reg-names = "gpio", "mux";
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_AO<<8) 7>;
+ };
+
+ test_n: gpio@44 {
+ reg = <0 0x44 0 0x20>;
+ reg-names = "gpio";
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_TEST_N<<8) 1>;
+ };
+ };
+
+ gpio_ao_intc: interrupt-controller@8e72c {
+ compatible = "amlogic,a4-gpio-ao-intc",
+ "amlogic,meson-gpio-intc";
+ reg = <0x0 0x8e72c 0x0 0x0c>;
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ amlogic,channel-interrupts = <140 141>;
+ };
+
};
---
base-commit: 73a143e436311183186ab4b365a84c662f2c9651
change-id: 20250317-fix-a4-pinctrl-node-9babfd44e085
Best regards,
--
Xianwei Zhao <xianwei.zhao@amlogic.com>Hi,
On 21/03/2025 03:23, Xianwei Zhao via B4 Relay wrote:
> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>
> When use command 'make ARCH=arm64 dtbs_check W=1' to compile dtb,
> a warning message appears.
> "Warning (simple_bus_reg): /soc/bus@fe000000/pinctrl:
> missing or empty reg/ranges property"
>
> Add the unit address to the pinctrl node to fix it.
I've delayed the pinctrl to next release so plase rebase
the commit on top of https://web.git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=for-next
and fix the warnings here, and make sure DTBS_CHECK still passes.
Neil
>
> Fixes: ce78f679e08c ("arm64: dts: amlogic: a4: add pinctrl node")
> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
> ---
> arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi | 102 +++++++++++++++-------------
> 1 file changed, 55 insertions(+), 47 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
> index fa80fa365f13..582e0043024b 100644
> --- a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
> @@ -51,87 +51,52 @@ pwrc: power-controller {
> };
>
> &apb {
> - gpio_intc: interrupt-controller@4080 {
> - compatible = "amlogic,a4-gpio-intc",
> - "amlogic,meson-gpio-intc";
> - reg = <0x0 0x4080 0x0 0x20>;
> - interrupt-controller;
> - #interrupt-cells = <2>;
> - amlogic,channel-interrupts =
> - <10 11 12 13 14 15 16 17 18 19 20 21>;
> - };
> -
> - gpio_ao_intc: interrupt-controller@8e72c {
> - compatible = "amlogic,a4-gpio-ao-intc",
> - "amlogic,meson-gpio-intc";
> - reg = <0x0 0x8e72c 0x0 0x0c>;
> - interrupt-controller;
> - #interrupt-cells = <2>;
> - amlogic,channel-interrupts = <140 141>;
> - };
> -
> - periphs_pinctrl: pinctrl {
> + periphs_pinctrl: pinctrl@4000 {
> compatible = "amlogic,pinctrl-a4";
> #address-cells = <2>;
> #size-cells = <2>;
> - ranges;
> + ranges = <0x0 0x0 0x0 0x4000 0x0 0x280>;
>
> - gpiox: gpio@4100 {
> - reg = <0 0x4100 0 0x40>, <0 0x400c 0 0xc>;
> + gpiox: gpio@100 {
> + reg = <0 0x100 0 0x40>, <0 0xc 0 0xc>;
> reg-names = "gpio", "mux";
> gpio-controller;
> #gpio-cells = <2>;
> gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_X<<8) 18>;
> };
>
> - gpiot: gpio@4140 {
> - reg = <0 0x4140 0 0x40>, <0 0x402c 0 0xc>;
> + gpiot: gpio@140 {
> + reg = <0 0x140 0 0x40>, <0 0x2c 0 0xc>;
> reg-names = "gpio", "mux";
> gpio-controller;
> #gpio-cells = <2>;
> gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_T<<8) 23>;
> };
>
> - gpiod: gpio@4180 {
> - reg = <0 0x4180 0 0x40>, <0 0x4040 0 0x8>;
> + gpiod: gpio@180 {
> + reg = <0 0x180 0 0x40>, <0 0x40 0 0x8>;
> reg-names = "gpio", "mux";
> gpio-controller;
> #gpio-cells = <2>;
> gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_D<<8) 16>;
> };
>
> - gpioe: gpio@41c0 {
> - reg = <0 0x41c0 0 0x40>, <0 0x4048 0 0x4>;
> + gpioe: gpio@1c0 {
> + reg = <0 0x1c0 0 0x40>, <0 0x48 0 0x4>;
> reg-names = "gpio", "mux";
> gpio-controller;
> #gpio-cells = <2>;
> gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_E<<8) 2>;
> };
>
> - gpiob: gpio@4240 {
> - reg = <0 0x4240 0 0x40>, <0 0x4000 0 0x8>;
> + gpiob: gpio@240 {
> + reg = <0 0x240 0 0x40>, <0 0 0 0x8>;
> reg-names = "gpio", "mux";
> gpio-controller;
> #gpio-cells = <2>;
> gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_B<<8) 14>;
> };
>
> - gpioao: gpio@8e704 {
> - reg = <0 0x8e704 0 0x16>, <0 0x8e700 0 0x4>;
> - reg-names = "gpio", "mux";
> - gpio-controller;
> - #gpio-cells = <2>;
> - gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_AO<<8) 7>;
> - };
> -
> - test_n: gpio@8e744 {
> - reg = <0 0x8e744 0 0x20>;
> - reg-names = "gpio";
> - gpio-controller;
> - #gpio-cells = <2>;
> - gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_TEST_N<<8) 1>;
> - };
> -
> func-uart-a {
> uart_a_default: group-uart-a-pins1 {
> pinmux = <AML_PINMUX(AMLOGIC_GPIO_X, 11, 1)>,
> @@ -186,4 +151,47 @@ uart_e_default: group-uart-e-pins {
> };
> };
> };
> +
> + gpio_intc: interrupt-controller@4080 {
> + compatible = "amlogic,a4-gpio-intc",
> + "amlogic,meson-gpio-intc";
> + reg = <0x0 0x4080 0x0 0x20>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + amlogic,channel-interrupts =
> + <10 11 12 13 14 15 16 17 18 19 20 21>;
> + };
> +
> + ao_pinctrl: pinctrl@8e700 {
> + compatible = "amlogic,pinctrl-a4";
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges = <0x0 0x0 0x0 0x8e700 0x0 0x80>;
> +
> + gpioao: gpio@4 {
> + reg = <0 0x4 0 0x16>, <0 0 0 0x4>;
> + reg-names = "gpio", "mux";
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_AO<<8) 7>;
> + };
> +
> + test_n: gpio@44 {
> + reg = <0 0x44 0 0x20>;
> + reg-names = "gpio";
> + gpio-controller;
> + #gpio-cells = <2>;
> + gpio-ranges = <&periphs_pinctrl 0 (AMLOGIC_GPIO_TEST_N<<8) 1>;
> + };
> + };
> +
> + gpio_ao_intc: interrupt-controller@8e72c {
> + compatible = "amlogic,a4-gpio-ao-intc",
> + "amlogic,meson-gpio-intc";
> + reg = <0x0 0x8e72c 0x0 0x0c>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + amlogic,channel-interrupts = <140 141>;
> + };
> +
> };
>
> ---
> base-commit: 73a143e436311183186ab4b365a84c662f2c9651
> change-id: 20250317-fix-a4-pinctrl-node-9babfd44e085
>
> Best regards,
Hi, Neil
Thanks for your advice.
On 2025/3/21 17:37, Neil Armstrong wrote:
> [ EXTERNAL EMAIL ]
>
> Hi,
>
> On 21/03/2025 03:23, Xianwei Zhao via B4 Relay wrote:
>> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>>
>> When use command 'make ARCH=arm64 dtbs_check W=1' to compile dtb,
>> a warning message appears.
>> "Warning (simple_bus_reg): /soc/bus@fe000000/pinctrl:
>> missing or empty reg/ranges property"
>>
>> Add the unit address to the pinctrl node to fix it.
>
> I've delayed the pinctrl to next release so plase rebase
> the commit on top of
> https://web.git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git/log/?h=for-next
> and fix the warnings here, and make sure DTBS_CHECK still passes.
>
Will do.
> Neil
>
>>
>> Fixes: ce78f679e08c ("arm64: dts: amlogic: a4: add pinctrl node")
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> ---
>> arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi | 102
>> +++++++++++++++-------------
>> 1 file changed, 55 insertions(+), 47 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>> b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>> index fa80fa365f13..582e0043024b 100644
>> --- a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>> @@ -51,87 +51,52 @@ pwrc: power-controller {
>> };
>>
>> &apb {
>> - gpio_intc: interrupt-controller@4080 {
>> - compatible = "amlogic,a4-gpio-intc",
>> - "amlogic,meson-gpio-intc";
>> - reg = <0x0 0x4080 0x0 0x20>;
>> - interrupt-controller;
>> - #interrupt-cells = <2>;
>> - amlogic,channel-interrupts =
>> - <10 11 12 13 14 15 16 17 18 19 20 21>;
>> - };
>> -
>> - gpio_ao_intc: interrupt-controller@8e72c {
>> - compatible = "amlogic,a4-gpio-ao-intc",
>> - "amlogic,meson-gpio-intc";
>> - reg = <0x0 0x8e72c 0x0 0x0c>;
>> - interrupt-controller;
>> - #interrupt-cells = <2>;
>> - amlogic,channel-interrupts = <140 141>;
>> - };
>> -
>> - periphs_pinctrl: pinctrl {
>> + periphs_pinctrl: pinctrl@4000 {
>> compatible = "amlogic,pinctrl-a4";
>> #address-cells = <2>;
>> #size-cells = <2>;
>> - ranges;
>> + ranges = <0x0 0x0 0x0 0x4000 0x0 0x280>;
>>
>> - gpiox: gpio@4100 {
>> - reg = <0 0x4100 0 0x40>, <0 0x400c 0 0xc>;
>> + gpiox: gpio@100 {
>> + reg = <0 0x100 0 0x40>, <0 0xc 0 0xc>;
>> reg-names = "gpio", "mux";
>> gpio-controller;
>> #gpio-cells = <2>;
>> gpio-ranges = <&periphs_pinctrl 0
>> (AMLOGIC_GPIO_X<<8) 18>;
>> };
>>
>> - gpiot: gpio@4140 {
>> - reg = <0 0x4140 0 0x40>, <0 0x402c 0 0xc>;
>> + gpiot: gpio@140 {
>> + reg = <0 0x140 0 0x40>, <0 0x2c 0 0xc>;
>> reg-names = "gpio", "mux";
>> gpio-controller;
>> #gpio-cells = <2>;
>> gpio-ranges = <&periphs_pinctrl 0
>> (AMLOGIC_GPIO_T<<8) 23>;
>> };
>>
>> - gpiod: gpio@4180 {
>> - reg = <0 0x4180 0 0x40>, <0 0x4040 0 0x8>;
>> + gpiod: gpio@180 {
>> + reg = <0 0x180 0 0x40>, <0 0x40 0 0x8>;
>> reg-names = "gpio", "mux";
>> gpio-controller;
>> #gpio-cells = <2>;
>> gpio-ranges = <&periphs_pinctrl 0
>> (AMLOGIC_GPIO_D<<8) 16>;
>> };
>>
>> - gpioe: gpio@41c0 {
>> - reg = <0 0x41c0 0 0x40>, <0 0x4048 0 0x4>;
>> + gpioe: gpio@1c0 {
>> + reg = <0 0x1c0 0 0x40>, <0 0x48 0 0x4>;
>> reg-names = "gpio", "mux";
>> gpio-controller;
>> #gpio-cells = <2>;
>> gpio-ranges = <&periphs_pinctrl 0
>> (AMLOGIC_GPIO_E<<8) 2>;
>> };
>>
>> - gpiob: gpio@4240 {
>> - reg = <0 0x4240 0 0x40>, <0 0x4000 0 0x8>;
>> + gpiob: gpio@240 {
>> + reg = <0 0x240 0 0x40>, <0 0 0 0x8>;
>> reg-names = "gpio", "mux";
>> gpio-controller;
>> #gpio-cells = <2>;
>> gpio-ranges = <&periphs_pinctrl 0
>> (AMLOGIC_GPIO_B<<8) 14>;
>> };
>>
>> - gpioao: gpio@8e704 {
>> - reg = <0 0x8e704 0 0x16>, <0 0x8e700 0 0x4>;
>> - reg-names = "gpio", "mux";
>> - gpio-controller;
>> - #gpio-cells = <2>;
>> - gpio-ranges = <&periphs_pinctrl 0
>> (AMLOGIC_GPIO_AO<<8) 7>;
>> - };
>> -
>> - test_n: gpio@8e744 {
>> - reg = <0 0x8e744 0 0x20>;
>> - reg-names = "gpio";
>> - gpio-controller;
>> - #gpio-cells = <2>;
>> - gpio-ranges = <&periphs_pinctrl 0
>> (AMLOGIC_GPIO_TEST_N<<8) 1>;
>> - };
>> -
>> func-uart-a {
>> uart_a_default: group-uart-a-pins1 {
>> pinmux = <AML_PINMUX(AMLOGIC_GPIO_X, 11,
>> 1)>,
>> @@ -186,4 +151,47 @@ uart_e_default: group-uart-e-pins {
>> };
>> };
>> };
>> +
>> + gpio_intc: interrupt-controller@4080 {
>> + compatible = "amlogic,a4-gpio-intc",
>> + "amlogic,meson-gpio-intc";
>> + reg = <0x0 0x4080 0x0 0x20>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + amlogic,channel-interrupts =
>> + <10 11 12 13 14 15 16 17 18 19 20 21>;
>> + };
>> +
>> + ao_pinctrl: pinctrl@8e700 {
>> + compatible = "amlogic,pinctrl-a4";
>> + #address-cells = <2>;
>> + #size-cells = <2>;
>> + ranges = <0x0 0x0 0x0 0x8e700 0x0 0x80>;
>> +
>> + gpioao: gpio@4 {
>> + reg = <0 0x4 0 0x16>, <0 0 0 0x4>;
>> + reg-names = "gpio", "mux";
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + gpio-ranges = <&periphs_pinctrl 0
>> (AMLOGIC_GPIO_AO<<8) 7>;
>> + };
>> +
>> + test_n: gpio@44 {
>> + reg = <0 0x44 0 0x20>;
>> + reg-names = "gpio";
>> + gpio-controller;
>> + #gpio-cells = <2>;
>> + gpio-ranges = <&periphs_pinctrl 0
>> (AMLOGIC_GPIO_TEST_N<<8) 1>;
>> + };
>> + };
>> +
>> + gpio_ao_intc: interrupt-controller@8e72c {
>> + compatible = "amlogic,a4-gpio-ao-intc",
>> + "amlogic,meson-gpio-intc";
>> + reg = <0x0 0x8e72c 0x0 0x0c>;
>> + interrupt-controller;
>> + #interrupt-cells = <2>;
>> + amlogic,channel-interrupts = <140 141>;
>> + };
>> +
>> };
>>
>> ---
>> base-commit: 73a143e436311183186ab4b365a84c662f2c9651
>> change-id: 20250317-fix-a4-pinctrl-node-9babfd44e085
>>
>> Best regards,
>
On 21/03/2025 03:23, Xianwei Zhao via B4 Relay wrote:
> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>
> When use command 'make ARCH=arm64 dtbs_check W=1' to compile dtb,
> a warning message appears.
> "Warning (simple_bus_reg): /soc/bus@fe000000/pinctrl:
> missing or empty reg/ranges property"
>
> Add the unit address to the pinctrl node to fix it.
>
> Fixes: ce78f679e08c ("arm64: dts: amlogic: a4: add pinctrl node")
> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
> ---
> arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi | 102 +++++++++++++++-------------
> 1 file changed, 55 insertions(+), 47 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
> index fa80fa365f13..582e0043024b 100644
> --- a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
> @@ -51,87 +51,52 @@ pwrc: power-controller {
> };
>
> &apb {
> - gpio_intc: interrupt-controller@4080 {
> - compatible = "amlogic,a4-gpio-intc",
> - "amlogic,meson-gpio-intc";
> - reg = <0x0 0x4080 0x0 0x20>;
> - interrupt-controller;
> - #interrupt-cells = <2>;
> - amlogic,channel-interrupts =
> - <10 11 12 13 14 15 16 17 18 19 20 21>;
> - };
> -
> - gpio_ao_intc: interrupt-controller@8e72c {
> - compatible = "amlogic,a4-gpio-ao-intc",
> - "amlogic,meson-gpio-intc";
> - reg = <0x0 0x8e72c 0x0 0x0c>;
> - interrupt-controller;
> - #interrupt-cells = <2>;
> - amlogic,channel-interrupts = <140 141>;
> - };
Not related to the change you described in commit msg.
Best regards,
Krzysztof
Hi Krzysztof,
Thanks for your reply.
On 2025/3/21 17:25, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
>
> On 21/03/2025 03:23, Xianwei Zhao via B4 Relay wrote:
>> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>>
>> When use command 'make ARCH=arm64 dtbs_check W=1' to compile dtb,
>> a warning message appears.
>> "Warning (simple_bus_reg): /soc/bus@fe000000/pinctrl:
>> missing or empty reg/ranges property"
>>
>> Add the unit address to the pinctrl node to fix it.
>>
>> Fixes: ce78f679e08c ("arm64: dts: amlogic: a4: add pinctrl node")
>> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
>> ---
>> arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi | 102 +++++++++++++++-------------
>> 1 file changed, 55 insertions(+), 47 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>> index fa80fa365f13..582e0043024b 100644
>> --- a/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/amlogic-a4.dtsi
>> @@ -51,87 +51,52 @@ pwrc: power-controller {
>> };
>>
>> &apb {
>> - gpio_intc: interrupt-controller@4080 {
>> - compatible = "amlogic,a4-gpio-intc",
>> - "amlogic,meson-gpio-intc";
>> - reg = <0x0 0x4080 0x0 0x20>;
>> - interrupt-controller;
>> - #interrupt-cells = <2>;
>> - amlogic,channel-interrupts =
>> - <10 11 12 13 14 15 16 17 18 19 20 21>;
>> - };
>> -
>> - gpio_ao_intc: interrupt-controller@8e72c {
>> - compatible = "amlogic,a4-gpio-ao-intc",
>> - "amlogic,meson-gpio-intc";
>> - reg = <0x0 0x8e72c 0x0 0x0c>;
>> - interrupt-controller;
>> - #interrupt-cells = <2>;
>> - amlogic,channel-interrupts = <140 141>;
>> - };
>
>
> Not related to the change you described in commit msg.
>
I will add the corresponding description in commit msg.
>
> Best regards,
> Krzysztof
© 2016 - 2025 Red Hat, Inc.