[PATCH] clang-format: add for_each macros from libfdt

Changyuan Lyu posted 1 patch 9 months ago
.clang-format | 2 ++
1 file changed, 2 insertions(+)
[PATCH] clang-format: add for_each macros from libfdt
Posted by Changyuan Lyu 9 months ago
Add two for_each macros from scripts/dtc/libfdt/libfdt.h.

Signed-off-by: Changyuan Lyu <changyuanl@google.com>
---
 .clang-format | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/.clang-format b/.clang-format
index fe1aa1a30d40..4decda7474e1 100644
--- a/.clang-format
+++ b/.clang-format
@@ -210,6 +210,8 @@ ForEachMacros:
   - 'evlist__for_each_entry_from'
   - 'evlist__for_each_entry_reverse'
   - 'evlist__for_each_entry_safe'
+  - 'fdt_for_each_property_offset'
+  - 'fdt_for_each_subnode'
   - 'flow_action_for_each'
   - 'for_each_acpi_consumer_dev'
   - 'for_each_acpi_dev_match'
-- 
2.49.0.395.g12beb8f557-goog
Re: [PATCH] clang-format: add for_each macros from libfdt
Posted by Bill Wendling 9 months ago
On Thu, Mar 20, 2025 at 4:59 PM Changyuan Lyu <changyuanl@google.com> wrote:
>
> Add two for_each macros from scripts/dtc/libfdt/libfdt.h.
>
> Signed-off-by: Changyuan Lyu <changyuanl@google.com>
> ---
>  .clang-format | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/.clang-format b/.clang-format
> index fe1aa1a30d40..4decda7474e1 100644
> --- a/.clang-format
> +++ b/.clang-format
> @@ -210,6 +210,8 @@ ForEachMacros:
>    - 'evlist__for_each_entry_from'
>    - 'evlist__for_each_entry_reverse'
>    - 'evlist__for_each_entry_safe'
> +  - 'fdt_for_each_property_offset'
> +  - 'fdt_for_each_subnode'

Could you alphabetize these please?

>    - 'flow_action_for_each'
>    - 'for_each_acpi_consumer_dev'
>    - 'for_each_acpi_dev_match'
> --
> 2.49.0.395.g12beb8f557-goog
>
Re: [PATCH] clang-format: add for_each macros from libfdt
Posted by Changyuan Lyu 9 months ago
Hi Bill,

On Fri, Mar 21, 2025 at 12:28:44 -0700, Bill Wendling <morbo@google.com> wrote:
> On Thu, Mar 20, 2025 at 4:59=E2=80=AFPM Changyuan Lyu <changyuanl@google.co=
> m> wrote:
> >
> > Add two for_each macros from scripts/dtc/libfdt/libfdt.h.
> >
> > Signed-off-by: Changyuan Lyu <changyuanl@google.com>
> > ---
> >  .clang-format | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/.clang-format b/.clang-format
> > index fe1aa1a30d40..4decda7474e1 100644
> > --- a/.clang-format
> > +++ b/.clang-format
> > @@ -210,6 +210,8 @@ ForEachMacros:
> >    - 'evlist__for_each_entry_from'
> >    - 'evlist__for_each_entry_reverse'
> >    - 'evlist__for_each_entry_safe'
> > +  - 'fdt_for_each_property_offset'
> > +  - 'fdt_for_each_subnode'
>
> Could you alphabetize these please?
>
> >    - 'flow_action_for_each'
> >    - 'for_each_acpi_consumer_dev'
> >    - 'for_each_acpi_dev_match'
> > --
> > 2.49.0.395.g12beb8f557-goog
> >

Thanks for taking a look, but I think the list `ForEachMacros`
is already sorted alphabetically.
Am I missing anything?

Best,
Changyuan
Re: [PATCH] clang-format: add for_each macros from libfdt
Posted by Bill Wendling 9 months ago
On Fri, Mar 21, 2025 at 3:05 PM Changyuan Lyu <changyuanl@google.com> wrote:
>
> Hi Bill,
>
> On Fri, Mar 21, 2025 at 12:28:44 -0700, Bill Wendling <morbo@google.com> wrote:
> > On Thu, Mar 20, 2025 at 4:59=E2=80=AFPM Changyuan Lyu <changyuanl@google.co=
> > m> wrote:
> > >
> > > Add two for_each macros from scripts/dtc/libfdt/libfdt.h.
> > >
> > > Signed-off-by: Changyuan Lyu <changyuanl@google.com>
> > > ---
> > >  .clang-format | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/.clang-format b/.clang-format
> > > index fe1aa1a30d40..4decda7474e1 100644
> > > --- a/.clang-format
> > > +++ b/.clang-format
> > > @@ -210,6 +210,8 @@ ForEachMacros:
> > >    - 'evlist__for_each_entry_from'
> > >    - 'evlist__for_each_entry_reverse'
> > >    - 'evlist__for_each_entry_safe'
> > > +  - 'fdt_for_each_property_offset'
> > > +  - 'fdt_for_each_subnode'
> >
> > Could you alphabetize these please?
> >
> > >    - 'flow_action_for_each'
> > >    - 'for_each_acpi_consumer_dev'
> > >    - 'for_each_acpi_dev_match'
> > > --
> > > 2.49.0.395.g12beb8f557-goog
> > >
>
> Thanks for taking a look, but I think the list `ForEachMacros`
> is already sorted alphabetically.
> Am I missing anything?
>
Oh! I'm sorry. I tought that the 'd' (dee) in 'fdt_...' was an 'o' (oh). My bad.

-bw