[PATCH] pcmcia: omap: Add missing check for platform_get_resource

Chen Ni posted 1 patch 9 months ago
drivers/pcmcia/omap_cf.c | 2 ++
1 file changed, 2 insertions(+)
[PATCH] pcmcia: omap: Add missing check for platform_get_resource
Posted by Chen Ni 9 months ago
Add missing check for platform_get_resource() and return error if it fails
to catch the error.

Fixes: d87d44f7ab35 ("ARM: omap1: move CF chipselect setup to board file")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/pcmcia/omap_cf.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/pcmcia/omap_cf.c b/drivers/pcmcia/omap_cf.c
index f0ccf479f36e..e0a3820acaef 100644
--- a/drivers/pcmcia/omap_cf.c
+++ b/drivers/pcmcia/omap_cf.c
@@ -215,6 +215,8 @@ static int __init omap_cf_probe(struct platform_device *pdev)
 		return -EINVAL;
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	if (!res)
+		return -EINVAL;
 
 	cf = kzalloc(sizeof *cf, GFP_KERNEL);
 	if (!cf)
-- 
2.25.1
Re: [PATCH] pcmcia: omap: Add missing check for platform_get_resource
Posted by Dominik Brodowski 4 months ago
Am Thu, Mar 20, 2025 at 02:39:56PM +0800 schrieb Chen Ni:
> Add missing check for platform_get_resource() and return error if it fails
> to catch the error.
> 
> Fixes: d87d44f7ab35 ("ARM: omap1: move CF chipselect setup to board file")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Applied to pcmcia-next, thanks.

Best,
	Dominik

> ---
>  drivers/pcmcia/omap_cf.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/pcmcia/omap_cf.c b/drivers/pcmcia/omap_cf.c
> index f0ccf479f36e..e0a3820acaef 100644
> --- a/drivers/pcmcia/omap_cf.c
> +++ b/drivers/pcmcia/omap_cf.c
> @@ -215,6 +215,8 @@ static int __init omap_cf_probe(struct platform_device *pdev)
>  		return -EINVAL;
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	if (!res)
> +		return -EINVAL;
>  
>  	cf = kzalloc(sizeof *cf, GFP_KERNEL);
>  	if (!cf)
> -- 
> 2.25.1
> 
>