[PATCH 6/8] mfd: ocelot: correct Kconfig dependency

Rasmus Villemoes posted 8 patches 9 months ago
[PATCH 6/8] mfd: ocelot: correct Kconfig dependency
Posted by Rasmus Villemoes 9 months ago
The ocelot-spi.c file does not actually use the generic spi regmap
support (i.e., it does not call any variant of regmap_init_spi), but
instead implements its own specialized regmap (though of course with
spi as the underlying bus). So it should simply 'select REGMAP'.

Signed-off-by: Rasmus Villemoes <ravi@prevas.dk>
---
 drivers/mfd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 6b0682af6e32b..4dc894061b62e 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -1049,7 +1049,7 @@ config MFD_OCELOT
 	tristate "Microsemi Ocelot External Control Support"
 	depends on SPI_MASTER
 	select MFD_CORE
-	select REGMAP_SPI
+	select REGMAP
 	help
 	  Ocelot is a family of networking chips that support multiple ethernet
 	  and fibre interfaces. In addition to networking, they contain several
-- 
2.49.0
Re: [PATCH 6/8] mfd: ocelot: correct Kconfig dependency
Posted by Colin Foster 9 months ago
On Wed, Mar 19, 2025 at 01:30:56PM +0100, Rasmus Villemoes wrote:
> The ocelot-spi.c file does not actually use the generic spi regmap
> support (i.e., it does not call any variant of regmap_init_spi), but
> instead implements its own specialized regmap (though of course with
> spi as the underlying bus). So it should simply 'select REGMAP'.
> 
> Signed-off-by: Rasmus Villemoes <ravi@prevas.dk>

This might have gone back and forth a few times during development. Good
find!

Reviewed-by: Colin Foster <colin.foster@in-advantage.com>