[PATCH] rust: block: Remove unnecessary comma in introduction

chentaotao posted 1 patch 9 months ago
There is a newer version of this series
rust/kernel/block/mq.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] rust: block: Remove unnecessary comma in introduction
Posted by chentaotao 9 months ago
The comma after "methods" was not needed and has been removed for
better readability and correctness.

Signed-off-by: chentaotao <chentaotao@didiglobal.com>
---
 rust/kernel/block/mq.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/rust/kernel/block/mq.rs b/rust/kernel/block/mq.rs
index fb0f393c1..ee8f34f40 100644
--- a/rust/kernel/block/mq.rs
+++ b/rust/kernel/block/mq.rs
@@ -23,7 +23,7 @@
 //! IO requests are passed to the driver as [`kernel::types::ARef<Request>`]
 //! instances. The `Request` type is a wrapper around the C `struct request`.
 //! The driver must mark end of processing by calling one of the
-//! `Request::end`, methods. Failure to do so can lead to deadlock or timeout
+//! `Request::end` methods. Failure to do so can lead to deadlock or timeout
 //! errors. Please note that the C function `blk_mq_start_request` is implicitly
 //! called when the request is queued with the driver.
 //!
-- 
2.34.1
Re: [PATCH] rust: block: Remove unnecessary comma in introduction
Posted by Andreas Hindborg 9 months ago
"chentaotao" <chentaotao@didiglobal.com> writes:

> The comma after "methods" was not needed and has been removed for
> better readability and correctness.
>
> Signed-off-by: chentaotao <chentaotao@didiglobal.com>
> ---
>  rust/kernel/block/mq.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/kernel/block/mq.rs b/rust/kernel/block/mq.rs
> index fb0f393c1..ee8f34f40 100644
> --- a/rust/kernel/block/mq.rs
> +++ b/rust/kernel/block/mq.rs
> @@ -23,7 +23,7 @@
>  //! IO requests are passed to the driver as [`kernel::types::ARef<Request>`]
>  //! instances. The `Request` type is a wrapper around the C `struct request`.
>  //! The driver must mark end of processing by calling one of the
> -//! `Request::end`, methods. Failure to do so can lead to deadlock or timeout
> +//! `Request::end` methods. Failure to do so can lead to deadlock or timeout
>  //! errors. Please note that the C function `blk_mq_start_request` is implicitly
>  //! called when the request is queued with the driver.
>  //!


Acked-by: Andreas Hindborg <a.hindborg@kernel.org>


Best regards,
Andreas Hindborg
Re: [PATCH] rust: block: Remove unnecessary comma in introduction
Posted by Taotao chen 9 months ago
Hi, Andreas

I realized that my previous commit message was incorrect — the comma
removed was before "methods" not after. I will submit a v2 patch to
correct this.

Apologies for the mistake, and thank you for your time.

Best regards,
Chentaotao