perf: intel-tpebs: Fix incorrect usage of zfree()

[PATCH] perf: intel-tpebs: Fix incorrect usage of zfree()

Posted by James Clark 9 months ago

zfree() requires an address otherwise it frees what's in name, rather
than name itself. Pass the address of name to fix it.

This was the only incorrect occurrence in Perf found using a search.

Fixes: 8db5cabcf1b6 ("perf stat: Fork and launch 'perf record' when 'perf stat' needs to get retire latency value for a metric.")
Signed-off-by: James Clark <james.clark@linaro.org>
---
 tools/perf/util/intel-tpebs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/intel-tpebs.c b/tools/perf/util/intel-tpebs.c
index 50a3c3e07160..2c421b475b3b 100644
--- a/tools/perf/util/intel-tpebs.c
+++ b/tools/perf/util/intel-tpebs.c
@@ -254,7 +254,7 @@ int tpebs_start(struct evlist *evsel_list)
 		new = zalloc(sizeof(*new));
 		if (!new) {
 			ret = -1;
-			zfree(name);
+			zfree(&name);
 			goto err;
 		}
 		new->name = name;
-- 
2.34.1

Re: [PATCH] perf: intel-tpebs: Fix incorrect usage of zfree()

Posted by Namhyung Kim 9 months ago

On Wed, 19 Mar 2025 10:16:10 +0000, James Clark wrote:
> zfree() requires an address otherwise it frees what's in name, rather
> than name itself. Pass the address of name to fix it.
> 
> This was the only incorrect occurrence in Perf found using a search.
> 
> 
Applied to perf-tools-next, thanks!

Best regards,
Namhyung