Loongarch: Fix device node refcount leak in fdt_cpu_clk_init

[PATCH] Loongarch: Fix device node refcount leak in fdt_cpu_clk_init

Posted by Miaoqian Lin 9 months ago

Add missing of_node_put() to properly handle the reference count of the
device node obtained from of_get_cpu_node().

Fixes: 44a01f1f726a ("LoongArch: Parsing CPU-related information from DTS")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
 arch/loongarch/kernel/env.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/loongarch/kernel/env.c b/arch/loongarch/kernel/env.c
index 2f1f5b08638f..01aea44cf4b0 100644
--- a/arch/loongarch/kernel/env.c
+++ b/arch/loongarch/kernel/env.c
@@ -68,6 +68,7 @@ static int __init fdt_cpu_clk_init(void)
 		return -ENODEV;
 
 	clk = of_clk_get(np, 0);
+	of_node_put(np);
 	if (IS_ERR(clk))
 		return -ENODEV;
 
-- 
2.39.5 (Apple Git-154)

Re: [PATCH] Loongarch: Fix device node refcount leak in fdt_cpu_clk_init

Posted by Huacai Chen 8 months, 3 weeks ago

Applied, thanks.

Huacai

On Wed, Mar 19, 2025 at 10:54 AM Miaoqian Lin <linmq006@gmail.com> wrote:
>
> Add missing of_node_put() to properly handle the reference count of the
> device node obtained from of_get_cpu_node().
>
> Fixes: 44a01f1f726a ("LoongArch: Parsing CPU-related information from DTS")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
>  arch/loongarch/kernel/env.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/loongarch/kernel/env.c b/arch/loongarch/kernel/env.c
> index 2f1f5b08638f..01aea44cf4b0 100644
> --- a/arch/loongarch/kernel/env.c
> +++ b/arch/loongarch/kernel/env.c
> @@ -68,6 +68,7 @@ static int __init fdt_cpu_clk_init(void)
>                 return -ENODEV;
>
>         clk = of_clk_get(np, 0);
> +       of_node_put(np);
>         if (IS_ERR(clk))
>                 return -ENODEV;
>
> --
> 2.39.5 (Apple Git-154)
>