[PATCH v3 0/7] rust: generate_rust_analyzer.py: define host crates

Tamir Duberstein posted 7 patches 9 months ago
scripts/generate_rust_analyzer.py | 210 ++++++++++++++++++++++++++------------
1 file changed, 144 insertions(+), 66 deletions(-)
[PATCH v3 0/7] rust: generate_rust_analyzer.py: define host crates
Posted by Tamir Duberstein 9 months ago
This series updates rust-project.json to differentiate between host and
target crates, where the former are used as dependencies of the `macros`
crate. Please see individual commit messages for details.

The first 3 commits contain mechanical formatting changes and are
optional. The series can be taken without them.

I avoided more significant formatting or changes where possible to
reduce the diff. Unfortunately `scripts/generate_rust_analyzer.py` is
not consistently formatted before nor after this series.

The 5th commit ("scripts: generate_rust_analyzer.py: use
str(pathlib.Path)") can also be considered optional. It removes an
inconsistency I noticed while working on this series and which occurs on
a line which churns in this series anyway.

Signed-off-by: Tamir Duberstein <tamird@gmail.com>
---
Changes in v3:
- Rebase on linux-next. This is needed to pick up all the conflicts from
  both rust-next and rust-fixes.
- Drop `uv` from `mypy` command. (Trevor Gross)
- Add `--python-version 3.8` to `mypy` command. (Trevor Gross)
- `from typings import ...` directly. (Trevor Gross)
- Extract `build_crate` and `register_crate` to avoid peeking into
  `crates[-1]`. (Trevor Gross)
- Link to v2: https://lore.kernel.org/r/20250311-rust-analyzer-host-v2-0-30220e116511@gmail.com

Changes in v2:
- Rebased on "rust: fix rust-analyzer configuration for generated files" [1]
  Link: https://lore.kernel.org/all/CANiq72nv7nQ+1BinCHe2qsvwdUb-y9t7x=RGSppi_n9TBXNHpw@mail.gmail.com/ [1]
- Link to v1: https://lore.kernel.org/r/20250209-rust-analyzer-host-v1-0-a2286a2a2fa3@gmail.com

---
Tamir Duberstein (7):
      scripts: generate_rust_analyzer.py: add missing whitespace
      scripts: generate_rust_analyzer.py: use double quotes
      scripts: generate_rust_analyzer.py: add trailing comma
      scripts: generate_rust_analyzer.py: add type hints
      scripts: generate_rust_analyzer.py: use str(pathlib.Path)
      scripts: generate_rust_analyzer.py: identify crates explicitly
      scripts: generate_rust_analyzer.py: define host crates

 scripts/generate_rust_analyzer.py | 210 ++++++++++++++++++++++++++------------
 1 file changed, 144 insertions(+), 66 deletions(-)
---
base-commit: 57e79e4281c114dc06f6aaf3369d863025e706b4
change-id: 20250209-rust-analyzer-host-43b108655578

Best regards,
-- 
Tamir Duberstein <tamird@gmail.com>
Re: [PATCH v3 0/7] rust: generate_rust_analyzer.py: define host crates
Posted by Tamir Duberstein 9 months ago
On Wed, Mar 19, 2025 at 8:07 PM Tamir Duberstein <tamird@gmail.com> wrote:
>
> This series updates rust-project.json to differentiate between host and
> target crates, where the former are used as dependencies of the `macros`
> crate. Please see individual commit messages for details.
>
> The first 3 commits contain mechanical formatting changes and are
> optional. The series can be taken without them.
>
> I avoided more significant formatting or changes where possible to
> reduce the diff. Unfortunately `scripts/generate_rust_analyzer.py` is
> not consistently formatted before nor after this series.
>
> The 5th commit ("scripts: generate_rust_analyzer.py: use
> str(pathlib.Path)") can also be considered optional. It removes an
> inconsistency I noticed while working on this series and which occurs on
> a line which churns in this series anyway.
>
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>
> ---
> Changes in v3:
> - Rebase on linux-next. This is needed to pick up all the conflicts from
>   both rust-next and rust-fixes.
> - Drop `uv` from `mypy` command. (Trevor Gross)
> - Add `--python-version 3.8` to `mypy` command. (Trevor Gross)
> - `from typings import ...` directly. (Trevor Gross)
> - Extract `build_crate` and `register_crate` to avoid peeking into
>   `crates[-1]`. (Trevor Gross)

I decided to put this in its own patch in v4, will respin later today.

> - Link to v2: https://lore.kernel.org/r/20250311-rust-analyzer-host-v2-0-30220e116511@gmail.com