1. Patchew
  2. linux
  3. View series

[PATCH v2] arm64: dts: qcom: ipq5424: fix and relocate uart1 gpio configurations

Manikanta Mylavarapu posted 1 patch 9 months ago 
arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 19 ++++++++++++++++++-
arch/arm64/boot/dts/qcom/ipq5424.dtsi       |  7 -------
2 files changed, 18 insertions(+), 8 deletions(-)
[PATCH v2] arm64: dts: qcom: ipq5424: fix and relocate uart1 gpio configurations
Posted by Manikanta Mylavarapu 9 months ago 
Update the bias configuration for UART1 TX and RX pins to ensure correct
settings for RDP466.

Additionally, move the UART1 GPIO configurations from the common .dtsi
file to the RDP-specific .dts files to account for differing bias
configurations across RDPs of IPQ5424.

Fixes: 1a91d2a6021e ("arm64: dts: qcom: add IPQ5424 SoC and rdp466 board support")
Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
---
Changes in V2:
	- Consolidated uart1_tx_state and uart1_rx_state nodes into a
	  single qup_uart1_default_state node, which includes the
	  configuration for both UART1 TX and RX pins.
	- Inserted a blank line before the status property in the UART1
	  node.
	- Fixed review comments from Kathiravan Thirumoorthy.

 arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 19 ++++++++++++++++++-
 arch/arm64/boot/dts/qcom/ipq5424.dtsi       |  7 -------
 2 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
index b9752e8d579e..f0cba6b2be70 100644
--- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
+++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
@@ -102,6 +102,22 @@ &ssphy_0 {
 };
 
 &tlmm {
+	qup_uart1_default_state: qup-uart1-default-state {
+		uart1-tx-pins {
+			pins = "gpio44";
+			function = "uart1";
+			drive-strength = <8>;
+			bias-pull-down;
+		};
+
+		uart1-rx-pins {
+			pins = "gpio43";
+			function = "uart1";
+			drive-strength = <8>;
+			bias-pull-up;
+		};
+	};
+
 	spi0_default_state: spi0-default-state {
 		clk-pins {
 			pins = "gpio6";
@@ -157,8 +173,9 @@ data-pins {
 };
 
 &uart1 {
-	pinctrl-0 = <&uart1_pins>;
+	pinctrl-0 = <&qup_uart1_default_state>;
 	pinctrl-names = "default";
+
 	status = "okay";
 };
 
diff --git a/arch/arm64/boot/dts/qcom/ipq5424.dtsi b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
index 402d0a2c7bcc..0117f6422347 100644
--- a/arch/arm64/boot/dts/qcom/ipq5424.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq5424.dtsi
@@ -262,13 +262,6 @@ tlmm: pinctrl@1000000 {
 			gpio-ranges = <&tlmm 0 0 50>;
 			interrupt-controller;
 			#interrupt-cells = <2>;
-
-			uart1_pins: uart1-state {
-				pins = "gpio43", "gpio44";
-				function = "uart1";
-				drive-strength = <8>;
-				bias-pull-up;
-			};
 		};
 
 		gcc: clock-controller@1800000 {

base-commit: da920b7df701770e006928053672147075587fb2
-- 
2.34.1
Re: [PATCH v2] arm64: dts: qcom: ipq5424: fix and relocate uart1 gpio configurations
Posted by Konrad Dybcio 8 months, 1 week ago 
On 3/18/25 7:49 AM, Manikanta Mylavarapu wrote:
> Update the bias configuration for UART1 TX and RX pins to ensure correct
> settings for RDP466.
> 
> Additionally, move the UART1 GPIO configurations from the common .dtsi
> file to the RDP-specific .dts files to account for differing bias
> configurations across RDPs of IPQ5424.
> 
> Fixes: 1a91d2a6021e ("arm64: dts: qcom: add IPQ5424 SoC and rdp466 board support")
> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
> ---
> Changes in V2:
> 	- Consolidated uart1_tx_state and uart1_rx_state nodes into a
> 	  single qup_uart1_default_state node, which includes the
> 	  configuration for both UART1 TX and RX pins.
> 	- Inserted a blank line before the status property in the UART1
> 	  node.
> 	- Fixed review comments from Kathiravan Thirumoorthy.
> 
>  arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 19 ++++++++++++++++++-
>  arch/arm64/boot/dts/qcom/ipq5424.dtsi       |  7 -------
>  2 files changed, 18 insertions(+), 8 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> index b9752e8d579e..f0cba6b2be70 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> @@ -102,6 +102,22 @@ &ssphy_0 {
>  };
>  
>  &tlmm {
> +	qup_uart1_default_state: qup-uart1-default-state {
> +		uart1-tx-pins {
> +			pins = "gpio44";
> +			function = "uart1";
> +			drive-strength = <8>;
> +			bias-pull-down;

Pull*down* on TX? Are there noise issues or similar?

Konrad
Re: [PATCH v2] arm64: dts: qcom: ipq5424: fix and relocate uart1 gpio configurations
Posted by Bjorn Andersson 7 months ago 
On Wed, Apr 09, 2025 at 09:36:00PM +0200, Konrad Dybcio wrote:
> On 3/18/25 7:49 AM, Manikanta Mylavarapu wrote:
> > Update the bias configuration for UART1 TX and RX pins to ensure correct
> > settings for RDP466.
> > 
> > Additionally, move the UART1 GPIO configurations from the common .dtsi
> > file to the RDP-specific .dts files to account for differing bias
> > configurations across RDPs of IPQ5424.
> > 
> > Fixes: 1a91d2a6021e ("arm64: dts: qcom: add IPQ5424 SoC and rdp466 board support")
> > Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
> > ---
> > Changes in V2:
> > 	- Consolidated uart1_tx_state and uart1_rx_state nodes into a
> > 	  single qup_uart1_default_state node, which includes the
> > 	  configuration for both UART1 TX and RX pins.
> > 	- Inserted a blank line before the status property in the UART1
> > 	  node.
> > 	- Fixed review comments from Kathiravan Thirumoorthy.
> > 
> >  arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts | 19 ++++++++++++++++++-
> >  arch/arm64/boot/dts/qcom/ipq5424.dtsi       |  7 -------
> >  2 files changed, 18 insertions(+), 8 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> > index b9752e8d579e..f0cba6b2be70 100644
> > --- a/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> > +++ b/arch/arm64/boot/dts/qcom/ipq5424-rdp466.dts
> > @@ -102,6 +102,22 @@ &ssphy_0 {
> >  };
> >  
> >  &tlmm {
> > +	qup_uart1_default_state: qup-uart1-default-state {
> > +		uart1-tx-pins {
> > +			pins = "gpio44";
> > +			function = "uart1";
> > +			drive-strength = <8>;
> > +			bias-pull-down;
> 
> Pull*down* on TX? Are there noise issues or similar?
> 

Pull down doesn't make sense to me either but I don't see any answer to
the question. If this is correct, please add a line/paragraph in the
commit message describing why this should be pulled down.

Dropping this from my review queue now.

Thanks,
Bjorn

> Konrad
Re: [PATCH v2] arm64: dts: qcom: ipq5424: fix and relocate uart1 gpio configurations
Posted by Kathiravan Thirumoorthy 9 months ago 
On 3/18/2025 12:19 PM, Manikanta Mylavarapu wrote:
> Update the bias configuration for UART1 TX and RX pins to ensure correct
> settings for RDP466.
>
> Additionally, move the UART1 GPIO configurations from the common .dtsi
> file to the RDP-specific .dts files to account for differing bias
> configurations across RDPs of IPQ5424.
>
> Fixes: 1a91d2a6021e ("arm64: dts: qcom: add IPQ5424 SoC and rdp466 board support")
> Signed-off-by: Manikanta Mylavarapu <quic_mmanikan@quicinc.com>
Reviewed-by: Kathiravan Thirumoorthy 
<kathiravan.thirumoorthy@oss.qualcomm.com>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.