[PATCH v1 0/5] NMI warning and debug improvements

Ian Rogers posted 5 patches 9 months ago
There is a newer version of this series
tools/perf/builtin-record.c    |  9 ++++---
tools/perf/util/evlist.c       | 32 +++++++++++++++---------
tools/perf/util/evlist.h       |  3 ++-
tools/perf/util/parse-events.c | 16 +++++++++---
tools/perf/util/stat-display.c | 45 ++++++++++------------------------
tools/perf/util/stat.h         |  1 -
6 files changed, 55 insertions(+), 51 deletions(-)
[PATCH v1 0/5] NMI warning and debug improvements
Posted by Ian Rogers 9 months ago
The NMI warning wouldn't fire even if all the events were for one PMU
type. Remove a nearby, and no longer useful, mixed hardware event
group function. Improve the evlist to string function and dump it in
verbose mode after the reordered events warning.

As commonly happens legacy events like instructions will be uniquified
to hybrid events like cpu_core/instructions/, even though the
encodings differ. To make this correct either:
https://lore.kernel.org/lkml/20250312211623.2495798-1-irogers@google.com/
or:
https://lore.kernel.org/linux-perf-users/20250109222109.567031-1-irogers@google.com/
needs merging.

Ian Rogers (5):
  perf stat: Better hybrid support for the NMI watchdog warning
  perf stat: Remove print_mixed_hw_group_error
  perf evlist: Refactor evlist__scnprintf_evsels
  perf evlist: Add groups to evlist__format_evsels
  perf parse-events: Add debug dump of evlist if reordered

 tools/perf/builtin-record.c    |  9 ++++---
 tools/perf/util/evlist.c       | 32 +++++++++++++++---------
 tools/perf/util/evlist.h       |  3 ++-
 tools/perf/util/parse-events.c | 16 +++++++++---
 tools/perf/util/stat-display.c | 45 ++++++++++------------------------
 tools/perf/util/stat.h         |  1 -
 6 files changed, 55 insertions(+), 51 deletions(-)

-- 
2.49.0.rc1.451.g8f38331e32-goog
Re: [PATCH v1 0/5] NMI warning and debug improvements
Posted by Ian Rogers 8 months, 2 weeks ago
On Mon, Mar 17, 2025 at 9:14 PM Ian Rogers <irogers@google.com> wrote:
>
> The NMI warning wouldn't fire even if all the events were for one PMU
> type. Remove a nearby, and no longer useful, mixed hardware event
> group function. Improve the evlist to string function and dump it in
> verbose mode after the reordered events warning.
>
> As commonly happens legacy events like instructions will be uniquified
> to hybrid events like cpu_core/instructions/, even though the
> encodings differ. To make this correct either:
> https://lore.kernel.org/lkml/20250312211623.2495798-1-irogers@google.com/
> or:
> https://lore.kernel.org/linux-perf-users/20250109222109.567031-1-irogers@google.com/
> needs merging.
>
> Ian Rogers (5):
>   perf stat: Better hybrid support for the NMI watchdog warning
>   perf stat: Remove print_mixed_hw_group_error
>   perf evlist: Refactor evlist__scnprintf_evsels
>   perf evlist: Add groups to evlist__format_evsels
>   perf parse-events: Add debug dump of evlist if reordered

Ping.

Thanks,
Ian

>  tools/perf/builtin-record.c    |  9 ++++---
>  tools/perf/util/evlist.c       | 32 +++++++++++++++---------
>  tools/perf/util/evlist.h       |  3 ++-
>  tools/perf/util/parse-events.c | 16 +++++++++---
>  tools/perf/util/stat-display.c | 45 ++++++++++------------------------
>  tools/perf/util/stat.h         |  1 -
>  6 files changed, 55 insertions(+), 51 deletions(-)
>
> --
> 2.49.0.rc1.451.g8f38331e32-goog
>