[v1] arm64: dts: x1e001de-devkit: USB retimers related fixes

[PATCH 2/2] arm64: dts: qcom: x1e001de-devkit: Fix pin config for USB0 retimer vregs

Posted by Abel Vesa 9 months ago

Describe the missing power source, bias and direction for each of the USB0
retimer gpio-controlled voltage regulators related pin configuration.

Fixes: 019e1ee32fec ("arm64: dts: qcom: x1e001de-devkit: Enable external DP support")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
index 902335396c586a991c4a2de19906b039d887780f..8e88e00c335a05d0d36b4b08b85df82f38ef4355 100644
--- a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
+++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
@@ -1039,6 +1039,10 @@ rtmr0_default: rtmr0-reset-n-active-state {
 	usb0_3p3_reg_en: usb0-3p3-reg-en-state {
 		pins = "gpio11";
 		function = "normal";
+		power-source = <1>; /* 1.8V */
+		bias-disable;
+		input-disable;
+		output-enable;
 	};
 };
 
@@ -1046,6 +1050,10 @@ &pmc8380_5_gpios {
 	usb0_pwr_1p15_en: usb0-pwr-1p15-en-state {
 		pins = "gpio8";
 		function = "normal";
+		power-source = <1>; /* 1.8V */
+		bias-disable;
+		input-disable;
+		output-enable;
 	};
 };
 
@@ -1053,6 +1061,10 @@ &pm8550ve_9_gpios {
 	usb0_1p8_reg_en: usb0-1p8-reg-en-state {
 		pins = "gpio8";
 		function = "normal";
+		power-source = <1>; /* 1.8V */
+		bias-disable;
+		input-disable;
+		output-enable;
 	};
 };
 

-- 
2.34.1

Re: [PATCH 2/2] arm64: dts: qcom: x1e001de-devkit: Fix pin config for USB0 retimer vregs

Posted by Konrad Dybcio 8 months, 2 weeks ago

On 3/18/25 4:50 PM, Abel Vesa wrote:
> Describe the missing power source, bias and direction for each of the USB0
> retimer gpio-controlled voltage regulators related pin configuration.
> 
> Fixes: 019e1ee32fec ("arm64: dts: qcom: x1e001de-devkit: Enable external DP support")
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> index 902335396c586a991c4a2de19906b039d887780f..8e88e00c335a05d0d36b4b08b85df82f38ef4355 100644
> --- a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> +++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> @@ -1039,6 +1039,10 @@ rtmr0_default: rtmr0-reset-n-active-state {
>  	usb0_3p3_reg_en: usb0-3p3-reg-en-state {
>  		pins = "gpio11";
>  		function = "normal";
> +		power-source = <1>; /* 1.8V */

Not sure if I'm a fan of these comments but sure

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH 2/2] arm64: dts: qcom: x1e001de-devkit: Fix pin config for USB0 retimer vregs

Posted by Johan Hovold 8 months, 1 week ago

On Sat, Apr 05, 2025 at 01:08:46AM +0200, Konrad Dybcio wrote:
> On 3/18/25 4:50 PM, Abel Vesa wrote:
> > Describe the missing power source, bias and direction for each of the USB0
> > retimer gpio-controlled voltage regulators related pin configuration.
> > 
> > Fixes: 019e1ee32fec ("arm64: dts: qcom: x1e001de-devkit: Enable external DP support")
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> >  arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> > index 902335396c586a991c4a2de19906b039d887780f..8e88e00c335a05d0d36b4b08b85df82f38ef4355 100644
> > --- a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> > +++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> > @@ -1039,6 +1039,10 @@ rtmr0_default: rtmr0-reset-n-active-state {
> >  	usb0_3p3_reg_en: usb0-3p3-reg-en-state {
> >  		pins = "gpio11";
> >  		function = "normal";
> > +		power-source = <1>; /* 1.8V */
> 
> Not sure if I'm a fan of these comments but sure

How come? 

Due to the incomplete bindings for these PMICs this is currently the
only way we have to document this information. And AFAIU the voltage
mapping can even differ from pin to pin on the same device.

I would prefer to see a space before the SI unit though.

Johan

Re: [PATCH 2/2] arm64: dts: qcom: x1e001de-devkit: Fix pin config for USB0 retimer vregs

Posted by Abel Vesa 7 months, 4 weeks ago

On 25-04-11 13:58:40, Johan Hovold wrote:
> On Sat, Apr 05, 2025 at 01:08:46AM +0200, Konrad Dybcio wrote:
> > On 3/18/25 4:50 PM, Abel Vesa wrote:
> > > Describe the missing power source, bias and direction for each of the USB0
> > > retimer gpio-controlled voltage regulators related pin configuration.
> > > 
> > > Fixes: 019e1ee32fec ("arm64: dts: qcom: x1e001de-devkit: Enable external DP support")
> > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > > ---
> > >  arch/arm64/boot/dts/qcom/x1e001de-devkit.dts | 12 ++++++++++++
> > >  1 file changed, 12 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> > > index 902335396c586a991c4a2de19906b039d887780f..8e88e00c335a05d0d36b4b08b85df82f38ef4355 100644
> > > --- a/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> > > +++ b/arch/arm64/boot/dts/qcom/x1e001de-devkit.dts
> > > @@ -1039,6 +1039,10 @@ rtmr0_default: rtmr0-reset-n-active-state {
> > >  	usb0_3p3_reg_en: usb0-3p3-reg-en-state {
> > >  		pins = "gpio11";
> > >  		function = "normal";
> > > +		power-source = <1>; /* 1.8V */
> > 
> > Not sure if I'm a fan of these comments but sure
> 
> How come? 
> 
> Due to the incomplete bindings for these PMICs this is currently the
> only way we have to document this information. And AFAIU the voltage
> mapping can even differ from pin to pin on the same device.

I agree.

> 
> I would prefer to see a space before the SI unit though.

Will do.

> 
> Johan

Thanks for reviewing!

Abel