ARM: dts: qcom-msm8960: add missing clocks to the timer node

[PATCH] ARM: dts: qcom-msm8960: add missing clocks to the timer node

Posted by Rudraksha Gupta 9 months ago

In order to fix DT schema warning and describe hardware properly, add
missing sleep clock to the timer node.

Solved by Dmitry Baryshkov on the APQ8064 SoC
Link: https://lore.kernel.org/all/20250318-fix-nexus-4-v2-6-bcedd1406790@oss.qualcomm.com/

Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
---
Running the following no longer returns any errors:
make ARCH=arm CHECK_DTBS=y qcom/qcom-msm8960-cdp.dtb
make ARCH=arm CHECK_DTBS=y qcom/qcom-msm8960-samsung-expressatt.dtb
---
 arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
index 865fe7cc3951..06b3fa5e1acf 100644
--- a/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
+++ b/arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
@@ -112,6 +112,8 @@ timer@200a000 {
 				     <GIC_PPI 3 0x301>;
 			reg = <0x0200a000 0x100>;
 			clock-frequency = <27000000>;
+			clocks = <&sleep_clk>;
+			clock-names = "sleep";
 			cpu-offset = <0x80000>;
 		};
 

---
base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04
change-id: 20250318-expressatt-solve-dts-errors-359f9d91c86c

Best regards,
-- 
Rudraksha Gupta <guptarud@gmail.com>

Re: [PATCH] ARM: dts: qcom-msm8960: add missing clocks to the timer node

Posted by Bjorn Andersson 7 months ago

On Tue, 18 Mar 2025 22:10:47 -0700, Rudraksha Gupta wrote:
> In order to fix DT schema warning and describe hardware properly, add
> missing sleep clock to the timer node.
> 
> Solved by Dmitry Baryshkov on the APQ8064 SoC
> Link: https://lore.kernel.org/all/20250318-fix-nexus-4-v2-6-bcedd1406790@oss.qualcomm.com/
> 
> 
> [...]

Applied, thanks!

[1/1] ARM: dts: qcom-msm8960: add missing clocks to the timer node
      commit: b81dcdad43daf10f79ae149826fff9e467b95e8b

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH] ARM: dts: qcom-msm8960: add missing clocks to the timer node

Posted by Dmitry Baryshkov 9 months ago

On Tue, Mar 18, 2025 at 10:10:47PM -0700, Rudraksha Gupta wrote:
> In order to fix DT schema warning and describe hardware properly, add
> missing sleep clock to the timer node.
> 
> Solved by Dmitry Baryshkov on the APQ8064 SoC
> Link: https://lore.kernel.org/all/20250318-fix-nexus-4-v2-6-bcedd1406790@oss.qualcomm.com/
> 
> Signed-off-by: Rudraksha Gupta <guptarud@gmail.com>
> ---
> Running the following no longer returns any errors:
> make ARCH=arm CHECK_DTBS=y qcom/qcom-msm8960-cdp.dtb
> make ARCH=arm CHECK_DTBS=y qcom/qcom-msm8960-samsung-expressatt.dtb
> ---
>  arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry