genirq: use sysfs_emit()/sysfs_emit_at() instead of scnprintf().

[PATCH linux-next] genirq: use sysfs_emit()/sysfs_emit_at() instead of scnprintf().

Posted by xie.ludan@zte.com.cn 9 months ago

From: XieLudan <xie.ludan@zte.com.cn>

Follow the advice in Documentation/filesystems/sysfs.rst: show() should
only use sysfs_emit() or sysfs_emit_at() when formatting the value to be
returned to user space.

Signed-off-by: XieLudan <xie.ludan@zte.com.cn>
---
 kernel/irq/irqdesc.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/kernel/irq/irqdesc.c b/kernel/irq/irqdesc.c
index 287830739783..8d1f4ecfe880 100644
--- a/kernel/irq/irqdesc.c
+++ b/kernel/irq/irqdesc.c
@@ -257,11 +257,11 @@ static ssize_t per_cpu_count_show(struct kobject *kobj,
 	for_each_possible_cpu(cpu) {
 		unsigned int c = irq_desc_kstat_cpu(desc, cpu);
 
-		ret += scnprintf(buf + ret, PAGE_SIZE - ret, "%s%u", p, c);
+		ret += sysfs_emit_at(buf, ret, "%s%u", p, c);
 		p = ",";
 	}
 
-	ret += scnprintf(buf + ret, PAGE_SIZE - ret, "\n");
+	ret += sysfs_emit_at(buf, ret, "\n");
 	return ret;
 }
 IRQ_ATTR_RO(per_cpu_count);
@@ -274,7 +274,7 @@ static ssize_t chip_name_show(struct kobject *kobj,
 
 	raw_spin_lock_irq(&desc->lock);
 	if (desc->irq_data.chip && desc->irq_data.chip->name) {
-		ret = scnprintf(buf, PAGE_SIZE, "%s\n",
+		ret = sysfs_emit(buf, "%s\n",
 				desc->irq_data.chip->name);
 	}
 	raw_spin_unlock_irq(&desc->lock);
@@ -337,7 +337,7 @@ static ssize_t name_show(struct kobject *kobj,
 
 	raw_spin_lock_irq(&desc->lock);
 	if (desc->name)
-		ret = scnprintf(buf, PAGE_SIZE, "%s\n", desc->name);
+		ret = sysfs_emit(buf, "%s\n", desc->name);
 	raw_spin_unlock_irq(&desc->lock);
 
 	return ret;
@@ -354,14 +354,14 @@ static ssize_t actions_show(struct kobject *kobj,
 
 	raw_spin_lock_irq(&desc->lock);
 	for_each_action_of_desc(desc, action) {
-		ret += scnprintf(buf + ret, PAGE_SIZE - ret, "%s%s",
+		ret += sysfs_emit_at(buf， ret, "%s%s",
 				 p, action->name);
 		p = ",";
 	}
 	raw_spin_unlock_irq(&desc->lock);
 
 	if (ret)
-		ret += scnprintf(buf + ret, PAGE_SIZE - ret, "\n");
+		ret += sysfs_emit_at(buf, ret, "\n");
 
 	return ret;
 }
-- 
2.25.1

Re: [PATCH linux-next] genirq: use sysfs_emit()/sysfs_emit_at() instead of scnprintf().

Posted by Jiri Slaby 9 months ago

Are you a bot?

On 17. 03. 25, 7:54, xie.ludan@zte.com.cn wrote:
> From: XieLudan <xie.ludan@zte.com.cn>
> 
> 
> Follow the advice in Documentation/filesystems/sysfs.rst: show() should
> 
> only use sysfs_emit() or sysfs_emit_at() when formatting the value to be
> 
> returned to user space.


-- 
js
suse labs

Re: [PATCH linux-next] genirq: use sysfs_emit()/sysfs_emit_at() instead of scnprintf().

Posted by xie.ludan@zte.com.cn 9 months ago

> Are you a bot?

> On 17. 03. 25, 7:54, xie.ludan@zte.com.cn wrote:> From: XieLudan <xie.ludan@zte.com.cn>
> > 
> > 
> > Follow the advice in Documentation/filesystems/sysfs.rst: show() should
> > 
> > only use sysfs_emit() or sysfs_emit_at() when formatting the value to be
> > 
> > returned to user space.

I'm sorry if I make any mistakes. I'm just starting to learn how to submit patches to the community and I'm still learning the proper submission process. 
I would greatly appreciate your patience and guidance during this learning phase. Thank you for your understanding!

Best Regards
Xie Ludan

Original

From: jirislaby <jirislaby@kernel.org>
To: Xie Ludan00297061;tglx <tglx@linutronix.de>;
Cc: linux-kernel <linux-kernel@vger.kernel.org>;Xu Xin10311587;Yang Yang10192021;
Date: 2025/03/17 15:15
Subject: Re: [PATCH linux-next] genirq: use sysfs_emit()/sysfs_emit_at() instead of scnprintf().

Are you a bot?

On 17. 03. 25, 7:54, xie.ludan@zte.com.cn wrote:
> From: XieLudan <xie.ludan@zte.com.cn> 
>  
>  
> Follow the advice in Documentation/filesystems/sysfs.rst: show() should
>  
> only use sysfs_emit() or sysfs_emit_at() when formatting the value to be
>  
> returned to user space.

--  
js
suse labs

Re: [PATCH linux-next] genirq: use sysfs_emit()/sysfs_emit_at() instead of scnprintf().

Posted by Krzysztof Kozlowski 9 months ago

On 17/03/2025 09:22, xie.ludan@zte.com.cn wrote:
>> Are you a bot?
> 
>> On 17. 03. 25, 7:54, xie.ludan@zte.com.cn wrote:> From: XieLudan <xie.ludan@zte.com.cn>
>>>
>>>
>>> Follow the advice in Documentation/filesystems/sysfs.rst: show() should
>>>
>>> only use sysfs_emit() or sysfs_emit_at() when formatting the value to be
>>>
>>> returned to user space.
> 
> I'm sorry if I make any mistakes. I'm just starting to learn how to submit patches to the community and I'm still learning the proper submission process. 
> I would greatly appreciate your patience and guidance during this learning phase. Thank you for your understanding!

So you decided to learn by sending 60 patches last two/three days?
Several of these contributions received feedback already but you never
responded to that.

If you want to learn, then send one patch and learn from it.

Sending 60 patches and making the same mistakes, like not even building
the code, means huge review effort on the community side.

Best regards,
Krzysztof