[PATCH][next] PCI: brcmstb: make const read-only arrays static

Colin Ian King posted 1 patch 9 months ago
drivers/pci/controller/pcie-brcmstb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH][next] PCI: brcmstb: make const read-only arrays static
Posted by Colin Ian King 9 months ago
Don't populate the const read-only arrays data and regs on the stack at
run time, instead make them static.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/pci/controller/pcie-brcmstb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
index 8b2b099e81eb..d258b571f642 100644
--- a/drivers/pci/controller/pcie-brcmstb.c
+++ b/drivers/pci/controller/pcie-brcmstb.c
@@ -832,8 +832,8 @@ static int brcm_pcie_perst_set_generic(struct brcm_pcie *pcie, u32 val)
 
 static int brcm_pcie_post_setup_bcm2712(struct brcm_pcie *pcie)
 {
-	const u16 data[] = { 0x50b9, 0xbda1, 0x0094, 0x97b4, 0x5030, 0x5030, 0x0007 };
-	const u8 regs[] = { 0x16, 0x17, 0x18, 0x19, 0x1b, 0x1c, 0x1e };
+	static const u16 data[] = { 0x50b9, 0xbda1, 0x0094, 0x97b4, 0x5030, 0x5030, 0x0007 };
+	static const u8 regs[] = { 0x16, 0x17, 0x18, 0x19, 0x1b, 0x1c, 0x1e };
 	int ret, i;
 	u32 tmp;
 
-- 
2.47.2
Re: [PATCH][next] PCI: brcmstb: make const read-only arrays static
Posted by Krzysztof Wilczyński 8 months, 4 weeks ago
Hello,

> Don't populate the const read-only arrays data and regs on the stack at
> run time, instead make them static.

Applied to controller/brcmstb, thank you!

	Krzysztof
Re: [PATCH][next] PCI: brcmstb: make const read-only arrays static
Posted by Florian Fainelli 9 months ago
On 3/17/25 07:34, Colin Ian King wrote:
> Don't populate the const read-only arrays data and regs on the stack at
> run time, instead make them static.
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
-- 
Florian