dma-buf: heap: Replace nested max() with single max3()

[PATCH v4] dma-buf: heap: Replace nested max() with single max3()

Posted by feng.wei8@zte.com.cn 9 months ago

From: FengWei <feng.wei8@zte.com.cn>

Use max3() macro instead of nesting max() to simplify the return
statement.

Signed-off-by: FengWei <feng.wei8@zte.com.cn>
---
v3 -> v4
fix the format of this patch.
 drivers/dma-buf/dma-heap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma-buf/dma-heap.c b/drivers/dma-buf/dma-heap.c
index 3cbe87d4a464..96cb9ab5731a 100644
--- a/drivers/dma-buf/dma-heap.c
+++ b/drivers/dma-buf/dma-heap.c
@@ -147,7 +147,7 @@ static long dma_heap_ioctl(struct file *file, unsigned int ucmd,
 		in_size = 0;
 	if ((ucmd & kcmd & IOC_OUT) == 0)
 		out_size = 0;
-	ksize = max(max(in_size, out_size), drv_size);
+	ksize = max3(in_size, out_size, drv_size);

 	/* If necessary, allocate buffer for ioctl argument */
 	if (ksize > sizeof(stack_kdata)) {
-- 
2.25.1

Re: [PATCH v4] dma-buf: heap: Replace nested max() with single max3()

Posted by Krzysztof Kozlowski 9 months ago

On 17/03/2025 03:37, feng.wei8@zte.com.cn wrote:
> From: FengWei <feng.wei8@zte.com.cn>
> 
> Use max3() macro instead of nesting max() to simplify the return
> statement.
> 
> Signed-off-by: FengWei <feng.wei8@zte.com.cn>
> ---
> v3 -> v4
> fix the format of this patch.
>  drivers/dma-buf/dma-heap.c | 2 +-
You sent five versions per day of the same patch.

Look what was in v3:

	v2 -> v3
	fix the format of this patch

So you are doing the same over and over and sending it to us?

Srsly, ZTE, slow down and be sure you follow the process BEFORE you send
flood of patches like that and learn on the go.

Best regards,
Krzysztof