On 3/26/2025 10:58 PM, Jorge Ramirez wrote:
> On 17/03/25 11:11:47, Prasad Kumpatla wrote:
>> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>>
>> Add nodes for WSA8830 speakers amplifier on qcs6490-rb3gen2 board.
>>
>> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com>
>> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 27 ++++++++++++++++++++
>> 1 file changed, 27 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> index 23dea375c213..a1a3df77ad57 100644
>> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
>> @@ -870,6 +870,33 @@ &sdhc_2 {
>> status = "okay";
>> };
>>
>> +&swr2 {
>> + qcom,din-ports = <0>;
>> + qcom,dout-ports = <8>;
>
> are these number of ports correct? from my unit tests, 8 seems to be out
> of bounds (soundwire probe error)
ACK,
Will fix it in next patchset version.
>
>> +
>> + left_spkr: speaker@0,1 {
>> + compatible = "sdw10217020200";
>> + reg = <0 1>;
>> + powerdown-gpios = <&tlmm 158 GPIO_ACTIVE_LOW>;
>> + #sound-dai-cells = <0>;
>> + sound-name-prefix = "SpkrLeft";
>> + #thermal-sensor-cells = <0>;
>> + vdd-supply = <&vreg_l18b_1p8>;
>> + qcom,port-mapping = <1 2 3 7>;
>> + };
>> +
>> + right_spkr: speaker@0,2 {
>> + compatible = "sdw10217020200";
>> + reg = <0 2>;
>> + powerdown-gpios = <&tlmm 158 GPIO_ACTIVE_LOW>;
>> + #sound-dai-cells = <0>;
>> + sound-name-prefix = "SpkrRight";
>> + #thermal-sensor-cells = <0>;
>> + vdd-supply = <&vreg_l18b_1p8>;
>> + qcom,port-mapping = <4 5 6 8>;
>> + };
>> +};
>> +
>
> also, should we enable the soundwire controller?
ACK,
yes need to enable soundwire controller, Will take care to enable in
next patchset version.
Thanks,
Prasad
>
>> &tlmm {
>> gpio-reserved-ranges = <32 2>, /* ADSP */
>> <48 4>; /* NFC */
>> --
>> 2.34.1
>>