arch/arm/boot/dts/qcom/Makefile | 1 + .../boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dts | 341 +++++++++++++++++++++ 2 files changed, 342 insertions(+)
From: Ivan Belokobylskiy <belokobylskij@gmail.com>
Add initial support for LG Nexus 4 (mako).
Features currently working: regulators, eMMC, and volume keys.
Signed-off-by: Ivan Belokobylskiy <belokobylskij@gmail.com>
Co-developed-by: David Heidelberg <david@ixit.cz>
Signed-off-by: David Heidelberg <david@ixit.cz>
---
Changes in v5:
- Sorted nodes alphabetically.
- Link to v4: https://lore.kernel.org/r/20250311-lg-nexus4-mako-v4-1-3916c8ec7edb@ixit.cz
Changes in v4:
- Sorted regulators and added regulators compatible.
- Corrected pmic include and references.
- Moved &rpm outside of / node.
- Moved and simplify pm8921 keypad.
- Added chasis-type.
- Dropped incomplete WiFi node, will be provided in future
contributions.
- Link to v3: https://lore.kernel.org/r/20250309-lg-nexus4-mako-v3-1-1dc2807df296@ixit.cz
Changes in v3:
- rebased against next-20250307
- dropped backlight until driver gets converted to DT
Changes in v2:
- lge vendor doesn't exist anymore, rename to lg
- sdcc@ to mmc@ to comply with dt-schema
---
arch/arm/boot/dts/qcom/Makefile | 1 +
.../boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dts | 341 +++++++++++++++++++++
2 files changed, 342 insertions(+)
diff --git a/arch/arm/boot/dts/qcom/Makefile b/arch/arm/boot/dts/qcom/Makefile
index f06c6d425e91dd73c2b453d15543d95bd32383b9..0c1d116f6e84f76994aa8c8286350bdcd1657a42 100644
--- a/arch/arm/boot/dts/qcom/Makefile
+++ b/arch/arm/boot/dts/qcom/Makefile
@@ -12,6 +12,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
qcom-apq8064-ifc6410.dtb \
qcom-apq8064-sony-xperia-lagan-yuga.dtb \
qcom-apq8064-asus-nexus7-flo.dtb \
+ qcom-apq8064-lg-nexus4-mako.dtb \
qcom-apq8074-dragonboard.dtb \
qcom-apq8084-ifc6540.dtb \
qcom-apq8084-mtp.dtb \
diff --git a/arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dts b/arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dts
new file mode 100644
index 0000000000000000000000000000000000000000..5710450faabf34fa5991d8803a2369cfbb09e4ea
--- /dev/null
+++ b/arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dts
@@ -0,0 +1,341 @@
+// SPDX-License-Identifier: GPL-2.0-only
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/input/input.h>
+#include <dt-bindings/mfd/qcom-rpm.h>
+#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
+
+#include "qcom-apq8064-v2.0.dtsi"
+#include "pm8821.dtsi"
+#include "pm8921.dtsi"
+
+/ {
+ model = "LG Nexus 4 (mako)";
+ compatible = "lg,nexus4-mako", "qcom,apq8064";
+ chassis-type = "handset";
+
+ aliases {
+ serial0 = &gsbi7_serial;
+ serial1 = &gsbi6_serial;
+ serial2 = &gsbi4_serial;
+ };
+
+ chosen {
+ stdout-path = "serial2:115200n8";
+ };
+
+ battery_cell: battery-cell {
+ compatible = "simple-battery";
+ constant-charge-current-max-microamp = <900000>;
+ operating-range-celsius = <0 45>;
+ };
+
+ reserved-memory {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ ramoops@88d00000{
+ compatible = "ramoops";
+ reg = <0x88d00000 0x100000>;
+ record-size = <0x20000>;
+ console-size = <0x20000>;
+ ftrace-size = <0x20000>;
+ };
+ };
+};
+
+&gsbi1 {
+ qcom,mode = <GSBI_PROT_I2C>;
+
+ status = "okay";
+};
+
+&gsbi1_i2c {
+ clock-frequency = <200000>;
+
+ status = "okay";
+};
+
+&gsbi4 {
+ qcom,mode = <GSBI_PROT_I2C_UART>;
+
+ status = "okay";
+};
+
+&gsbi4_serial {
+ status = "okay";
+};
+
+&pm8821 {
+ interrupts-extended = <&tlmm_pinmux 76 IRQ_TYPE_LEVEL_LOW>;
+};
+
+&pm8921 {
+ interrupts-extended = <&tlmm_pinmux 74 IRQ_TYPE_LEVEL_LOW>;
+};
+
+&pm8921_keypad {
+ linux,keymap = <
+ MATRIX_KEY(0, 0, KEY_VOLUMEDOWN)
+ MATRIX_KEY(0, 1, KEY_VOLUMEUP)
+ >;
+
+ keypad,num-rows = <1>;
+ keypad,num-columns = <5>;
+
+ status = "okay";
+};
+
+&rpm {
+ regulators {
+ compatible = "qcom,rpm-pm8921-regulators";
+
+ vdd_l1_l2_l12_l18-supply = <&pm8921_s4>;
+ vdd_l24-supply = <&pm8921_s1>;
+ vdd_l25-supply = <&pm8921_s1>;
+ vdd_l26-supply = <&pm8921_s7>;
+ vdd_l27-supply = <&pm8921_s7>;
+ vdd_l28-supply = <&pm8921_s7>;
+ vin_lvs1_3_6-supply = <&pm8921_s4>;
+ vin_lvs2-supply = <&pm8921_s1>;
+ vin_lvs4_5_7-supply = <&pm8921_s4>;
+
+ pm8921_l1: l1 {
+ regulator-min-microvolt = <1100000>;
+ regulator-max-microvolt = <1100000>;
+ regulator-always-on;
+ bias-pull-down;
+ };
+
+ /* mipi_dsi.1-dsi1_pll_vdda */
+ pm8921_l2: l2 {
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ bias-pull-down;
+ };
+
+ /* msm_otg-HSUSB_3p3 */
+ pm8921_l3: l3 {
+ regulator-min-microvolt = <3075000>;
+ regulator-max-microvolt = <3500000>;
+ bias-pull-down;
+ };
+
+ /* msm_otg-HSUSB_1p8 */
+ pm8921_l4: l4 {
+ regulator-always-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
+ /* msm_sdcc.1-sdc_vdd */
+ pm8921_l5: l5 {
+ regulator-min-microvolt = <2950000>;
+ regulator-max-microvolt = <2950000>;
+ bias-pull-down;
+ };
+
+ /* earjack_debug */
+ pm8921_l6: l6 {
+ regulator-min-microvolt = <3000000>;
+ regulator-max-microvolt = <3000000>;
+ bias-pull-down;
+ };
+
+ /* mipi_dsi.1-dsi_vci */
+ pm8921_l8: l8 {
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <3000000>;
+ bias-pull-down;
+ };
+
+ /* wcnss_wlan.0-iris_vddpa */
+ pm8921_l10: l10 {
+ regulator-min-microvolt = <2900000>;
+ regulator-max-microvolt = <2900000>;
+ bias-pull-down;
+ };
+
+ /* mipi_dsi.1-dsi1_avdd */
+ pm8921_l11: l11 {
+ regulator-min-microvolt = <2850000>;
+ regulator-max-microvolt = <2850000>;
+ bias-pull-down;
+ };
+
+ /* touch_vdd */
+ pm8921_l15: l15 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <2950000>;
+ bias-pull-down;
+ };
+
+ /* slimport_dvdd */
+ pm8921_l18: l18 {
+ regulator-min-microvolt = <1100000>;
+ regulator-max-microvolt = <1100000>;
+ bias-pull-down;
+ };
+
+ /* touch_io */
+ pm8921_l22: l22 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ bias-pull-down;
+ };
+
+ /*
+ * mipi_dsi.1-dsi_vddio
+ * pil_qdsp6v4.1-pll_vdd
+ * pil_qdsp6v4.2-pll_vdd
+ * msm_ehci_host.0-HSUSB_1p8
+ * msm_ehci_host.1-HSUSB_1p8
+ */
+ pm8921_l23: l23 {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ bias-pull-down;
+ };
+
+ /*
+ * tabla2x-slim-CDC_VDDA_A_1P2V
+ * tabla2x-slim-VDDD_CDC_D
+ */
+ pm8921_l24: l24 {
+ regulator-min-microvolt = <750000>;
+ regulator-max-microvolt = <1150000>;
+ bias-pull-down;
+ };
+
+ pm8921_l25: l25 {
+ regulator-min-microvolt = <1250000>;
+ regulator-max-microvolt = <1250000>;
+ regulator-always-on;
+ bias-pull-down;
+ };
+
+ pm8921_l26: l26 {
+ regulator-min-microvolt = <375000>;
+ regulator-max-microvolt = <1050000>;
+ regulator-always-on;
+ bias-pull-down;
+ };
+
+ pm8921_l27: l27 {
+ regulator-min-microvolt = <1100000>;
+ regulator-max-microvolt = <1100000>;
+ };
+
+ pm8921_l28: l28 {
+ regulator-min-microvolt = <1050000>;
+ regulator-max-microvolt = <1050000>;
+ bias-pull-down;
+ };
+
+ /* wcnss_wlan.0-iris_vddio */
+ pm8921_lvs1: lvs1 {
+ bias-pull-down;
+ };
+
+ /* wcnss_wlan.0-iris_vdddig */
+ pm8921_lvs2: lvs2 {
+ bias-pull-down;
+ };
+
+ pm8921_lvs3: lvs3 {
+ bias-pull-down;
+ };
+
+ pm8921_lvs4: lvs4 {
+ bias-pull-down;
+ };
+
+ pm8921_lvs5: lvs5 {
+ bias-pull-down;
+ };
+
+ /* mipi_dsi.1-dsi_iovcc */
+ pm8921_lvs6: lvs6 {
+ bias-pull-down;
+ };
+
+ /*
+ * pil_riva-pll_vdd
+ * lvds.0-lvds_vdda
+ * mipi_dsi.1-dsi1_vddio
+ * hdmi_msm.0-hdmi_vdda
+ */
+ pm8921_lvs7: lvs7 {
+ bias-pull-down;
+ };
+
+ pm8921_ncp: ncp {
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ qcom,switch-mode-frequency = <1600000>;
+ };
+
+ /* Buck SMPS */
+ pm8921_s1: s1 {
+ regulator-always-on;
+ regulator-min-microvolt = <1225000>;
+ regulator-max-microvolt = <1225000>;
+ qcom,switch-mode-frequency = <3200000>;
+ bias-pull-down;
+ };
+
+ pm8921_s2: s2 {
+ regulator-min-microvolt = <1300000>;
+ regulator-max-microvolt = <1300000>;
+ qcom,switch-mode-frequency = <1600000>;
+ bias-pull-down;
+ };
+
+ /* msm otg HSUSB_VDDCX */
+ pm8921_s3: s3 {
+ regulator-min-microvolt = <500000>;
+ regulator-max-microvolt = <1150000>;
+ qcom,switch-mode-frequency = <4800000>;
+ bias-pull-down;
+ };
+
+ /*
+ * msm_sdcc.1-sdc-vdd_io
+ * tabla2x-slim-CDC_VDDA_RX
+ * tabla2x-slim-CDC_VDDA_TX
+ * tabla2x-slim-CDC_VDD_CP
+ * tabla2x-slim-VDDIO_CDC
+ */
+ pm8921_s4: s4 {
+ regulator-always-on;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ qcom,switch-mode-frequency = <1600000>;
+ bias-pull-down;
+ qcom,force-mode = <QCOM_RPM_FORCE_MODE_AUTO>;
+ };
+
+ /*
+ * supply vdd_l26, vdd_l27, vdd_l28
+ */
+ pm8921_s7: s7 {
+ regulator-min-microvolt = <1300000>;
+ regulator-max-microvolt = <1300000>;
+ qcom,switch-mode-frequency = <3200000>;
+ };
+
+ pm8921_s8: s8 {
+ regulator-min-microvolt = <2200000>;
+ regulator-max-microvolt = <2200000>;
+ qcom,switch-mode-frequency = <1600000>;
+ };
+ };
+};
+
+/* eMMC */
+&sdcc1 {
+ vmmc-supply = <&pm8921_l5>;
+ vqmmc-supply = <&pm8921_s4>;
+
+ status = "okay";
+};
---
base-commit: 0a2f889128969dab41861b6e40111aa03dc57014
change-id: 20250309-lg-nexus4-mako-da0833885b26
Best regards,
--
David Heidelberg <david@ixit.cz>On Sun, 16 Mar 2025 23:16:55 +0100, David Heidelberg wrote: > From: Ivan Belokobylskiy <belokobylskij@gmail.com> > > Add initial support for LG Nexus 4 (mako). > > Features currently working: regulators, eMMC, and volume keys. > > Signed-off-by: Ivan Belokobylskiy <belokobylskij@gmail.com> > Co-developed-by: David Heidelberg <david@ixit.cz> > Signed-off-by: David Heidelberg <david@ixit.cz> > --- > Changes in v5: > - Sorted nodes alphabetically. > - Link to v4: https://lore.kernel.org/r/20250311-lg-nexus4-mako-v4-1-3916c8ec7edb@ixit.cz > > Changes in v4: > - Sorted regulators and added regulators compatible. > - Corrected pmic include and references. > - Moved &rpm outside of / node. > - Moved and simplify pm8921 keypad. > - Added chasis-type. > - Dropped incomplete WiFi node, will be provided in future > contributions. > - Link to v3: https://lore.kernel.org/r/20250309-lg-nexus4-mako-v3-1-1dc2807df296@ixit.cz > > Changes in v3: > - rebased against next-20250307 > - dropped backlight until driver gets converted to DT > > Changes in v2: > - lge vendor doesn't exist anymore, rename to lg > - sdcc@ to mmc@ to comply with dt-schema > --- > arch/arm/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dts | 341 +++++++++++++++++++++ > 2 files changed, 342 insertions(+) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/qcom/' for 20250316-lg-nexus4-mako-v5-1-79feae815a85@ixit.cz: arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: hwmutex: 'reg' is a required property from schema $id: http://devicetree.org/schemas/hwlock/qcom-hwspinlock.yaml# arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: hwmutex: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/hwlock/qcom-hwspinlock.yaml# arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: soc: replicator: 'ranges' is a required property from schema $id: http://devicetree.org/schemas/simple-bus.yaml# arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: syscon@1200000: compatible: ['syscon'] is too short from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml# arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: timer@200a000: 'clocks' is a required property from schema $id: http://devicetree.org/schemas/watchdog/qcom-wdt.yaml# arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: sps-sic-non-secure@12100000: compatible: ['syscon'] is too short from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml# arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: rpm@108000: 'clock-controller' does not match any of the regexes: '^regulators(-[01])?$', 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpm.yaml# arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: syscon@5700000: compatible: ['syscon'] is too short from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml# arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: replicator: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/arm/arm,coresight-static-replicator.yaml#
On Mon, Mar 17, 2025 at 09:18:33AM -0500, Rob Herring (Arm) wrote: > > On Sun, 16 Mar 2025 23:16:55 +0100, David Heidelberg wrote: > > From: Ivan Belokobylskiy <belokobylskij@gmail.com> > > > > Add initial support for LG Nexus 4 (mako). > > > > Features currently working: regulators, eMMC, and volume keys. > > > > Signed-off-by: Ivan Belokobylskiy <belokobylskij@gmail.com> > > Co-developed-by: David Heidelberg <david@ixit.cz> > > Signed-off-by: David Heidelberg <david@ixit.cz> > > --- > > Changes in v5: > > - Sorted nodes alphabetically. > > - Link to v4: https://lore.kernel.org/r/20250311-lg-nexus4-mako-v4-1-3916c8ec7edb@ixit.cz > > > > Changes in v4: > > - Sorted regulators and added regulators compatible. > > - Corrected pmic include and references. > > - Moved &rpm outside of / node. > > - Moved and simplify pm8921 keypad. > > - Added chasis-type. > > - Dropped incomplete WiFi node, will be provided in future > > contributions. > > - Link to v3: https://lore.kernel.org/r/20250309-lg-nexus4-mako-v3-1-1dc2807df296@ixit.cz > > > > Changes in v3: > > - rebased against next-20250307 > > - dropped backlight until driver gets converted to DT > > > > Changes in v2: > > - lge vendor doesn't exist anymore, rename to lg > > - sdcc@ to mmc@ to comply with dt-schema > > --- > > arch/arm/boot/dts/qcom/Makefile | 1 + > > .../boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dts | 341 +++++++++++++++++++++ > > 2 files changed, 342 insertions(+) > > > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/qcom/' for 20250316-lg-nexus4-mako-v5-1-79feae815a85@ixit.cz: > > arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: hwmutex: 'reg' is a required property > from schema $id: http://devicetree.org/schemas/hwlock/qcom-hwspinlock.yaml# > arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: hwmutex: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/hwlock/qcom-hwspinlock.yaml# > arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: soc: replicator: 'ranges' is a required property > from schema $id: http://devicetree.org/schemas/simple-bus.yaml# > arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: syscon@1200000: compatible: ['syscon'] is too short > from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml# > arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: timer@200a000: 'clocks' is a required property > from schema $id: http://devicetree.org/schemas/watchdog/qcom-wdt.yaml# > arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: sps-sic-non-secure@12100000: compatible: ['syscon'] is too short > from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml# > arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: rpm@108000: 'clock-controller' does not match any of the regexes: '^regulators(-[01])?$', 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpm.yaml# > arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: syscon@5700000: compatible: ['syscon'] is too short > from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml# > arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: replicator: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/arm/arm,coresight-static-replicator.yaml# As far as I can see, all those are generic rather than being introduced by the new DT. I'll send a set of fixes soon. -- With best wishes Dmitry
> On Mon, Mar 17, 2025 at 09:18:33AM -0500, Rob Herring (Arm) wrote: >> >> On Sun, 16 Mar 2025 23:16:55 +0100, David Heidelberg wrote: >>> From: Ivan Belokobylskiy <belokobylskij@gmail.com> >>> >>> Add initial support for LG Nexus 4 (mako). >>> >>> Features currently working: regulators, eMMC, and volume keys. >>> >>> Signed-off-by: Ivan Belokobylskiy <belokobylskij@gmail.com> >>> Co-developed-by: David Heidelberg <david@ixit.cz> >>> Signed-off-by: David Heidelberg <david@ixit.cz> >>> --- >>> Changes in v5: >>> - Sorted nodes alphabetically. >>> - Link to v4: https://lore.kernel.org/r/20250311-lg-nexus4-mako-v4-1-3916c8ec7edb@ixit.cz >>> >>> Changes in v4: >>> - Sorted regulators and added regulators compatible. >>> - Corrected pmic include and references. >>> - Moved &rpm outside of / node. >>> - Moved and simplify pm8921 keypad. >>> - Added chasis-type. >>> - Dropped incomplete WiFi node, will be provided in future >>> contributions. >>> - Link to v3: https://lore.kernel.org/r/20250309-lg-nexus4-mako-v3-1-1dc2807df296@ixit.cz >>> >>> Changes in v3: >>> - rebased against next-20250307 >>> - dropped backlight until driver gets converted to DT >>> >>> Changes in v2: >>> - lge vendor doesn't exist anymore, rename to lg >>> - sdcc@ to mmc@ to comply with dt-schema >>> --- >>> arch/arm/boot/dts/qcom/Makefile | 1 + >>> .../boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dts | 341 +++++++++++++++++++++ >>> 2 files changed, 342 insertions(+) >>> >> >> >> My bot found new DTB warnings on the .dts files added or changed in this >> series. >> >> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings >> are fixed by another series. Ultimately, it is up to the platform >> maintainer whether these warnings are acceptable or not. No need to reply >> unless the platform maintainer has comments. >> >> If you already ran DT checks and didn't see these error(s), then >> make sure dt-schema is up to date: >> >> pip3 install dtschema --upgrade >> >> >> New warnings running 'make CHECK_DTBS=y for arch/arm/boot/dts/qcom/' for 20250316-lg-nexus4-mako-v5-1-79feae815a85@ixit.cz: >> >> arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: hwmutex: 'reg' is a required property >> from schema $id: http://devicetree.org/schemas/hwlock/qcom-hwspinlock.yaml# >> arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: hwmutex: 'syscon' does not match any of the regexes: 'pinctrl-[0-9]+' >> from schema $id: http://devicetree.org/schemas/hwlock/qcom-hwspinlock.yaml# >> arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: soc: replicator: 'ranges' is a required property >> from schema $id: http://devicetree.org/schemas/simple-bus.yaml# >> arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: syscon@1200000: compatible: ['syscon'] is too short >> from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml# >> arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: timer@200a000: 'clocks' is a required property >> from schema $id: http://devicetree.org/schemas/watchdog/qcom-wdt.yaml# >> arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: sps-sic-non-secure@12100000: compatible: ['syscon'] is too short >> from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml# >> arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: rpm@108000: 'clock-controller' does not match any of the regexes: '^regulators(-[01])?$', 'pinctrl-[0-9]+' >> from schema $id: http://devicetree.org/schemas/soc/qcom/qcom,rpm.yaml# >> arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: syscon@5700000: compatible: ['syscon'] is too short >> from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml# >> arch/arm/boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dtb: replicator: 'clock-names', 'clocks' do not match any of the regexes: 'pinctrl-[0-9]+' >> from schema $id: http://devicetree.org/schemas/arm/arm,coresight-static-replicator.yaml# > > As far as I can see, all those are generic rather than being introduced > by the new DT. I'll send a set of fixes soon. > Yup, as I checked these are coming from apq8064.dtsi. I was thinking to look into them, but if you're going to go trough them, I'll just drop my R-b on your patchset :) Thanks David -- David Heidelberg
On Sun, 16 Mar 2025 23:16:55 +0100, David Heidelberg wrote:
> Add initial support for LG Nexus 4 (mako).
>
> Features currently working: regulators, eMMC, and volume keys.
>
>
Applied, thanks!
[1/1] ARM: dts: nexus4: Initial dts
commit: f5b7564fedcfd32df68d56781b9d7698343f8fbf
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
On Sun, Mar 16, 2025 at 11:16:55PM +0100, David Heidelberg via B4 Relay wrote: > From: Ivan Belokobylskiy <belokobylskij@gmail.com> > > Add initial support for LG Nexus 4 (mako). > > Features currently working: regulators, eMMC, and volume keys. > > Signed-off-by: Ivan Belokobylskiy <belokobylskij@gmail.com> > Co-developed-by: David Heidelberg <david@ixit.cz> > Signed-off-by: David Heidelberg <david@ixit.cz> > --- > Changes in v5: > - Sorted nodes alphabetically. > - Link to v4: https://lore.kernel.org/r/20250311-lg-nexus4-mako-v4-1-3916c8ec7edb@ixit.cz > > Changes in v4: > - Sorted regulators and added regulators compatible. > - Corrected pmic include and references. > - Moved &rpm outside of / node. > - Moved and simplify pm8921 keypad. > - Added chasis-type. > - Dropped incomplete WiFi node, will be provided in future > contributions. > - Link to v3: https://lore.kernel.org/r/20250309-lg-nexus4-mako-v3-1-1dc2807df296@ixit.cz > > Changes in v3: > - rebased against next-20250307 > - dropped backlight until driver gets converted to DT > > Changes in v2: > - lge vendor doesn't exist anymore, rename to lg > - sdcc@ to mmc@ to comply with dt-schema > --- > arch/arm/boot/dts/qcom/Makefile | 1 + > .../boot/dts/qcom/qcom-apq8064-lg-nexus4-mako.dts | 341 +++++++++++++++++++++ > 2 files changed, 342 insertions(+) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> -- With best wishes Dmitry
© 2016 - 2025 Red Hat, Inc.