[PATCH v3] wifi: mwifiex: Fix HT40 bandwidth issue.

Jeff Chen posted 1 patch 9 months, 1 week ago
drivers/net/wireless/marvell/mwifiex/11n.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
[PATCH v3] wifi: mwifiex: Fix HT40 bandwidth issue.
Posted by Jeff Chen 9 months, 1 week ago
This patch addresses an issue where, despite the AP supporting 40MHz
bandwidth, the connection was limited to 20MHz. Without this fix,
even if the access point supports 40MHz, the bandwidth after
connection remains at 20MHz. This issue is not a regression.

Signed-off-by: Jeff Chen <jeff.chen_1@nxp.com>
---
 drivers/net/wireless/marvell/mwifiex/11n.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/11n.c b/drivers/net/wireless/marvell/mwifiex/11n.c
index 66f0f5377ac1..738bafc3749b 100644
--- a/drivers/net/wireless/marvell/mwifiex/11n.c
+++ b/drivers/net/wireless/marvell/mwifiex/11n.c
@@ -403,12 +403,14 @@ mwifiex_cmd_append_11n_tlv(struct mwifiex_private *priv,
 
 		if (sband->ht_cap.cap & IEEE80211_HT_CAP_SUP_WIDTH_20_40 &&
 		    bss_desc->bcn_ht_oper->ht_param &
-		    IEEE80211_HT_PARAM_CHAN_WIDTH_ANY)
+		    IEEE80211_HT_PARAM_CHAN_WIDTH_ANY) {
+			chan_list->chan_scan_param[0].radio_type |=
+				CHAN_BW_40MHZ << 2;
 			SET_SECONDARYCHAN(chan_list->chan_scan_param[0].
 					  radio_type,
 					  (bss_desc->bcn_ht_oper->ht_param &
 					  IEEE80211_HT_PARAM_CHA_SEC_OFFSET));
-
+		}
 		*buffer += struct_size(chan_list, chan_scan_param, 1);
 		ret_len += struct_size(chan_list, chan_scan_param, 1);
 	}

base-commit: 54be64fdf3ba6dbad2f5c48e466e1db43ad74bca
-- 
2.34.1
Re: [PATCH v3] wifi: mwifiex: Fix HT40 bandwidth issue.
Posted by Francesco Dolcini 9 months, 1 week ago
Hello Jeff,
for future patches, please be sure to have a changelog after the ---
at the end of the commit message.

See
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#commentary

and in general that whole document.


On Fri, Mar 14, 2025 at 05:42:38PM +0800, Jeff Chen wrote:
> This patch addresses an issue where, despite the AP supporting 40MHz
> bandwidth, the connection was limited to 20MHz. Without this fix,
> even if the access point supports 40MHz, the bandwidth after
> connection remains at 20MHz. This issue is not a regression.
> 
> Signed-off-by: Jeff Chen <jeff.chen_1@nxp.com>

Reviewed-by: Francesco Dolcini <francesco.dolcini@toradex.com>

Francesco