dt-bindings: trivial: Document TPS53685

[PATCH v1] dt-bindings: trivial: Document TPS53685

Posted by Chiang Brian 9 months, 1 week ago

Add undocumented tps53685 into compatible in dt-bindings

Signed-off-by: Chiang Brian <chiang.brian@inventec.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index fadbd3c041c8..c98d69facb48 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -380,6 +380,8 @@ properties:
           - ti,tps53676
             # TI Dual channel DCAP+ multiphase controller TPS53679
           - ti,tps53679
+            # TI Dual channel DCAP+ multiphase controller TPS53685 with AMD-SVI3
+          - ti,tps53685
             # TI Dual channel DCAP+ multiphase controller TPS53688
           - ti,tps53688
             # TI DC-DC converters on PMBus
-- 
2.25.1

Re: [PATCH v1] dt-bindings: trivial: Document TPS53685

Posted by Krzysztof Kozlowski 9 months, 1 week ago

On 14/03/2025 04:28, Chiang Brian wrote:
> Add undocumented tps53685 into compatible in dt-bindings
> 
> Signed-off-by: Chiang Brian <chiang.brian@inventec.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index fadbd3c041c8..c98d69facb48 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -380,6 +380,8 @@ properties:
>            - ti,tps53676
>              # TI Dual channel DCAP+ multiphase controller TPS53679
>            - ti,tps53679
> +            # TI Dual channel DCAP+ multiphase controller TPS53685 with AMD-SVI3
> +          - ti,tps53685

There is no user of such compatible, so how can it be undocumented?

Best regards,
Krzysztof

Re: [PATCH v1] dt-bindings: trivial: Document TPS53685

Posted by Chiang Brian 8 months, 1 week ago

On 14/03/2025 07:11, Chiang Brian wrote:
>
> On 14/03/2025 04:28, Chiang Brian wrote:
> > Add undocumented tps53685 into compatible in dt-bindings
> > 
> > Signed-off-by: Chiang Brian <chiang.brian@inventec.com>
> > ---
> >  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> > index fadbd3c041c8..c98d69facb48 100644
> > --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> > @@ -380,6 +380,8 @@ properties:
> >            - ti,tps53676
> >              # TI Dual channel DCAP+ multiphase controller TPS53679
> >            - ti,tps53679
> > +            # TI Dual channel DCAP+ multiphase controller TPS53685 with AMD-SVI3
> > +          - ti,tps53685
>
> There is no user of such compatible, so how can it be undocumented?

The following link is the patch which I would like to add support tps53685,
and I think it is the user of the compatible:
https://lore.kernel.org/lkml/20250314033040.3190642-1-chiang.brian@inventec.com/

Best Regards,
Brian Chiang

Re: [PATCH v1] dt-bindings: trivial: Document TPS53685

Posted by Krzysztof Kozlowski 8 months, 1 week ago

On 11/04/2025 14:47, Chiang Brian wrote:
> On 14/03/2025 07:11, Chiang Brian wrote:
>>
>> On 14/03/2025 04:28, Chiang Brian wrote:
>>> Add undocumented tps53685 into compatible in dt-bindings
>>>
>>> Signed-off-by: Chiang Brian <chiang.brian@inventec.com>
>>> ---
>>>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
>>> index fadbd3c041c8..c98d69facb48 100644
>>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
>>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
>>> @@ -380,6 +380,8 @@ properties:
>>>            - ti,tps53676
>>>              # TI Dual channel DCAP+ multiphase controller TPS53679
>>>            - ti,tps53679
>>> +            # TI Dual channel DCAP+ multiphase controller TPS53685 with AMD-SVI3
>>> +          - ti,tps53685
>>
>> There is no user of such compatible, so how can it be undocumented?
> 
> The following link is the patch which I would like to add support tps53685,
> and I think it is the user of the compatible:

So that patch introduces undocumented compatible? That patchset needs to
be fixed instead - this belongs there. The commit msg here is not
correct: there is no undocumented compatible.

Please also read submitting patches in DT or just simply look how every
other patchset is sent. Every.


Best regards,
Krzysztof