[PATCH v2 2/2] media: vivid: Add more webcam resolutions

Ricardo Ribalda posted 2 patches 9 months, 1 week ago
[PATCH v2 2/2] media: vivid: Add more webcam resolutions
Posted by Ricardo Ribalda 9 months, 1 week ago
Add 3 more common resolution for webcams. This is required to increase
the test coverage of unit tests based on vivid.

Co-developed-by: Hidenori Kobayashi <hidenorik@chromium.org>
Signed-off-by: Hidenori Kobayashi <hidenorik@chromium.org>
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
 drivers/media/test-drivers/vivid/vivid-vid-cap.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/media/test-drivers/vivid/vivid-vid-cap.c b/drivers/media/test-drivers/vivid/vivid-vid-cap.c
index 623ba1e5e54791c0ac62aa2f0fcc3dcd444c873a..df726961222be874c39d19e1fb457bd816ab45fd 100644
--- a/drivers/media/test-drivers/vivid/vivid-vid-cap.c
+++ b/drivers/media/test-drivers/vivid/vivid-vid-cap.c
@@ -25,9 +25,12 @@
 /* Sizes must be in increasing order */
 static const struct v4l2_frmsize_discrete webcam_sizes[] = {
 	{  320, 180 },
+	{  320, 240 },
 	{  640, 360 },
 	{  640, 480 },
 	{ 1280, 720 },
+	{ 1280, 960 },
+	{ 1600, 1200 },
 	{ 1920, 1080 },
 	{ 3840, 2160 },
 };

-- 
2.49.0.rc1.451.g8f38331e32-goog
Re: [PATCH v2 2/2] media: vivid: Add more webcam resolutions
Posted by Hidenori Kobayashi 9 months ago
Re-sending in proper plain text. Sorry, please discard the previous one.

On Fri, Mar 14, 2025 at 12:39:41PM +0000, Ricardo Ribalda wrote:
> Add 3 more common resolution for webcams. This is required to increase
> the test coverage of unit tests based on vivid.
> 
> Co-developed-by: Hidenori Kobayashi <hidenorik@chromium.org>
> Signed-off-by: Hidenori Kobayashi <hidenorik@chromium.org>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
>  drivers/media/test-drivers/vivid/vivid-vid-cap.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/media/test-drivers/vivid/vivid-vid-cap.c b/drivers/media/test-drivers/vivid/vivid-vid-cap.c
> index 623ba1e5e54791c0ac62aa2f0fcc3dcd444c873a..df726961222be874c39d19e1fb457bd816ab45fd 100644
> --- a/drivers/media/test-drivers/vivid/vivid-vid-cap.c
> +++ b/drivers/media/test-drivers/vivid/vivid-vid-cap.c
> @@ -25,9 +25,12 @@
>  /* Sizes must be in increasing order */
>  static const struct v4l2_frmsize_discrete webcam_sizes[] = {
>  	{  320, 180 },
> +	{  320, 240 },
>  	{  640, 360 },
>  	{  640, 480 },
>  	{ 1280, 720 },
> +	{ 1280, 960 },
> +	{ 1600, 1200 },
>  	{ 1920, 1080 },
>  	{ 3840, 2160 },
>  };
> 
> -- 
> 2.49.0.rc1.451.g8f38331e32-goog
> 

Tested-by: Hidenori Kobayashi <hidenorik@chromium.org> # v4l2-compliance,
v4l2-ctl --list-formats-ext