Append the MHI register range to IPQ9574. This is an optional range used
by the dwc controller driver to print debug stats via the debugfs file
'link_transition_count'.

Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
---
v13: Fix 'minItems' for reg-names.
     Update commit log
     Remove 'Fixes'

v12: New patch introduced in this patchset. MHI range was missed in the
     initial post
---
 Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
index 8f628939209e..469b99fa0f0e 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
@@ -175,14 +175,16 @@ allOf:
       properties:
         reg:
           minItems: 5
-          maxItems: 5
+          maxItems: 6
         reg-names:
+          minItems: 5
           items:
             - const: dbi # DesignWare PCIe registers
             - const: elbi # External local bus interface registers
             - const: atu # ATU address space
             - const: parf # Qualcomm specific registers
             - const: config # PCIe configuration space
+            - const: mhi # MHI registers
 
   - if:
       properties:
-- 
2.34.1

On 13/03/2025 09:05, Varadarajan Narayanan wrote:
> Append the MHI register range to IPQ9574. This is an optional range used

Same question, you still did not answer - does hardware have this range?
Which hardware has it?

I pointed out that you affect at least two other variants. Your commit
msg must explain that. For example what if they do not have this range?
Then this change is just wrong.

Start documenting the hardware, not your drivers.

Best regards,
Krzysztof

On Thu, Mar 13, 2025 at 12:01:54PM +0100, Krzysztof Kozlowski wrote:
> On 13/03/2025 09:05, Varadarajan Narayanan wrote:
> > Append the MHI register range to IPQ9574. This is an optional range used
>
> Same question, you still did not answer - does hardware have this range?
> Which hardware has it?

Yes. All three (ipq6018, ipq8074, ipq9574) have this range.

> I pointed out that you affect at least two other variants. Your commit
> msg must explain that. For example what if they do not have this range?
> Then this change is just wrong.
>
> Start documenting the hardware, not your drivers.

Since all three have this range will this commit message be ok?

	Append the MHI register range to ipq6018, ipq8074-gen3 & ipq9574. This
	is an optional range used by the dwc controller driver to print debug
	stats via the debugfs file 'link_transition_count'.

Additionally, should I update ipq6018.dtsi and ipq8074.dtsi also and include in
this patchset?

Thanks
Varada

On Thu, Mar 13, 2025 at 05:21:18PM +0530, Varadarajan Narayanan wrote:
> On Thu, Mar 13, 2025 at 12:01:54PM +0100, Krzysztof Kozlowski wrote:
> > On 13/03/2025 09:05, Varadarajan Narayanan wrote:
> > > Append the MHI register range to IPQ9574. This is an optional range used
> >
> > Same question, you still did not answer - does hardware have this range?
> > Which hardware has it?
> 
> Yes. All three (ipq6018, ipq8074, ipq9574) have this range.


Then explain in the commit msg that you complete the hardware
description for these SoCs.


Best regards,
Krzysztof