-EOPNOTSUPP means not supported, so return -EOPNOTSUPP instead of 1 is
more suitable if ATAPI DMA is not supported in atapi_check_dma().

Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
---
 drivers/ata/libata-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index c085dd81ebe7..2f5af295e8fc 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4544,7 +4544,7 @@ int atapi_check_dma(struct ata_queued_cmd *qc)
 	 */
 	if (!(qc->dev->quirks & ATA_QUIRK_ATAPI_MOD16_DMA) &&
 	    unlikely(qc->nbytes & 15))
-		return 1;
+		return -EOPNOTSUPP;
 
 	if (ap->ops->check_atapi_dma)
 		return ap->ops->check_atapi_dma(qc);
-- 
2.47.1

On Wed, 12 Mar 2025 21:39:54 +0800, Huacai Chen wrote:
> -EOPNOTSUPP means not supported, so return -EOPNOTSUPP instead of 1 is
> more suitable if ATAPI DMA is not supported in atapi_check_dma().
> 
> 

Applied to libata/linux.git (for-6.15), thanks!

[1/1] ata: libata: Return -EOPNOTSUPP instead of 1 in atapi_check_dma()
      https://git.kernel.org/libata/linux/c/725ad028

Kind regards,
Niklas