[PATCH] power: supply: mt6370: Remove redundant 'flush_workqueue()' calls

Chen Ni posted 1 patch 9 months, 1 week ago
drivers/power/supply/mt6370-charger.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] power: supply: mt6370: Remove redundant 'flush_workqueue()' calls
Posted by Chen Ni 9 months, 1 week ago
'destroy_workqueue()' already drains the queue before destroying it, so
there is no need to flush it explicitly.

Remove the redundant 'flush_workqueue()' calls.

This was generated with coccinelle:

@@
expression E;
@@
- flush_workqueue(E);
  destroy_workqueue(E);

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/power/supply/mt6370-charger.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/power/supply/mt6370-charger.c b/drivers/power/supply/mt6370-charger.c
index a6939c6059c7..98579998b300 100644
--- a/drivers/power/supply/mt6370-charger.c
+++ b/drivers/power/supply/mt6370-charger.c
@@ -772,7 +772,6 @@ static void mt6370_chg_destroy_wq(void *data)
 {
 	struct workqueue_struct *wq = data;
 
-	flush_workqueue(wq);
 	destroy_workqueue(wq);
 }
 
-- 
2.25.1
Re: [PATCH] power: supply: mt6370: Remove redundant 'flush_workqueue()' calls
Posted by Sebastian Reichel 9 months, 1 week ago
On Wed, 12 Mar 2025 15:37:29 +0800, Chen Ni wrote:
> 'destroy_workqueue()' already drains the queue before destroying it, so
> there is no need to flush it explicitly.
> 
> Remove the redundant 'flush_workqueue()' calls.
> 
> This was generated with coccinelle:
> 
> [...]

Applied, thanks!

[1/1] power: supply: mt6370: Remove redundant 'flush_workqueue()' calls
      commit: 0b8d073f6c66d7110ac9fab1f13a09337e03f1b6

Best regards,
-- 
Sebastian Reichel <sebastian.reichel@collabora.com>