[PATCH -next] xfs: Remove duplicate xfs_rtbitmap.h header

Jiapeng Chong posted 1 patch 9 months, 1 week ago
fs/xfs/libxfs/xfs_sb.c | 1 -
1 file changed, 1 deletion(-)
[PATCH -next] xfs: Remove duplicate xfs_rtbitmap.h header
Posted by Jiapeng Chong 9 months, 1 week ago
./fs/xfs/libxfs/xfs_sb.c: xfs_rtbitmap.h is included more than once.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=19446
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 fs/xfs/libxfs/xfs_sb.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c
index e42bfd04a7c6..711e180f9ebb 100644
--- a/fs/xfs/libxfs/xfs_sb.c
+++ b/fs/xfs/libxfs/xfs_sb.c
@@ -30,7 +30,6 @@
 #include "xfs_rtgroup.h"
 #include "xfs_rtrmap_btree.h"
 #include "xfs_rtrefcount_btree.h"
-#include "xfs_rtbitmap.h"
 
 /*
  * Physical superblock buffer manipulations. Shared with libxfs in userspace.
-- 
2.32.0.3.g01195cf9f
Re: [PATCH -next] xfs: Remove duplicate xfs_rtbitmap.h header
Posted by Carlos Maiolino 9 months, 1 week ago
On Wed, 12 Mar 2025 09:44:51 +0800, Jiapeng Chong wrote:
> ./fs/xfs/libxfs/xfs_sb.c: xfs_rtbitmap.h is included more than once.
> 
> 

Applied to for-next, thanks!

[1/1] xfs: Remove duplicate xfs_rtbitmap.h header
      commit: fcb255537bee25560af03c583b44866e73a8eb40

Best regards,
-- 
Carlos Maiolino <cem@kernel.org>
Re: [PATCH -next] xfs: Remove duplicate xfs_rtbitmap.h header
Posted by Carlos Maiolino 9 months, 1 week ago
On Wed, Mar 12, 2025 at 09:44:51AM +0800, Jiapeng Chong wrote:
> ./fs/xfs/libxfs/xfs_sb.c: xfs_rtbitmap.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=19446
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

This fixes an issue on the zoned device series, so, I'm adding to the commit:

Fixes: 2167eaabe2fa ("xfs: define the zoned on-disk format")

Thanks!

> ---
>  fs/xfs/libxfs/xfs_sb.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_sb.c b/fs/xfs/libxfs/xfs_sb.c
> index e42bfd04a7c6..711e180f9ebb 100644
> --- a/fs/xfs/libxfs/xfs_sb.c
> +++ b/fs/xfs/libxfs/xfs_sb.c
> @@ -30,7 +30,6 @@
>  #include "xfs_rtgroup.h"
>  #include "xfs_rtrmap_btree.h"
>  #include "xfs_rtrefcount_btree.h"
> -#include "xfs_rtbitmap.h"
> 
>  /*
>   * Physical superblock buffer manipulations. Shared with libxfs in userspace.
> --
> 2.32.0.3.g01195cf9f
>
Re: [PATCH -next] xfs: Remove duplicate xfs_rtbitmap.h header
Posted by Christoph Hellwig 9 months, 1 week ago
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>