[PATCH net 0/7] selftests/net: Mixed select()+polling mode for TCP-AO tests

Dmitry Safonov via B4 Relay posted 7 patches 9 months, 1 week ago
There is a newer version of this series
tools/testing/selftests/net/tcp_ao/connect-deny.c  |  58 ++--
tools/testing/selftests/net/tcp_ao/connect.c       |  22 +-
tools/testing/selftests/net/tcp_ao/icmps-discard.c |  17 +-
.../testing/selftests/net/tcp_ao/key-management.c  |  76 ++---
tools/testing/selftests/net/tcp_ao/lib/aolib.h     | 114 ++++++--
.../testing/selftests/net/tcp_ao/lib/ftrace-tcp.c  |   7 +-
tools/testing/selftests/net/tcp_ao/lib/sock.c      | 315 +++++++++++++++------
tools/testing/selftests/net/tcp_ao/restore.c       |  75 +++--
tools/testing/selftests/net/tcp_ao/rst.c           |  47 ++-
tools/testing/selftests/net/tcp_ao/self-connect.c  |  18 +-
tools/testing/selftests/net/tcp_ao/seq-ext.c       |  30 +-
tools/testing/selftests/net/tcp_ao/unsigned-md5.c  | 118 ++++----
12 files changed, 552 insertions(+), 345 deletions(-)
[PATCH net 0/7] selftests/net: Mixed select()+polling mode for TCP-AO tests
Posted by Dmitry Safonov via B4 Relay 9 months, 1 week ago
Should fix flaky tcp-ao/connect-deny-ipv6 test.
Begging pardon for the delay since the report and for sending it this
late in the release cycle.

Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com>
---
Dmitry Safonov (7):
      selftests/net: Print TCP flags in more common format
      selftests/net: Provide tcp-ao counters comparison helper
      selftests/net: Fetch and check TCP-MD5 counters
      selftests/net: Add mixed select()+polling mode to TCP-AO tests
      selftests/net: Print the testing side in unsigned-md5
      selftests/net: Delete timeout from test_connect_socket()
      selftests/net: Drop timeout argument from test_client_verify()

 tools/testing/selftests/net/tcp_ao/connect-deny.c  |  58 ++--
 tools/testing/selftests/net/tcp_ao/connect.c       |  22 +-
 tools/testing/selftests/net/tcp_ao/icmps-discard.c |  17 +-
 .../testing/selftests/net/tcp_ao/key-management.c  |  76 ++---
 tools/testing/selftests/net/tcp_ao/lib/aolib.h     | 114 ++++++--
 .../testing/selftests/net/tcp_ao/lib/ftrace-tcp.c  |   7 +-
 tools/testing/selftests/net/tcp_ao/lib/sock.c      | 315 +++++++++++++++------
 tools/testing/selftests/net/tcp_ao/restore.c       |  75 +++--
 tools/testing/selftests/net/tcp_ao/rst.c           |  47 ++-
 tools/testing/selftests/net/tcp_ao/self-connect.c  |  18 +-
 tools/testing/selftests/net/tcp_ao/seq-ext.c       |  30 +-
 tools/testing/selftests/net/tcp_ao/unsigned-md5.c  | 118 ++++----
 12 files changed, 552 insertions(+), 345 deletions(-)
---
base-commit: 0fed89a961ea851945d23cc35beb59d6e56c0964
change-id: 20250312-tcp-ao-selftests-polling-21b6bbdf77b6

Best regards,
-- 
Dmitry Safonov <0x7f454c46@gmail.com>
Re: [PATCH net 0/7] selftests/net: Mixed select()+polling mode for TCP-AO tests
Posted by Dmitry Safonov 9 months ago
On Wed, 12 Mar 2025 at 09:11, Dmitry Safonov via B4 Relay
<devnull+0x7f454c46.gmail.com@kernel.org> wrote:
>
> Should fix flaky tcp-ao/connect-deny-ipv6 test.
> Begging pardon for the delay since the report and for sending it this
> late in the release cycle.
>
> Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com>

I think patchwork can't detect v2 to be the same series, so doing it
manually here:
pw-bot: changes-requested

Just in case, v2 link:
https://lore.kernel.org/netdev/20250319-tcp-ao-selftests-polling-v2-0-da48040153d1@gmail.com/

Thanks,
             Dmitry
Re: [PATCH net 0/7] selftests/net: Mixed select()+polling mode for TCP-AO tests
Posted by Dmitry Safonov 9 months ago
On Wed, 19 Mar 2025 at 03:20, Dmitry Safonov <0x7f454c46@gmail.com> wrote:
>
> On Wed, 12 Mar 2025 at 09:11, Dmitry Safonov via B4 Relay
> <devnull+0x7f454c46.gmail.com@kernel.org> wrote:
> >
> > Should fix flaky tcp-ao/connect-deny-ipv6 test.
> > Begging pardon for the delay since the report and for sending it this
> > late in the release cycle.
> >
> > Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com>
>
> I think patchwork can't detect v2 to be the same series, so doing it
> manually here:
> pw-bot: changes-requested

* potentially because of the -net vs -net-next subject.

However, as I sent the patches with b4 relay, it seems patchwork is
unable to authorise me as the author of the series. Ugh :(

> Just in case, v2 link:
> https://lore.kernel.org/netdev/20250319-tcp-ao-selftests-polling-v2-0-da48040153d1@gmail.com/

-- 
             Dmitry
Re: [PATCH net 0/7] selftests/net: Mixed select()+polling mode for TCP-AO tests
Posted by Konstantin Ryabitsev 9 months ago
On Wed, Mar 19, 2025 at 03:26:27AM +0000, Dmitry Safonov wrote:
> However, as I sent the patches with b4 relay, it seems patchwork is
> unable to authorise me as the author of the series. Ugh :(

Oops. We should definitely properly handle this.
Sending a note to self via the helpdesk.

-K
Re: [PATCH net 0/7] selftests/net: Mixed select()+polling mode for TCP-AO tests
Posted by Konstantin Ryabitsev 9 months ago
On Wed, Mar 19, 2025 at 09:18:37AM -0400, Konstantin Ryabitsev wrote:
> On Wed, Mar 19, 2025 at 03:26:27AM +0000, Dmitry Safonov wrote:
> > However, as I sent the patches with b4 relay, it seems patchwork is
> > unable to authorise me as the author of the series. Ugh :(
> 
> Oops. We should definitely properly handle this.
> Sending a note to self via the helpdesk.

This should be handled correctly now, e.g. see this series sent via the relay
yesterday:

https://patchwork.kernel.org/project/netdevbpf/patch/20250319-rfc2203-seqnum-cache-v2-2-2c98b859f2dd@janestreet.com/
vs.
https://lore.kernel.org/netdev/20250319-rfc2203-seqnum-cache-v2-2-2c98b859f2dd@janestreet.com/

-K
Re: [PATCH net 0/7] selftests/net: Mixed select()+polling mode for TCP-AO tests
Posted by Dmitry Safonov 8 months, 4 weeks ago
On Thu, 20 Mar 2025 at 13:51, Konstantin Ryabitsev
<konstantin@linuxfoundation.org> wrote:
>
> On Wed, Mar 19, 2025 at 09:18:37AM -0400, Konstantin Ryabitsev wrote:
> > On Wed, Mar 19, 2025 at 03:26:27AM +0000, Dmitry Safonov wrote:
> > > However, as I sent the patches with b4 relay, it seems patchwork is
> > > unable to authorise me as the author of the series. Ugh :(
> >
> > Oops. We should definitely properly handle this.
> > Sending a note to self via the helpdesk.
>
> This should be handled correctly now, e.g. see this series sent via the relay
> yesterday:
>
> https://patchwork.kernel.org/project/netdevbpf/patch/20250319-rfc2203-seqnum-cache-v2-2-2c98b859f2dd@janestreet.com/
> vs.
> https://lore.kernel.org/netdev/20250319-rfc2203-seqnum-cache-v2-2-2c98b859f2dd@janestreet.com/

Thank you, Konstantin!
I appreciate your fixes and b4 development.

Thanks,
             Dmitry