[PATCH] wifi: rtw88: Add __nonstring annotations for unterminated strings

Kees Cook posted 1 patch 11 months ago
drivers/net/wireless/realtek/rtw88/main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] wifi: rtw88: Add __nonstring annotations for unterminated strings
Posted by Kees Cook 11 months ago
When a character array without a terminating NUL character has a static
initializer, GCC 15's -Wunterminated-string-initialization will only
warn if the array lacks the "nonstring" attribute[1]. Mark the arrays
with __nonstring to and correctly identify the char array as "not a C
string" and thereby eliminate the warning.

Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117178 [1]
Cc: Ping-Ke Shih <pkshih@realtek.com>
Cc: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Signed-off-by: Kees Cook <kees@kernel.org>
---
 drivers/net/wireless/realtek/rtw88/main.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtw88/main.h b/drivers/net/wireless/realtek/rtw88/main.h
index 62cd4c526301..5d6df6b51698 100644
--- a/drivers/net/wireless/realtek/rtw88/main.h
+++ b/drivers/net/wireless/realtek/rtw88/main.h
@@ -822,7 +822,7 @@ struct rtw_vif {
 };
 
 struct rtw_regulatory {
-	char alpha2[2];
+	char alpha2[2] __nonstring;
 	u8 txpwr_regd_2g;
 	u8 txpwr_regd_5g;
 };
-- 
2.34.1
Re: [PATCH] wifi: rtw88: Add __nonstring annotations for unterminated strings
Posted by Ping-Ke Shih 11 months ago
Kees Cook <kees@kernel.org> wrote:

> When a character array without a terminating NUL character has a static
> initializer, GCC 15's -Wunterminated-string-initialization will only
> warn if the array lacks the "nonstring" attribute[1]. Mark the arrays
> with __nonstring to and correctly identify the char array as "not a C
> string" and thereby eliminate the warning.
> 
> Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=117178 [1]
> Cc: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Johannes Berg <johannes@sipsolutions.net>
> Cc: linux-wireless@vger.kernel.org
> Signed-off-by: Kees Cook <kees@kernel.org>

1 patch(es) applied to rtw-next branch of rtw.git, thanks.

d58ad77d5cc2 wifi: rtw88: Add __nonstring annotations for unterminated strings

---
https://github.com/pkshih/rtw.git