[PATCH v2 10/10] sched: Add deprecation warning for users of RT_GROUP_SCHED

Michal Koutný posted 10 patches 9 months, 1 week ago
[PATCH v2 10/10] sched: Add deprecation warning for users of RT_GROUP_SCHED
Posted by Michal Koutný 9 months, 1 week ago
Signed-off-by: Michal Koutný <mkoutny@suse.com>
---
 kernel/sched/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 4b2d9ec0c1f23..6866355046d21 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -9748,6 +9748,7 @@ static int cpu_cfs_local_stat_show(struct seq_file *sf, void *v)
 static int cpu_rt_runtime_write(struct cgroup_subsys_state *css,
 				struct cftype *cft, s64 val)
 {
+	pr_warn_once("RT_GROUP throttling is deprecated, use global sched_rt_runtime_us and deadline tasks.\n");
 	return sched_group_set_rt_runtime(css_tg(css), val);
 }
 
-- 
2.48.1

Re: [PATCH v2 10/10] sched: Add deprecation warning for users of RT_GROUP_SCHED
Posted by Michal Koutný 8 months ago
Hello.

On Mon, Mar 10, 2025 at 06:04:42PM +0100, Michal Koutný <mkoutny@suse.com> wrote:
...
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
...
>  static int cpu_rt_runtime_write(struct cgroup_subsys_state *css,
>                                 struct cftype *cft, s64 val)
> {
> +	pr_warn_once("RT_GROUP throttling is deprecated, use global sched_rt_runtime_us and deadline tasks.\n");

I just noticed that this patch isn't picked together with the rest of
the series in tip/sched/core.
Did it slip through the cracks (as the last one) or is that intentional
for some reason?

Thanks,
Michal
Re: [PATCH v2 10/10] sched: Add deprecation warning for users of RT_GROUP_SCHED
Posted by Michal Koutný 7 months, 2 weeks ago
Hello Peter.

On Thu, Apr 17, 2025 at 02:13:25PM +0200, Michal Koutný <mkoutny@suse.com> wrote:
> On Mon, Mar 10, 2025 at 06:04:42PM +0100, Michal Koutný <mkoutny@suse.com> wrote:
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> ...
> >  static int cpu_rt_runtime_write(struct cgroup_subsys_state *css,
> >                                 struct cftype *cft, s64 val)
> > {
> > +	pr_warn_once("RT_GROUP throttling is deprecated, use global sched_rt_runtime_us and deadline tasks.\n");
> 
> I just noticed that this patch isn't picked together with the rest of
> the series in tip/sched/core.
> Did it slip through the cracks (as the last one) or is that intentional
> for some reason?

I'm still wondering about this so that the users get right (or no)
message.