[PATCH 0/1] HID: amd_sfh: Add support for tablet mode

Denis Benato posted 1 patch 11 months ago
drivers/hid/amd-sfh-hid/amd_sfh_client.c      |  2 ++
drivers/hid/amd-sfh-hid/amd_sfh_pcie.c        |  4 +++
drivers/hid/amd-sfh-hid/amd_sfh_pcie.h        |  1 +
.../hid_descriptor/amd_sfh_hid_desc.c         | 27 +++++++++++++++++++
.../hid_descriptor/amd_sfh_hid_desc.h         |  8 ++++++
.../hid_descriptor/amd_sfh_hid_report_desc.h  | 20 ++++++++++++++
6 files changed, 62 insertions(+)
[PATCH 0/1] HID: amd_sfh: Add support for tablet mode
Posted by Denis Benato 11 months ago
Recently there has been a renewed interest in this patch: ASUS has launched a new z13 model
and many more users requested tablet mode support for previous models.

I have made required adjustments to apply cleanly on top of linux-next:
nothing substantial, a macro has been changed from 5 to 6 upstream as
the previous patch also did and a few line changed their position.

Given there were no functional changes at all I took
the liberty to retain previous tags.

Denis Benato (1):
  HID: amd_sfh: Add support for tablet mode switch sensors

 drivers/hid/amd-sfh-hid/amd_sfh_client.c      |  2 ++
 drivers/hid/amd-sfh-hid/amd_sfh_pcie.c        |  4 +++
 drivers/hid/amd-sfh-hid/amd_sfh_pcie.h        |  1 +
 .../hid_descriptor/amd_sfh_hid_desc.c         | 27 +++++++++++++++++++
 .../hid_descriptor/amd_sfh_hid_desc.h         |  8 ++++++
 .../hid_descriptor/amd_sfh_hid_report_desc.h  | 20 ++++++++++++++
 6 files changed, 62 insertions(+)

-- 
2.48.1
Re: [PATCH 0/1] HID: amd_sfh: Add support for tablet mode
Posted by Jiri Kosina 9 months, 2 weeks ago
On Sun, 9 Mar 2025, Denis Benato wrote:

> Recently there has been a renewed interest in this patch: ASUS has launched a new z13 model
> and many more users requested tablet mode support for previous models.
> 
> I have made required adjustments to apply cleanly on top of linux-next:
> nothing substantial, a macro has been changed from 5 to 6 upstream as
> the previous patch also did and a few line changed their position.
> 
> Given there were no functional changes at all I took
> the liberty to retain previous tags.
> 
> Denis Benato (1):
>   HID: amd_sfh: Add support for tablet mode switch sensors
> 
>  drivers/hid/amd-sfh-hid/amd_sfh_client.c      |  2 ++
>  drivers/hid/amd-sfh-hid/amd_sfh_pcie.c        |  4 +++
>  drivers/hid/amd-sfh-hid/amd_sfh_pcie.h        |  1 +
>  .../hid_descriptor/amd_sfh_hid_desc.c         | 27 +++++++++++++++++++
>  .../hid_descriptor/amd_sfh_hid_desc.h         |  8 ++++++
>  .../hid_descriptor/amd_sfh_hid_report_desc.h  | 20 ++++++++++++++
>  6 files changed, 62 insertions(+)

Basavaraj, could you please provide your Acked-by/Reviewed-by: for this 
(or any other sort of feedback)?

Thanks,

-- 
Jiri Kosina
SUSE Labs
Re: [PATCH 0/1] HID: amd_sfh: Add support for tablet mode
Posted by Basavaraj Natikar 9 months, 2 weeks ago
On 4/24/2025 2:57 PM, Jiri Kosina wrote:
> On Sun, 9 Mar 2025, Denis Benato wrote:
>
>> Recently there has been a renewed interest in this patch: ASUS has launched a new z13 model
>> and many more users requested tablet mode support for previous models.
>>
>> I have made required adjustments to apply cleanly on top of linux-next:
>> nothing substantial, a macro has been changed from 5 to 6 upstream as
>> the previous patch also did and a few line changed their position.
>>
>> Given there were no functional changes at all I took
>> the liberty to retain previous tags.
>>
>> Denis Benato (1):
>>    HID: amd_sfh: Add support for tablet mode switch sensors
>>
>>   drivers/hid/amd-sfh-hid/amd_sfh_client.c      |  2 ++
>>   drivers/hid/amd-sfh-hid/amd_sfh_pcie.c        |  4 +++
>>   drivers/hid/amd-sfh-hid/amd_sfh_pcie.h        |  1 +
>>   .../hid_descriptor/amd_sfh_hid_desc.c         | 27 +++++++++++++++++++
>>   .../hid_descriptor/amd_sfh_hid_desc.h         |  8 ++++++
>>   .../hid_descriptor/amd_sfh_hid_report_desc.h  | 20 ++++++++++++++
>>   6 files changed, 62 insertions(+)
> Basavaraj, could you please provide your Acked-by/Reviewed-by: for this
> (or any other sort of feedback)?

Sure, Jiri, I will get back to this patch soon.

We are reviewing similar features and related issues,
and we may need some more time to investigate them internally.

Therefore, I would like to hold off on this patch for a little longer
before providing feedback.

Thanks,
--
Basavaraj

>
> Thanks,
>
Re: [PATCH 0/1] HID: amd_sfh: Add support for tablet mode
Posted by Paweł Kotiuk 5 months, 3 weeks ago
> Sure, Jiri, I will get back to this patch soon.

Hi Basavaraj,

Could yougive us at least a rough estimate when you will be able to check this patch?

Thanks in advance
Paweł
Re: [PATCH 0/1] HID: amd_sfh: Add support for tablet mode
Posted by Jiri Kosina 9 months, 2 weeks ago
On Thu, 24 Apr 2025, Basavaraj Natikar wrote:

> >> Recently there has been a renewed interest in this patch: ASUS has launched
> >> a new z13 model
> >> and many more users requested tablet mode support for previous models.
> >>
> >> I have made required adjustments to apply cleanly on top of linux-next:
> >> nothing substantial, a macro has been changed from 5 to 6 upstream as
> >> the previous patch also did and a few line changed their position.
> >>
> >> Given there were no functional changes at all I took
> >> the liberty to retain previous tags.
> >>
> >> Denis Benato (1):
> >>    HID: amd_sfh: Add support for tablet mode switch sensors
> >>
> >>   drivers/hid/amd-sfh-hid/amd_sfh_client.c      |  2 ++
> >>   drivers/hid/amd-sfh-hid/amd_sfh_pcie.c        |  4 +++
> >>   drivers/hid/amd-sfh-hid/amd_sfh_pcie.h        |  1 +
> >>   .../hid_descriptor/amd_sfh_hid_desc.c         | 27 +++++++++++++++++++
> >>   .../hid_descriptor/amd_sfh_hid_desc.h         |  8 ++++++
> >>   .../hid_descriptor/amd_sfh_hid_report_desc.h  | 20 ++++++++++++++
> >>   6 files changed, 62 insertions(+)
> > Basavaraj, could you please provide your Acked-by/Reviewed-by: for this
> > (or any other sort of feedback)?
> 
> Sure, Jiri, I will get back to this patch soon.
> 
> We are reviewing similar features and related issues,
> and we may need some more time to investigate them internally.
> 
> Therefore, I would like to hold off on this patch for a little longer
> before providing feedback.

Fair enough, thanks for the update.

-- 
Jiri Kosina
SUSE Labs