[PATCH v5 3/7] arch: arm64: qcom: sc7280: Remove optional elbi register

Krishna Chaitanya Chundru posted 7 patches 11 months, 1 week ago
There is a newer version of this series
[PATCH v5 3/7] arch: arm64: qcom: sc7280: Remove optional elbi register
Posted by Krishna Chaitanya Chundru 11 months, 1 week ago
ELBI registers are optional registers which are not used by this
platform. So removing the elbi registers from PCIe node.

Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 64c46221d8bf..e556285d6b75 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2202,11 +2202,10 @@ pcie1: pcie@1c08000 {
 			compatible = "qcom,pcie-sc7280";
 			reg = <0 0x01c08000 0 0x3000>,
 			      <4 0x00000000 0 0xf1d>,
-			      <4 0x00000f20 0 0xa8>,
 			      <4 0x10000000 0 0x1000>,
 			      <4 0x00000000 0 0x10000000>;
 
-			reg-names = "parf", "dbi", "elbi", "atu", "config";
+			reg-names = "parf", "dbi", "atu", "config";
 			device_type = "pci";
 			linux,pci-domain = <1>;
 			bus-range = <0x00 0xff>;

-- 
2.34.1
Re: [PATCH v5 3/7] arch: arm64: qcom: sc7280: Remove optional elbi register
Posted by Krzysztof Kozlowski 11 months ago
On Sun, Mar 09, 2025 at 11:15:25AM +0530, Krishna Chaitanya Chundru wrote:
> ELBI registers are optional registers which are not used by this
> platform. So removing the elbi registers from PCIe node.
> 
> Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +--


Please use standard email subjects, so with the PATCH keyword in the
title. 'git format-patch -vX' helps here to create proper versioned patches.
Another useful tool is b4. Skipping the PATCH keyword makes filtering of
emails more difficult thus making the review process less convenient.

That's a v5 and still wrong... Can you pass the patchset through
internal review first?

Best regards,
Krzysztof