[v1] bcachefs: Remove unnecessary byte allocation

[RESEND PATCH] bcachefs: Remove unnecessary byte allocation

Posted by Thorsten Blum 9 months, 2 weeks ago

The extra byte is not used - remove it.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 fs/bcachefs/fs-ioctl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/bcachefs/fs-ioctl.c b/fs/bcachefs/fs-ioctl.c
index d9f1a7c09e85..9761a365552a 100644
--- a/fs/bcachefs/fs-ioctl.c
+++ b/fs/bcachefs/fs-ioctl.c
@@ -244,7 +244,7 @@ static int bch2_ioc_reinherit_attrs(struct bch_fs *c,
 	int ret = 0;
 	subvol_inum inum;
 
-	kname = kmalloc(BCH_NAME_MAX + 1, GFP_KERNEL);
+	kname = kmalloc(BCH_NAME_MAX, GFP_KERNEL);
 	if (!kname)
 		return -ENOMEM;
 
-- 
2.48.1

Re: [RESEND PATCH] bcachefs: Remove unnecessary byte allocation

Posted by Kent Overstreet 9 months, 2 weeks ago

On Sat, Mar 08, 2025 at 08:53:53PM +0100, Thorsten Blum wrote:
> The extra byte is not used - remove it.
> 
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

applied
> ---
>  fs/bcachefs/fs-ioctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/bcachefs/fs-ioctl.c b/fs/bcachefs/fs-ioctl.c
> index d9f1a7c09e85..9761a365552a 100644
> --- a/fs/bcachefs/fs-ioctl.c
> +++ b/fs/bcachefs/fs-ioctl.c
> @@ -244,7 +244,7 @@ static int bch2_ioc_reinherit_attrs(struct bch_fs *c,
>  	int ret = 0;
>  	subvol_inum inum;
>  
> -	kname = kmalloc(BCH_NAME_MAX + 1, GFP_KERNEL);
> +	kname = kmalloc(BCH_NAME_MAX, GFP_KERNEL);
>  	if (!kname)
>  		return -ENOMEM;
>  
> -- 
> 2.48.1
>