f2fs: disalbe nat_bits by default

[PATCH] f2fs: disalbe nat_bits by default

Posted by Chao Yu 11 months, 1 week ago

Let's disable nat_bits by default.

Signed-off-by: Chao Yu <chao@kernel.org>
---
 fs/f2fs/node.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 56873c41436e..3148d9e44e7f 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -3286,6 +3286,9 @@ static int init_node_manager(struct f2fs_sb_info *sbi)
 	if (!nm_i->nat_bitmap)
 		return -ENOMEM;
 
+	/* disable nat_bits feature by default */
+	disable_nat_bits(sbi, true);
+
 	err = __get_nat_bitmaps(sbi);
 	if (err)
 		return err;
-- 
2.40.1

Re: [PATCH] f2fs: disalbe nat_bits by default

Posted by Jaegeuk Kim 11 months, 1 week ago

I meant let's support it conservatively if someone needs to enable
in other platform.

On 03/07, Chao Yu wrote:
> Let's disable nat_bits by default.
> 
> Signed-off-by: Chao Yu <chao@kernel.org>
> ---
>  fs/f2fs/node.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> index 56873c41436e..3148d9e44e7f 100644
> --- a/fs/f2fs/node.c
> +++ b/fs/f2fs/node.c
> @@ -3286,6 +3286,9 @@ static int init_node_manager(struct f2fs_sb_info *sbi)
>  	if (!nm_i->nat_bitmap)
>  		return -ENOMEM;
>  
> +	/* disable nat_bits feature by default */
> +	disable_nat_bits(sbi, true);
> +
>  	err = __get_nat_bitmaps(sbi);
>  	if (err)
>  		return err;
> -- 
> 2.40.1

Re: [PATCH] f2fs: disalbe nat_bits by default

Posted by Chao Yu 11 months ago

On 2025/3/8 2:10, Jaegeuk Kim wrote:
> I meant let's support it conservatively if someone needs to enable
> in other platform.

Oh, I've updated it, we can control it via mount option now.

Thanks,

> 
> On 03/07, Chao Yu wrote:
>> Let's disable nat_bits by default.
>>
>> Signed-off-by: Chao Yu <chao@kernel.org>
>> ---
>>   fs/f2fs/node.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
>> index 56873c41436e..3148d9e44e7f 100644
>> --- a/fs/f2fs/node.c
>> +++ b/fs/f2fs/node.c
>> @@ -3286,6 +3286,9 @@ static int init_node_manager(struct f2fs_sb_info *sbi)
>>   	if (!nm_i->nat_bitmap)
>>   		return -ENOMEM;
>>   
>> +	/* disable nat_bits feature by default */
>> +	disable_nat_bits(sbi, true);
>> +
>>   	err = __get_nat_bitmaps(sbi);
>>   	if (err)
>>   		return err;
>> -- 
>> 2.40.1