[PATCH v3 2/3] arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B

Nam Tran posted 3 patches 11 months, 1 week ago
There is a newer version of this series
[PATCH v3 2/3] arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B
Posted by Nam Tran 11 months, 1 week ago
Add the LP5812 LED driver node to the Device Tree for Raspberry Pi 4 B.
This enables the LED connected to the LP5812 to be controlled via I2C.

Signed-off-by: Nam Tran <trannamatk@gmail.com>
---
 arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
index 353bb50ce542..85441746d94b 100644
--- a/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
+++ b/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
@@ -270,3 +270,13 @@ &vec {
 &wifi_pwrseq {
 	reset-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>;
 };
+
+&i2c1 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	led-controller@1b {
+		compatible = "ti,lp5812";
+		reg = <0x1b>;
+	};
+};
-- 
2.25.1
Re: [PATCH v3 2/3] arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B
Posted by Krzysztof Kozlowski 11 months, 1 week ago
On Fri, Mar 07, 2025 at 12:21:25AM +0700, Nam Tran wrote:
> Add the LP5812 LED driver node to the Device Tree for Raspberry Pi 4 B.
> This enables the LED connected to the LP5812 to be controlled via I2C.
> 
> Signed-off-by: Nam Tran <trannamatk@gmail.com>
> ---
>  arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts b/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> index 353bb50ce542..85441746d94b 100644
> --- a/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> +++ b/arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts
> @@ -270,3 +270,13 @@ &vec {
>  &wifi_pwrseq {
>  	reset-gpios = <&expgpio 1 GPIO_ACTIVE_LOW>;
>  };
> +
> +&i2c1 {

Follow ordering of nodes explained in DTS coding style.

Best regards,
Krzysztof
Re: [PATCH v3 2/3] arm64: dts: Add LP5812 LED node for Raspberry Pi 4 Model B
Posted by Krzysztof Kozlowski 11 months, 1 week ago
On Fri, Mar 07, 2025 at 12:21:25AM +0700, Nam Tran wrote:
> Add the LP5812 LED driver node to the Device Tree for Raspberry Pi 4 B.
> This enables the LED connected to the LP5812 to be controlled via I2C.
> 
> Signed-off-by: Nam Tran <trannamatk@gmail.com>
> ---
>  arch/arm/boot/dts/broadcom/bcm2711-rpi-4-b.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)

One more: DTS is *never* in the middle of patchset. It is always at the
end.

Best regards,
Krzysztof