[PATCH 04/11] arm64: dts: qcom: msm8916: Fix KPSS ACC compatible

Konrad Dybcio posted 11 patches 11 months, 1 week ago
[PATCH 04/11] arm64: dts: qcom: msm8916: Fix KPSS ACC compatible
Posted by Konrad Dybcio 11 months, 1 week ago
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

The current compatible has been used with no corresponding
documentation. Replace it with one that has been documented.

This has no functional effect, as these nodes' resources are only
consumed through a phandle reference, anyway.

Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
 arch/arm64/boot/dts/qcom/msm8916.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
index 8f35c9af18782aa1da7089988692e6588c4b7c5d..33a28f8163dda0e53f4176d61738ce175efc096c 100644
--- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
@@ -2574,7 +2574,7 @@ frame@b028000 {
 		};
 
 		cpu0_acc: power-manager@b088000 {
-			compatible = "qcom,msm8916-acc";
+			compatible = "qcom,msm8916-kpss-acc";
 			reg = <0x0b088000 0x1000>;
 			status = "reserved"; /* Controlled by PSCI firmware */
 		};
@@ -2586,7 +2586,7 @@ cpu0_saw: power-manager@b089000 {
 		};
 
 		cpu1_acc: power-manager@b098000 {
-			compatible = "qcom,msm8916-acc";
+			compatible = "qcom,msm8916-kpss-acc";
 			reg = <0x0b098000 0x1000>;
 			status = "reserved"; /* Controlled by PSCI firmware */
 		};
@@ -2598,7 +2598,7 @@ cpu1_saw: power-manager@b099000 {
 		};
 
 		cpu2_acc: power-manager@b0a8000 {
-			compatible = "qcom,msm8916-acc";
+			compatible = "qcom,msm8916-kpss-acc";
 			reg = <0x0b0a8000 0x1000>;
 			status = "reserved"; /* Controlled by PSCI firmware */
 		};
@@ -2610,7 +2610,7 @@ cpu2_saw: power-manager@b0a9000 {
 		};
 
 		cpu3_acc: power-manager@b0b8000 {
-			compatible = "qcom,msm8916-acc";
+			compatible = "qcom,msm8916-kpss-acc";
 			reg = <0x0b0b8000 0x1000>;
 			status = "reserved"; /* Controlled by PSCI firmware */
 		};

-- 
2.48.1
Re: [PATCH 04/11] arm64: dts: qcom: msm8916: Fix KPSS ACC compatible
Posted by Dmitry Baryshkov 11 months, 1 week ago
On Thu, Mar 06, 2025 at 07:11:16PM +0100, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> 
> The current compatible has been used with no corresponding
> documentation. Replace it with one that has been documented.

qcom,msm8916-kpss-acc is also not documented. Most likely you meant
qcom,kpss-acc-v2

> 
> This has no functional effect, as these nodes' resources are only
> consumed through a phandle reference, anyway.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/msm8916.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> index 8f35c9af18782aa1da7089988692e6588c4b7c5d..33a28f8163dda0e53f4176d61738ce175efc096c 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi
> @@ -2574,7 +2574,7 @@ frame@b028000 {
>  		};
>  
>  		cpu0_acc: power-manager@b088000 {
> -			compatible = "qcom,msm8916-acc";
> +			compatible = "qcom,msm8916-kpss-acc";
>  			reg = <0x0b088000 0x1000>;
>  			status = "reserved"; /* Controlled by PSCI firmware */
>  		};
> @@ -2586,7 +2586,7 @@ cpu0_saw: power-manager@b089000 {
>  		};
>  
>  		cpu1_acc: power-manager@b098000 {
> -			compatible = "qcom,msm8916-acc";
> +			compatible = "qcom,msm8916-kpss-acc";
>  			reg = <0x0b098000 0x1000>;
>  			status = "reserved"; /* Controlled by PSCI firmware */
>  		};
> @@ -2598,7 +2598,7 @@ cpu1_saw: power-manager@b099000 {
>  		};
>  
>  		cpu2_acc: power-manager@b0a8000 {
> -			compatible = "qcom,msm8916-acc";
> +			compatible = "qcom,msm8916-kpss-acc";
>  			reg = <0x0b0a8000 0x1000>;
>  			status = "reserved"; /* Controlled by PSCI firmware */
>  		};
> @@ -2610,7 +2610,7 @@ cpu2_saw: power-manager@b0a9000 {
>  		};
>  
>  		cpu3_acc: power-manager@b0b8000 {
> -			compatible = "qcom,msm8916-acc";
> +			compatible = "qcom,msm8916-kpss-acc";
>  			reg = <0x0b0b8000 0x1000>;
>  			status = "reserved"; /* Controlled by PSCI firmware */
>  		};
> 
> -- 
> 2.48.1
> 

-- 
With best wishes
Dmitry