Correct commit 20972609d12c ("drm/msm/dpu: Require modeset if clone mode
status changes") and describe old_crtc_state and new_crtc_state params
instead of the single previously used parameter crtc_state.
Fixes: 20972609d12c ("drm/msm/dpu: Require modeset if clone mode status changes")
Signed-off-by: Dmitry Baryshkov <lumag@kernel.org>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
index b0a062d6fa3bf942ffd687a91bccac3aa4f06f02..536d15818ba24f8b11f24e3bd9726d31c57ef531 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
@@ -1395,7 +1395,8 @@ static int dpu_crtc_assign_resources(struct drm_crtc *crtc,
/**
* dpu_crtc_check_mode_changed: check if full modeset is required
- * @crtc_state: Corresponding CRTC state to be checked
+ * @old_crtc_state: Previous CRTC state
+ * @new_crtc_state: Corresponding CRTC state to be checked
*
* Check if the changes in the object properties demand full mode set.
*/
--
2.39.5
On Thu, Mar 6, 2025 at 12:22 AM Dmitry Baryshkov <lumag@kernel.org> wrote:
>
> Correct commit 20972609d12c ("drm/msm/dpu: Require modeset if clone mode
> status changes") and describe old_crtc_state and new_crtc_state params
> instead of the single previously used parameter crtc_state.
>
> Fixes: 20972609d12c ("drm/msm/dpu: Require modeset if clone mode status changes")
> Signed-off-by: Dmitry Baryshkov <lumag@kernel.org>
Reviewed-by: Rob Clark <robdclark@gmail.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> index b0a062d6fa3bf942ffd687a91bccac3aa4f06f02..536d15818ba24f8b11f24e3bd9726d31c57ef531 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> @@ -1395,7 +1395,8 @@ static int dpu_crtc_assign_resources(struct drm_crtc *crtc,
>
> /**
> * dpu_crtc_check_mode_changed: check if full modeset is required
> - * @crtc_state: Corresponding CRTC state to be checked
> + * @old_crtc_state: Previous CRTC state
> + * @new_crtc_state: Corresponding CRTC state to be checked
> *
> * Check if the changes in the object properties demand full mode set.
> */
>
> --
> 2.39.5
>
© 2016 - 2026 Red Hat, Inc.