[PATCH v2] staging: iio: adis16203: Remove unneeded spi_set_drvdata()

Saalim Quadri posted 1 patch 11 months, 1 week ago
drivers/staging/iio/accel/adis16203.c | 2 --
1 file changed, 2 deletions(-)
[PATCH v2] staging: iio: adis16203: Remove unneeded spi_set_drvdata()
Posted by Saalim Quadri 11 months, 1 week ago
By making use of devm_iio_device_register(), we no longer have a driver
remove callback.
Since this was the last user of spi_get_drvdata(),
we can drop the call to spi_set_drvdata().

Signed-off-by: Saalim Quadri <danascape@gmail.com>
---
 drivers/staging/iio/accel/adis16203.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
index c1c73308800c..3faf3c61046a 100644
--- a/drivers/staging/iio/accel/adis16203.c
+++ b/drivers/staging/iio/accel/adis16203.c
@@ -267,8 +267,6 @@ static int adis16203_probe(struct spi_device *spi)
 	if (!indio_dev)
 		return -ENOMEM;
 	st = iio_priv(indio_dev);
-	/* this is only used for removal purposes */
-	spi_set_drvdata(spi, indio_dev);
 
 	indio_dev->name = spi->dev.driver->name;
 	indio_dev->channels = adis16203_channels;
-- 
2.34.1
Re: [PATCH v2] staging: iio: adis16203: Remove unneeded spi_set_drvdata()
Posted by Jonathan Cameron 11 months ago
On Thu,  6 Mar 2025 05:19:49 +0530
Saalim Quadri <danascape@gmail.com> wrote:

> By making use of devm_iio_device_register(), we no longer have a driver
> remove callback.
> Since this was the last user of spi_get_drvdata(),
> we can drop the call to spi_set_drvdata().
> 
> Signed-off-by: Saalim Quadri <danascape@gmail.com>
As per other discussion. Dropping this one as 
better to merge support into the adis16201 driver.

> ---
>  drivers/staging/iio/accel/adis16203.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/accel/adis16203.c b/drivers/staging/iio/accel/adis16203.c
> index c1c73308800c..3faf3c61046a 100644
> --- a/drivers/staging/iio/accel/adis16203.c
> +++ b/drivers/staging/iio/accel/adis16203.c
> @@ -267,8 +267,6 @@ static int adis16203_probe(struct spi_device *spi)
>  	if (!indio_dev)
>  		return -ENOMEM;
>  	st = iio_priv(indio_dev);
> -	/* this is only used for removal purposes */
> -	spi_set_drvdata(spi, indio_dev);
>  
>  	indio_dev->name = spi->dev.driver->name;
>  	indio_dev->channels = adis16203_channels;
Re: [PATCH v2] staging: iio: adis16203: Remove unneeded spi_set_drvdata()
Posted by Saalim Quadri 11 months, 1 week ago
Sorry, I forgot to add a V2 description

V1 -> V2: Update commit message description

Sincerely,
Saalim Quadri